* [PATCH] video: platinumfb: Add __devexit_p at necessary place
@ 2011-10-05 8:01 Axel Lin
2011-10-16 21:34 ` Florian Tobias Schandinat
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-10-05 8:01 UTC (permalink / raw)
To: linux-kernel; +Cc: Florian Tobias Schandinat, linux-fbdev
According to the comments in include/linux/init.h:
"Pointers to __devexit functions must use __devexit_p(function_name), the
wrapper will insert either the function_name or NULL, depending on the config
options."
We have __devexit annotation for platinumfb_remove(), thus add __devexit_p at
necessary place.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/platinumfb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/platinumfb.c b/drivers/video/platinumfb.c
index 6694923..ae3caa6 100644
--- a/drivers/video/platinumfb.c
+++ b/drivers/video/platinumfb.c
@@ -683,7 +683,7 @@ static struct platform_driver platinum_driver .of_match_table = platinumfb_match,
},
.probe = platinumfb_probe,
- .remove = platinumfb_remove,
+ .remove = __devexit_p(platinumfb_remove),
};
static int __init platinumfb_init(void)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: platinumfb: Add __devexit_p at necessary place
2011-10-05 8:01 [PATCH] video: platinumfb: Add __devexit_p at necessary place Axel Lin
@ 2011-10-16 21:34 ` Florian Tobias Schandinat
0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2011-10-16 21:34 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, linux-fbdev
On 10/05/2011 08:01 AM, Axel Lin wrote:
> According to the comments in include/linux/init.h:
>
> "Pointers to __devexit functions must use __devexit_p(function_name), the
> wrapper will insert either the function_name or NULL, depending on the config
> options."
>
> We have __devexit annotation for platinumfb_remove(), thus add __devexit_p at
> necessary place.
Applied.
Thanks,
Florian Tobias Schandinat
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/platinumfb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/platinumfb.c b/drivers/video/platinumfb.c
> index 6694923..ae3caa6 100644
> --- a/drivers/video/platinumfb.c
> +++ b/drivers/video/platinumfb.c
> @@ -683,7 +683,7 @@ static struct platform_driver platinum_driver > .of_match_table = platinumfb_match,
> },
> .probe = platinumfb_probe,
> - .remove = platinumfb_remove,
> + .remove = __devexit_p(platinumfb_remove),
> };
>
> static int __init platinumfb_init(void)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-16 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-05 8:01 [PATCH] video: platinumfb: Add __devexit_p at necessary place Axel Lin
2011-10-16 21:34 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).