linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	linux-fbdev@vger.kernel.org
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 7/8] fbdev/amifb: Enable Copper DMA after setting up the Copper
Date: Mon, 21 Nov 2011 20:53:58 +0000	[thread overview]
Message-ID: <1321908839-11419-7-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1321908839-11419-1-git-send-email-geert@linux-m68k.org>

Else the Copper may start executing random instructions

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/video/amifb.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/video/amifb.c b/drivers/video/amifb.c
index 13e7a17..2bfaf1b 100644
--- a/drivers/video/amifb.c
+++ b/drivers/video/amifb.c
@@ -3733,17 +3733,15 @@ default_chipset:
 	memset(dummysprite, 0, DUMMYSPRITEMEMSIZE);
 
 	/*
-	 * Enable Display DMA
+	 * Make sure the Copper has something to do
 	 */
-
-	custom.dmacon = DMAF_SETCLR | DMAF_MASTER | DMAF_RASTER | DMAF_COPPER |
-			DMAF_BLITTER | DMAF_SPRITE;
+	ami_init_copper();
 
 	/*
-	 * Make sure the Copper has something to do
+	 * Enable Display DMA
 	 */
-
-	ami_init_copper();
+	custom.dmacon = DMAF_SETCLR | DMAF_MASTER | DMAF_RASTER | DMAF_COPPER |
+			DMAF_BLITTER | DMAF_SPRITE;
 
 	if (request_irq(IRQ_AMIGA_COPPER, amifb_interrupt, 0,
 			"fb vertb handler", &currentpar)) {
-- 
1.7.0.4


  parent reply	other threads:[~2011-11-21 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 20:53 [PATCH 1/8] fbdev/amifb: Correct whitespace Geert Uytterhoeven
2011-11-21 20:53 ` [PATCH 2/8] fbdev/amifb: Fix double free Geert Uytterhoeven
2011-11-21 20:53 ` [PATCH 3/8] fbdev/amifb: Reorder functions to remove forward declarations Geert Uytterhoeven
2011-11-21 20:53 ` [PATCH 4/8] fbdev/amifb: Make amifb_setup() static Geert Uytterhoeven
2011-11-21 20:53 ` [PATCH 5/8] fbdev/amifb: Remove superfluous casts when assigning void * Geert Uytterhoeven
2011-11-21 20:53 ` [PATCH 6/8] fbdev/amifb: Store monitor limits in separate __initdata variables Geert Uytterhoeven
2011-11-21 20:53 ` Geert Uytterhoeven [this message]
2011-11-21 20:53 ` [PATCH 8/8] fbdev/amifb: Use framebuffer_alloc() Geert Uytterhoeven
2011-12-04  0:35 ` [PATCH 1/8] fbdev/amifb: Correct whitespace Florian Tobias Schandinat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321908839-11419-7-git-send-email-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=FlorianSchandinat@gmx.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).