* [PATCH 1/2] video: omap: Staticise non-exported symbols
@ 2011-12-09 1:37 Axel Lin
2011-12-09 8:23 ` Marek Vasut
2011-12-12 10:45 ` Tomi Valkeinen
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2011-12-09 1:37 UTC (permalink / raw)
To: linux-kernel
Cc: Jonathan McDowell, Imre Deak, Cory Maccarrone, Laurent Gonzalez,
Marek Vasut, Tomi Valkeinen, Florian Tobias Schandinat,
linux-fbdev, linux-omap
These symbols are not used outside it's driver so no need to
make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/omap/lcd_ams_delta.c | 2 +-
drivers/video/omap/lcd_h3.c | 2 +-
drivers/video/omap/lcd_htcherald.c | 2 +-
drivers/video/omap/lcd_inn1510.c | 2 +-
drivers/video/omap/lcd_inn1610.c | 2 +-
drivers/video/omap/lcd_osk.c | 2 +-
drivers/video/omap/lcd_palmte.c | 2 +-
drivers/video/omap/lcd_palmtt.c | 2 +-
drivers/video/omap/lcd_palmz71.c | 2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/video/omap/lcd_ams_delta.c b/drivers/video/omap/lcd_ams_delta.c
index 6978ae4..eb50a95 100644
--- a/drivers/video/omap/lcd_ams_delta.c
+++ b/drivers/video/omap/lcd_ams_delta.c
@@ -198,7 +198,7 @@ static int ams_delta_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver ams_delta_panel_driver = {
+static struct platform_driver ams_delta_panel_driver = {
.probe = ams_delta_panel_probe,
.remove = ams_delta_panel_remove,
.suspend = ams_delta_panel_suspend,
diff --git a/drivers/video/omap/lcd_h3.c b/drivers/video/omap/lcd_h3.c
index 622ad83..baec34e 100644
--- a/drivers/video/omap/lcd_h3.c
+++ b/drivers/video/omap/lcd_h3.c
@@ -113,7 +113,7 @@ static int h3_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver h3_panel_driver = {
+static struct platform_driver h3_panel_driver = {
.probe = h3_panel_probe,
.remove = h3_panel_remove,
.suspend = h3_panel_suspend,
diff --git a/drivers/video/omap/lcd_htcherald.c b/drivers/video/omap/lcd_htcherald.c
index 4802419..b1a022f 100644
--- a/drivers/video/omap/lcd_htcherald.c
+++ b/drivers/video/omap/lcd_htcherald.c
@@ -104,7 +104,7 @@ static int htcherald_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver htcherald_panel_driver = {
+static struct platform_driver htcherald_panel_driver = {
.probe = htcherald_panel_probe,
.remove = htcherald_panel_remove,
.suspend = htcherald_panel_suspend,
diff --git a/drivers/video/omap/lcd_inn1510.c b/drivers/video/omap/lcd_inn1510.c
index 3271f16..d129946 100644
--- a/drivers/video/omap/lcd_inn1510.c
+++ b/drivers/video/omap/lcd_inn1510.c
@@ -98,7 +98,7 @@ static int innovator1510_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver innovator1510_panel_driver = {
+static struct platform_driver innovator1510_panel_driver = {
.probe = innovator1510_panel_probe,
.remove = innovator1510_panel_remove,
.suspend = innovator1510_panel_suspend,
diff --git a/drivers/video/omap/lcd_inn1610.c b/drivers/video/omap/lcd_inn1610.c
index 12cc52a..a95756b 100644
--- a/drivers/video/omap/lcd_inn1610.c
+++ b/drivers/video/omap/lcd_inn1610.c
@@ -122,7 +122,7 @@ static int innovator1610_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver innovator1610_panel_driver = {
+static struct platform_driver innovator1610_panel_driver = {
.probe = innovator1610_panel_probe,
.remove = innovator1610_panel_remove,
.suspend = innovator1610_panel_suspend,
diff --git a/drivers/video/omap/lcd_osk.c b/drivers/video/omap/lcd_osk.c
index 6f8d13c..b985997 100644
--- a/drivers/video/omap/lcd_osk.c
+++ b/drivers/video/omap/lcd_osk.c
@@ -116,7 +116,7 @@ static int osk_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver osk_panel_driver = {
+static struct platform_driver osk_panel_driver = {
.probe = osk_panel_probe,
.remove = osk_panel_remove,
.suspend = osk_panel_suspend,
diff --git a/drivers/video/omap/lcd_palmte.c b/drivers/video/omap/lcd_palmte.c
index 4cb3017..d79f436 100644
--- a/drivers/video/omap/lcd_palmte.c
+++ b/drivers/video/omap/lcd_palmte.c
@@ -97,7 +97,7 @@ static int palmte_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver palmte_panel_driver = {
+static struct platform_driver palmte_panel_driver = {
.probe = palmte_panel_probe,
.remove = palmte_panel_remove,
.suspend = palmte_panel_suspend,
diff --git a/drivers/video/omap/lcd_palmtt.c b/drivers/video/omap/lcd_palmtt.c
index b51b332..c2e96a7 100644
--- a/drivers/video/omap/lcd_palmtt.c
+++ b/drivers/video/omap/lcd_palmtt.c
@@ -102,7 +102,7 @@ static int palmtt_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver palmtt_panel_driver = {
+static struct platform_driver palmtt_panel_driver = {
.probe = palmtt_panel_probe,
.remove = palmtt_panel_remove,
.suspend = palmtt_panel_suspend,
diff --git a/drivers/video/omap/lcd_palmz71.c b/drivers/video/omap/lcd_palmz71.c
index 2334e56..1ab4847 100644
--- a/drivers/video/omap/lcd_palmz71.c
+++ b/drivers/video/omap/lcd_palmz71.c
@@ -98,7 +98,7 @@ static int palmz71_panel_resume(struct platform_device *pdev)
return 0;
}
-struct platform_driver palmz71_panel_driver = {
+static struct platform_driver palmz71_panel_driver = {
.probe = palmz71_panel_probe,
.remove = palmz71_panel_remove,
.suspend = palmz71_panel_suspend,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] video: omap: Staticise non-exported symbols
2011-12-09 1:37 [PATCH 1/2] video: omap: Staticise non-exported symbols Axel Lin
@ 2011-12-09 8:23 ` Marek Vasut
2011-12-09 21:59 ` Jonathan McDowell
2011-12-12 10:45 ` Tomi Valkeinen
1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2011-12-09 8:23 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jonathan McDowell, Imre Deak, Cory Maccarrone,
Laurent Gonzalez, Tomi Valkeinen, Florian Tobias Schandinat,
linux-fbdev, linux-omap
> These symbols are not used outside it's driver so no need to
> make the symbol global.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/omap/lcd_ams_delta.c | 2 +-
> drivers/video/omap/lcd_h3.c | 2 +-
> drivers/video/omap/lcd_htcherald.c | 2 +-
> drivers/video/omap/lcd_inn1510.c | 2 +-
> drivers/video/omap/lcd_inn1610.c | 2 +-
> drivers/video/omap/lcd_osk.c | 2 +-
> drivers/video/omap/lcd_palmte.c | 2 +-
> drivers/video/omap/lcd_palmtt.c | 2 +-
> drivers/video/omap/lcd_palmz71.c | 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/video/omap/lcd_ams_delta.c
> b/drivers/video/omap/lcd_ams_delta.c index 6978ae4..eb50a95 100644
> --- a/drivers/video/omap/lcd_ams_delta.c
> +++ b/drivers/video/omap/lcd_ams_delta.c
> @@ -198,7 +198,7 @@ static int ams_delta_panel_resume(struct
> platform_device *pdev) return 0;
> }
>
> -struct platform_driver ams_delta_panel_driver = {
> +static struct platform_driver ams_delta_panel_driver = {
> .probe = ams_delta_panel_probe,
> .remove = ams_delta_panel_remove,
> .suspend = ams_delta_panel_suspend,
> diff --git a/drivers/video/omap/lcd_h3.c b/drivers/video/omap/lcd_h3.c
> index 622ad83..baec34e 100644
> --- a/drivers/video/omap/lcd_h3.c
> +++ b/drivers/video/omap/lcd_h3.c
> @@ -113,7 +113,7 @@ static int h3_panel_resume(struct platform_device
> *pdev) return 0;
> }
>
> -struct platform_driver h3_panel_driver = {
> +static struct platform_driver h3_panel_driver = {
> .probe = h3_panel_probe,
> .remove = h3_panel_remove,
> .suspend = h3_panel_suspend,
> diff --git a/drivers/video/omap/lcd_htcherald.c
> b/drivers/video/omap/lcd_htcherald.c index 4802419..b1a022f 100644
> --- a/drivers/video/omap/lcd_htcherald.c
> +++ b/drivers/video/omap/lcd_htcherald.c
> @@ -104,7 +104,7 @@ static int htcherald_panel_resume(struct
> platform_device *pdev) return 0;
> }
>
> -struct platform_driver htcherald_panel_driver = {
> +static struct platform_driver htcherald_panel_driver = {
> .probe = htcherald_panel_probe,
> .remove = htcherald_panel_remove,
> .suspend = htcherald_panel_suspend,
> diff --git a/drivers/video/omap/lcd_inn1510.c
> b/drivers/video/omap/lcd_inn1510.c index 3271f16..d129946 100644
> --- a/drivers/video/omap/lcd_inn1510.c
> +++ b/drivers/video/omap/lcd_inn1510.c
> @@ -98,7 +98,7 @@ static int innovator1510_panel_resume(struct
> platform_device *pdev) return 0;
> }
>
> -struct platform_driver innovator1510_panel_driver = {
> +static struct platform_driver innovator1510_panel_driver = {
> .probe = innovator1510_panel_probe,
> .remove = innovator1510_panel_remove,
> .suspend = innovator1510_panel_suspend,
> diff --git a/drivers/video/omap/lcd_inn1610.c
> b/drivers/video/omap/lcd_inn1610.c index 12cc52a..a95756b 100644
> --- a/drivers/video/omap/lcd_inn1610.c
> +++ b/drivers/video/omap/lcd_inn1610.c
> @@ -122,7 +122,7 @@ static int innovator1610_panel_resume(struct
> platform_device *pdev) return 0;
> }
>
> -struct platform_driver innovator1610_panel_driver = {
> +static struct platform_driver innovator1610_panel_driver = {
> .probe = innovator1610_panel_probe,
> .remove = innovator1610_panel_remove,
> .suspend = innovator1610_panel_suspend,
> diff --git a/drivers/video/omap/lcd_osk.c b/drivers/video/omap/lcd_osk.c
> index 6f8d13c..b985997 100644
> --- a/drivers/video/omap/lcd_osk.c
> +++ b/drivers/video/omap/lcd_osk.c
> @@ -116,7 +116,7 @@ static int osk_panel_resume(struct platform_device
> *pdev) return 0;
> }
>
> -struct platform_driver osk_panel_driver = {
> +static struct platform_driver osk_panel_driver = {
> .probe = osk_panel_probe,
> .remove = osk_panel_remove,
> .suspend = osk_panel_suspend,
> diff --git a/drivers/video/omap/lcd_palmte.c
> b/drivers/video/omap/lcd_palmte.c index 4cb3017..d79f436 100644
> --- a/drivers/video/omap/lcd_palmte.c
> +++ b/drivers/video/omap/lcd_palmte.c
> @@ -97,7 +97,7 @@ static int palmte_panel_resume(struct platform_device
> *pdev) return 0;
> }
>
> -struct platform_driver palmte_panel_driver = {
> +static struct platform_driver palmte_panel_driver = {
> .probe = palmte_panel_probe,
> .remove = palmte_panel_remove,
> .suspend = palmte_panel_suspend,
> diff --git a/drivers/video/omap/lcd_palmtt.c
> b/drivers/video/omap/lcd_palmtt.c index b51b332..c2e96a7 100644
> --- a/drivers/video/omap/lcd_palmtt.c
> +++ b/drivers/video/omap/lcd_palmtt.c
> @@ -102,7 +102,7 @@ static int palmtt_panel_resume(struct platform_device
> *pdev) return 0;
> }
>
> -struct platform_driver palmtt_panel_driver = {
> +static struct platform_driver palmtt_panel_driver = {
> .probe = palmtt_panel_probe,
> .remove = palmtt_panel_remove,
> .suspend = palmtt_panel_suspend,
> diff --git a/drivers/video/omap/lcd_palmz71.c
> b/drivers/video/omap/lcd_palmz71.c index 2334e56..1ab4847 100644
> --- a/drivers/video/omap/lcd_palmz71.c
> +++ b/drivers/video/omap/lcd_palmz71.c
> @@ -98,7 +98,7 @@ static int palmz71_panel_resume(struct platform_device
> *pdev) return 0;
> }
>
> -struct platform_driver palmz71_panel_driver = {
> +static struct platform_driver palmz71_panel_driver = {
> .probe = palmz71_panel_probe,
> .remove = palmz71_panel_remove,
> .suspend = palmz71_panel_suspend,
I can speak for palmtt and palmz71,
Acked-by: Marek Vasut <marek.vasut@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] video: omap: Staticise non-exported symbols
2011-12-09 8:23 ` Marek Vasut
@ 2011-12-09 21:59 ` Jonathan McDowell
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan McDowell @ 2011-12-09 21:59 UTC (permalink / raw)
To: Marek Vasut
Cc: Axel Lin, linux-kernel, Imre Deak, Cory Maccarrone,
Laurent Gonzalez, Tomi Valkeinen, Florian Tobias Schandinat,
linux-fbdev, linux-omap
On Fri, Dec 09, 2011 at 09:23:46AM +0100, Marek Vasut wrote:
> > These symbols are not used outside it's driver so no need to
> > make the symbol global.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > ---
> > drivers/video/omap/lcd_ams_delta.c | 2 +-
> > drivers/video/omap/lcd_h3.c | 2 +-
> > drivers/video/omap/lcd_htcherald.c | 2 +-
> > drivers/video/omap/lcd_inn1510.c | 2 +-
> > drivers/video/omap/lcd_inn1610.c | 2 +-
> > drivers/video/omap/lcd_osk.c | 2 +-
> > drivers/video/omap/lcd_palmte.c | 2 +-
> > drivers/video/omap/lcd_palmtt.c | 2 +-
> > drivers/video/omap/lcd_palmz71.c | 2 +-
> > 9 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/video/omap/lcd_ams_delta.c
> > b/drivers/video/omap/lcd_ams_delta.c index 6978ae4..eb50a95 100644
> > --- a/drivers/video/omap/lcd_ams_delta.c
> > +++ b/drivers/video/omap/lcd_ams_delta.c
> > @@ -198,7 +198,7 @@ static int ams_delta_panel_resume(struct
> > platform_device *pdev) return 0;
> > }
> >
> > -struct platform_driver ams_delta_panel_driver = {
> > +static struct platform_driver ams_delta_panel_driver = {
> > .probe = ams_delta_panel_probe,
> > .remove = ams_delta_panel_remove,
> > .suspend = ams_delta_panel_suspend,
> > diff --git a/drivers/video/omap/lcd_h3.c b/drivers/video/omap/lcd_h3.c
> > index 622ad83..baec34e 100644
> > --- a/drivers/video/omap/lcd_h3.c
> > +++ b/drivers/video/omap/lcd_h3.c
> > @@ -113,7 +113,7 @@ static int h3_panel_resume(struct platform_device
> > *pdev) return 0;
> > }
> >
> > -struct platform_driver h3_panel_driver = {
> > +static struct platform_driver h3_panel_driver = {
> > .probe = h3_panel_probe,
> > .remove = h3_panel_remove,
> > .suspend = h3_panel_suspend,
> > diff --git a/drivers/video/omap/lcd_htcherald.c
> > b/drivers/video/omap/lcd_htcherald.c index 4802419..b1a022f 100644
> > --- a/drivers/video/omap/lcd_htcherald.c
> > +++ b/drivers/video/omap/lcd_htcherald.c
> > @@ -104,7 +104,7 @@ static int htcherald_panel_resume(struct
> > platform_device *pdev) return 0;
> > }
> >
> > -struct platform_driver htcherald_panel_driver = {
> > +static struct platform_driver htcherald_panel_driver = {
> > .probe = htcherald_panel_probe,
> > .remove = htcherald_panel_remove,
> > .suspend = htcherald_panel_suspend,
> > diff --git a/drivers/video/omap/lcd_inn1510.c
> > b/drivers/video/omap/lcd_inn1510.c index 3271f16..d129946 100644
> > --- a/drivers/video/omap/lcd_inn1510.c
> > +++ b/drivers/video/omap/lcd_inn1510.c
> > @@ -98,7 +98,7 @@ static int innovator1510_panel_resume(struct
> > platform_device *pdev) return 0;
> > }
> >
> > -struct platform_driver innovator1510_panel_driver = {
> > +static struct platform_driver innovator1510_panel_driver = {
> > .probe = innovator1510_panel_probe,
> > .remove = innovator1510_panel_remove,
> > .suspend = innovator1510_panel_suspend,
> > diff --git a/drivers/video/omap/lcd_inn1610.c
> > b/drivers/video/omap/lcd_inn1610.c index 12cc52a..a95756b 100644
> > --- a/drivers/video/omap/lcd_inn1610.c
> > +++ b/drivers/video/omap/lcd_inn1610.c
> > @@ -122,7 +122,7 @@ static int innovator1610_panel_resume(struct
> > platform_device *pdev) return 0;
> > }
> >
> > -struct platform_driver innovator1610_panel_driver = {
> > +static struct platform_driver innovator1610_panel_driver = {
> > .probe = innovator1610_panel_probe,
> > .remove = innovator1610_panel_remove,
> > .suspend = innovator1610_panel_suspend,
> > diff --git a/drivers/video/omap/lcd_osk.c b/drivers/video/omap/lcd_osk.c
> > index 6f8d13c..b985997 100644
> > --- a/drivers/video/omap/lcd_osk.c
> > +++ b/drivers/video/omap/lcd_osk.c
> > @@ -116,7 +116,7 @@ static int osk_panel_resume(struct platform_device
> > *pdev) return 0;
> > }
> >
> > -struct platform_driver osk_panel_driver = {
> > +static struct platform_driver osk_panel_driver = {
> > .probe = osk_panel_probe,
> > .remove = osk_panel_remove,
> > .suspend = osk_panel_suspend,
> > diff --git a/drivers/video/omap/lcd_palmte.c
> > b/drivers/video/omap/lcd_palmte.c index 4cb3017..d79f436 100644
> > --- a/drivers/video/omap/lcd_palmte.c
> > +++ b/drivers/video/omap/lcd_palmte.c
> > @@ -97,7 +97,7 @@ static int palmte_panel_resume(struct platform_device
> > *pdev) return 0;
> > }
> >
> > -struct platform_driver palmte_panel_driver = {
> > +static struct platform_driver palmte_panel_driver = {
> > .probe = palmte_panel_probe,
> > .remove = palmte_panel_remove,
> > .suspend = palmte_panel_suspend,
> > diff --git a/drivers/video/omap/lcd_palmtt.c
> > b/drivers/video/omap/lcd_palmtt.c index b51b332..c2e96a7 100644
> > --- a/drivers/video/omap/lcd_palmtt.c
> > +++ b/drivers/video/omap/lcd_palmtt.c
> > @@ -102,7 +102,7 @@ static int palmtt_panel_resume(struct platform_device
> > *pdev) return 0;
> > }
> >
> > -struct platform_driver palmtt_panel_driver = {
> > +static struct platform_driver palmtt_panel_driver = {
> > .probe = palmtt_panel_probe,
> > .remove = palmtt_panel_remove,
> > .suspend = palmtt_panel_suspend,
> > diff --git a/drivers/video/omap/lcd_palmz71.c
> > b/drivers/video/omap/lcd_palmz71.c index 2334e56..1ab4847 100644
> > --- a/drivers/video/omap/lcd_palmz71.c
> > +++ b/drivers/video/omap/lcd_palmz71.c
> > @@ -98,7 +98,7 @@ static int palmz71_panel_resume(struct platform_device
> > *pdev) return 0;
> > }
> >
> > -struct platform_driver palmz71_panel_driver = {
> > +static struct platform_driver palmz71_panel_driver = {
> > .probe = palmz71_panel_probe,
> > .remove = palmz71_panel_remove,
> > .suspend = palmz71_panel_suspend,
>
> I can speak for palmtt and palmz71,
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
Likewise, for ams-delta,
Acked-By: Jonathan McDowell <noodles@earth.li>
J.
--
Generally, all generalizations are false..
This .sig brought to you by the letter Z and the number 26
Product of the Republic of HuggieTag
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] video: omap: Staticise non-exported symbols
2011-12-09 1:37 [PATCH 1/2] video: omap: Staticise non-exported symbols Axel Lin
2011-12-09 8:23 ` Marek Vasut
@ 2011-12-12 10:45 ` Tomi Valkeinen
1 sibling, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2011-12-12 10:45 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jonathan McDowell, Imre Deak, Cory Maccarrone,
Laurent Gonzalez, Marek Vasut, Florian Tobias Schandinat,
linux-fbdev, linux-omap
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
On Fri, 2011-12-09 at 09:37 +0800, Axel Lin wrote:
> These symbols are not used outside it's driver so no need to
> make the symbol global.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Thanks, applied to DSS tree.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-12 10:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-09 1:37 [PATCH 1/2] video: omap: Staticise non-exported symbols Axel Lin
2011-12-09 8:23 ` Marek Vasut
2011-12-09 21:59 ` Jonathan McDowell
2011-12-12 10:45 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).