From: Marek Vasut <marek.vasut@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org, FlorianSchandinat@gmx.de,
Marek Vasut <marek.vasut@gmail.com>, Wolfgang Denk <wd@denx.de>,
Stefano Babic <sbabic@denx.de>, Shawn Guo <shawn.guo@linaro.org>,
Huang Shijie <b32955@freescale.com>,
Axel Lin <axel.lin@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH RESEND] MXSFB: Fix driver registration
Date: Mon, 19 Dec 2011 15:37:59 +0000 [thread overview]
Message-ID: <1324309079-10739-1-git-send-email-marek.vasut@gmail.com> (raw)
The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
This caused obvious null pointer dereference and crash.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Huang Shijie <b32955@freescale.com>
Cc: Axel Lin <axel.lin@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/video/mxsfb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 18742c2..d29c7c0 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
},
};
-module_platform_driver(mxsfb_devtype);
+module_platform_driver(mxsfb_driver);
MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
MODULE_AUTHOR("Sascha Hauer, Pengutronix");
--
1.7.6.4
next reply other threads:[~2011-12-19 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 15:37 Marek Vasut [this message]
2011-12-19 22:54 ` [PATCH RESEND] MXSFB: Fix driver registration Shawn Guo
2011-12-21 21:42 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324309079-10739-1-git-send-email-marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=FlorianSchandinat@gmx.de \
--cc=axel.lin@gmail.com \
--cc=b32955@freescale.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sbabic@denx.de \
--cc=shawn.guo@linaro.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).