From: Anatolij Gustschin <agust@denx.de>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH 1/2] fbdev: da8xx:: fix reporting of the display timing info
Date: Fri, 09 Mar 2012 15:02:15 +0000 [thread overview]
Message-ID: <1331305336-32644-2-git-send-email-agust@denx.de> (raw)
Timing info is not properly reported by the driver, e.g.:
$ fbset -i
mode "480x272-95"
# D: 21.429 MHz, H: 33.018 kHz, V: 95.429 Hz
geometry 480 272 480 544 16
timings 46666 64 64 32 32 41 10
According to the timing values defined for LK043T1DG01 display
it should be reported as:
mode "480x272-52"
# D: 7.834 MHz, H: 14.921 kHz, V: 51.810 Hz
geometry 480 272 480 544 16
timings 127655 2 2 2 2 41 10
Initialize additional fb_var_screeninfo fields so fix this problem.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Manjunathappa, Prakash <prakash.pm@ti.com>
---
drivers/video/da8xx-fb.c | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 29577bf..27c2794 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -240,6 +240,14 @@ static struct da8xx_panel known_lcd_panels[] = {
},
};
+static inline unsigned long hz_to_ps(unsigned long hz_val)
+{
+ unsigned long long num = 1000000000000ULL;
+
+ do_div(num, hz_val);
+ return (unsigned long)num;
+}
+
/* Enable the Raster Engine of the LCD Controller */
static inline void lcd_enable_raster(void)
{
@@ -1209,6 +1217,11 @@ static int __devinit fb_probe(struct platform_device *device)
da8xx_fb_var.hsync_len = lcdc_info->hsw;
da8xx_fb_var.vsync_len = lcdc_info->vsw;
+ da8xx_fb_var.right_margin = lcdc_info->hfp;
+ da8xx_fb_var.left_margin = lcdc_info->hbp;
+ da8xx_fb_var.lower_margin = lcdc_info->vfp;
+ da8xx_fb_var.upper_margin = lcdc_info->vbp;
+ da8xx_fb_var.pixclock = hz_to_ps(lcdc_info->pxl_clk);
/* Initialize fbinfo */
da8xx_fb_info->flags = FBINFO_FLAG_DEFAULT;
--
1.7.7.6
next reply other threads:[~2012-03-09 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 15:02 Anatolij Gustschin [this message]
2012-03-12 5:19 ` [PATCH 1/2] fbdev: da8xx:: fix reporting of the display timing info Manjunathappa, Prakash
2012-03-13 9:42 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331305336-32644-2-git-send-email-agust@denx.de \
--to=agust@denx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).