From: Joe Perches <joe@perches.com>
To: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>
Cc: rpurdie@rpsys.net, FlorianSchandinat@gmx.de,
akpm@linux-foundation.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added backlight driver for Acer Aspire 4736
Date: Mon, 12 Mar 2012 23:07:56 +0000 [thread overview]
Message-ID: <1331593676.13200.37.camel@joe2Laptop> (raw)
In-Reply-To: <1331608337.2267.67.camel@debian.Gayathri>
On Mon, 2012-03-12 at 23:12 -0400, Pradeep Subrahmanion wrote:
> Hi ,
Hello yourself.
Just some trivial comments:
> diff --git a/drivers/video/backlight/acer4736_bl.c b/drivers/video/backlight/acer4736_bl.c
[]
Please add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any include
> +static int update_brightness(struct backlight_device *bd)
> +{
> + u8 intensity = bd->props.brightness;
> + if (intensity > max_brightness) {
> + printk(KERN_INFO "Acer4736_bl: Invalid parameter. Maximum value is %d"
> + , max_brightness);
Beginning a line with a comma is not at all common and
should be avoided. printks need newline terminations,
and this would be better as pr_info. Maybe:
pr_info("Invalid parameter %u: Maximum allowed value: %u\n",
intensity, max_brightness);
> + printk(KERN_INFO "Loading Acer 4736 backlight driver\n");
pr_info("Loading backlight driver\n");
next prev parent reply other threads:[~2012-03-12 23:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABNxG=CU+bOWUauLYfcS2vtFqKvXA-9axgokNoYz+KuU1Mzztw@mail.gmail.com>
2012-03-11 19:42 ` [PATCH] Added backlight driver for Acer Aspire 4736 Florian Tobias Schandinat
2012-03-12 17:36 ` Pradeep Subrahmanion
2012-03-12 17:51 ` Matthew Garrett
[not found] ` <1331640592.3485.50.camel@debian.Gayathri>
2012-03-13 12:47 ` Matthew Garrett
[not found] ` <CABNxG=Dqg26EHmC3vibf3-SjVhby1qgQfMniQObUeh9eJ6SwEw@mail.gmail.com>
2012-03-13 13:34 ` Matthew Garrett
2012-03-13 15:49 ` Pradeep Subrahmanion
2012-03-13 23:12 ` joeyli
2012-03-14 2:55 ` Pradeep Subrahmanion
2012-03-14 5:51 ` joeyli
2012-03-14 6:29 ` Pradeep Subrahmanion
2012-03-15 8:05 ` joeyli
2012-03-18 5:22 ` Pradeep Subrahmanion
2012-03-19 2:01 ` joeyli
2012-03-19 11:45 ` Pradeep Subrahmanion
2012-03-20 3:55 ` joeyli
2012-03-20 11:09 ` joeyli
2012-03-20 18:55 ` Pradeep Subrahmanion
2012-03-21 3:00 ` joeyli
2012-03-21 19:21 ` Pradeep Subrahmanion
2012-03-22 1:33 ` joeyli
2012-03-22 2:45 ` Pradeep Subrahmanion
2012-03-22 3:25 ` joeyli
2012-03-22 3:44 ` Pradeep Subrahmanion
2012-03-22 3:54 ` joeyli
2012-03-22 5:57 ` Pradeep Subrahmanion
2012-03-22 9:34 ` joeyli
2012-03-22 16:29 ` Pradeep Subrahmanion
2012-03-23 3:48 ` Pradeep Subrahmanion
2012-03-23 4:25 ` joeyli
2012-03-18 5:24 ` Pradeep Subrahmanion
2012-03-13 13:41 ` Pradeep Subrahmanion
2012-03-12 23:07 ` Joe Perches [this message]
2012-03-12 17:40 ` Pradeep Subrahmanion
2012-03-13 3:10 ` joeyli
[not found] ` <1331644360.3319.6.camel@debian.Gayathri>
2012-03-13 4:35 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331593676.13200.37.camel@joe2Laptop \
--to=joe@perches.com \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=subrahmanion.pradeep@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).