Re: [PATCH] Added backlight driver for Acer Aspire 4736

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Florian Tobias Schandinat]

Hi,

On 03/11/2012 06:21 PM, Pradeep Subrahmanion wrote:
> Hi ,
> 
>          Brightness control was not  working on Acer Aspire 4736 using
> default ACPI interface.  acer-acpi also do not support 4730 series since
> it uses new WMI interface.
> This driver adds brightness control by accessing the LBB PCI
> configuration register. This approach may also work on other laptops in
> 4730 series .But currently ,  it is only tested  for 
> Aspire 4736.  
> 
> From 893031c1e9bdefd9642b98825062b5df98af0d77 Mon Sep 17 00:00:00 2001
> From: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> <mailto:subrahmanion.pradeep@gmail.com>>
> Date: Sun, 11 Mar 2012 23:11:23 -0400
> Subject: [PATCH] Added backlight driver for Acer Aspire 4736
> 

the commit message should be here, I think.

> 
> Signed-off-by: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> <mailto:subrahmanion.pradeep@gmail.com>>

Please resend this email in the correct format: As you can see in my
email the text version of your patch is severely screwed up and nobody
wants to even try converting a HTML format to a proper patch again,
probably most people won't even receive an email that has a HTML part as
their spam filter are going to handle it as spam. git send-email will
take care of it for you if you configure it for your account.
You should also cc Andrew Morton <akpm@linux-foundation.org> as he's the
one who handles backlight patches at the moment.


Best regards,

Florian Tobias Schandinat

> ---
>  drivers/video/backlight/acer4736_bl.c |  110
> +++++++++++++++++++++++++++++++++
>  1 files changed, 110 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/video/backlight/acer4736_bl.c
> 
> diff --git a/drivers/video/backlight/acer4736_bl.c
> b/drivers/video/backlight/acer4736_bl.c
> new file mode 100644
> index 0000000..6fe2937
> --- /dev/null
> +++ b/drivers/video/backlight/acer4736_bl.c
> @@ -0,0 +1,110 @@
> +/*
> + * Backlight driver for Acer Aspire 4736
> + *
> + * Copyright (C) Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> <mailto:subrahmanion.pradeep@gmail.com>>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This driver uses LBB PCI configuration register to change the
> + * backlight brightness.
> + *
> + */
> +
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +#include <linux/backlight.h>
> +#include <linux/err.h>
> +#include <linux/dmi.h>
> +#include <linux/io.h>
> +#include <linux/pci.h>
> +
> +static u8 max_brightness = 0xFF;
> +static u8 lbb_offset =  0xF4;
> +static unsigned int device_id = 0x2a42;
> +static unsigned int vendor_id = 0x8086;
> +
> +struct backlight_device *acer_backlight_device;
> +struct pci_dev *pdev;
> +
> +static int acer_dmi_match(const struct dmi_system_id *id)
> +{
> + printk(KERN_INFO "acer4736_bl: %s detected\n", id->ident);
> + return 1;
> +}
> +
> +static const struct dmi_system_id __initdata acer_device_table[] = {
> +{
> + .callback = acer_dmi_match,
> + .ident = "Aspire 4736",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
> + },
> + },
> + {}
> +};
> +static int read_brightness(struct backlight_device *bd)
> +{
> + u8 result;
> + pci_read_config_byte(pdev, lbb_offset, &result);
> + return result;
> +}
> +
> +static int update_brightness(struct backlight_device *bd)
> +{
> + u8 intensity = bd->props.brightness;
> + if (intensity > max_brightness) {
> + printk(KERN_INFO "Acer4736_bl: Invalid parameter. Maximum value is %d"
> + , max_brightness);
> + return -1;
> + }
> + pci_write_config_byte(pdev, lbb_offset, intensity);
> + return 0;
> +}
> +static const struct  backlight_ops acer_backlight_ops = {
> + .get_brightness = read_brightness,
> + .update_status  = update_brightness,
> +};
> +
> +static int __init acer4736_bl_init(void)
> +{
> + struct backlight_properties props;
> + if (!dmi_check_system(acer_device_table))
> + return -ENODEV;
> +
> + pdev = pci_get_device(vendor_id, device_id, NULL);
> +
> + if (!pdev)
> + return -ENODEV;
> +
> + printk(KERN_INFO "Loading Acer 4736 backlight driver\n");
> + memset(&props, 0, sizeof(struct backlight_properties));
> + props.type = BACKLIGHT_RAW;
> + props.max_brightness = max_brightness;
> +
> + acer_backlight_device = backlight_device_register("acer_backlight",
> + NULL, NULL, &acer_backlight_ops, &props);
> + acer_backlight_device->props.max_brightness = max_brightness;
> + acer_backlight_device->props.brightness  > + read_brightness(acer_backlight_device);
> + backlight_update_status(acer_backlight_device);
> +
> + return 0;
> +}
> +
> +static void __exit acer4736_bl_exit(void)
> +{
> + pci_dev_put(pdev);
> + backlight_device_unregister(acer_backlight_device);
> +}
> +
> +module_init(acer4736_bl_init);
> +module_exit(acer4736_bl_exit);
> +
> +MODULE_AUTHOR("Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> <mailto:subrahmanion.pradeep@gmail.com>>");
> +MODULE_DESCRIPTION("Acer Aspire 4736 Backlight Driver");
> +MODULE_LICENSE("GPL");
> +MODULE_DEVICE_TABLE(dmi, acer_device_table);
> -- 
> 1.7.2.5
> 
> -------------  
> 
> Pradeep Subrahmanion

[PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

Hi ,

  Brightness control was not  working on Acer Aspire 4736 using default ACPI interface.  acer-acpi also do not support 4730 series since it uses new WMI interface.
This driver adds brightness control by accessing the LBB PCI configuration register. This approach may also work on other laptops in 4730 series .But currently ,  it is only tested  for 
Aspire 4736. 

From 03dbda16c90278aa1c088e5208bd99ac3c76f911 Mon Sep 17 00:00:00 2001
From: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>
Date: Mon, 12 Mar 2012 23:08:20 -0400
Subject: [PATCH] Added backlight driver for Acer Aspire 4736

Added backlight driver for Acer Aspire 4736

Signed-off-by: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>
---
 drivers/video/backlight/acer4736_bl.c |  110 +++++++++++++++++++++++++++++++++
 1 files changed, 110 insertions(+), 0 deletions(-)
 create mode 100644 drivers/video/backlight/acer4736_bl.c

diff --git a/drivers/video/backlight/acer4736_bl.c b/drivers/video/backlight/acer4736_bl.c
new file mode 100644
index 0000000..6fe2937
--- /dev/null
+++ b/drivers/video/backlight/acer4736_bl.c
@@ -0,0 +1,110 @@
+/*
+ * Backlight driver for Acer Aspire 4736
+ *
+ * Copyright (C) Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This driver uses LBB PCI configuration register to change the
+ * backlight brightness.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/backlight.h>
+#include <linux/err.h>
+#include <linux/dmi.h>
+#include <linux/io.h>
+#include <linux/pci.h>
+
+static u8 max_brightness = 0xFF;
+static u8 lbb_offset =  0xF4;
+static unsigned int device_id = 0x2a42;
+static unsigned int vendor_id = 0x8086;
+
+struct backlight_device *acer_backlight_device;
+struct pci_dev *pdev;
+
+static int acer_dmi_match(const struct dmi_system_id *id)
+{
+	printk(KERN_INFO "acer4736_bl: %s detected\n", id->ident);
+	return 1;
+}
+
+static const struct dmi_system_id __initdata acer_device_table[] = {
+{
+		.callback	= acer_dmi_match,
+		.ident		= "Aspire 4736",
+		.matches	= {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
+		},
+	},
+	{}
+};
+static int read_brightness(struct backlight_device *bd)
+{
+	u8 result;
+	pci_read_config_byte(pdev, lbb_offset, &result);
+	return result;
+}
+
+static int update_brightness(struct backlight_device *bd)
+{
+	u8 intensity = bd->props.brightness;
+	if (intensity > max_brightness) {
+		printk(KERN_INFO "Acer4736_bl: Invalid parameter. Maximum value is %d"
+		, max_brightness);
+		return -1;
+	}
+	pci_write_config_byte(pdev, lbb_offset, intensity);
+	return 0;
+}
+static const struct  backlight_ops acer_backlight_ops = {
+	.get_brightness = read_brightness,
+	.update_status  = update_brightness,
+};
+
+static int __init acer4736_bl_init(void)
+{
+	struct backlight_properties props;
+	if (!dmi_check_system(acer_device_table))
+		return -ENODEV;
+
+	pdev = pci_get_device(vendor_id, device_id, NULL);
+
+	if (!pdev)
+		return -ENODEV;
+
+	printk(KERN_INFO "Loading Acer 4736 backlight driver\n");
+	memset(&props, 0, sizeof(struct backlight_properties));
+	props.type = BACKLIGHT_RAW;
+	props.max_brightness = max_brightness;
+
+	acer_backlight_device = backlight_device_register("acer_backlight",
+		NULL, NULL, &acer_backlight_ops, &props);
+	acer_backlight_device->props.max_brightness = max_brightness;
+	acer_backlight_device->props.brightness  +		read_brightness(acer_backlight_device);
+	backlight_update_status(acer_backlight_device);
+
+	return 0;
+}
+
+static void __exit acer4736_bl_exit(void)
+{
+	pci_dev_put(pdev);
+	backlight_device_unregister(acer_backlight_device);
+}
+
+module_init(acer4736_bl_init);
+module_exit(acer4736_bl_exit);
+
+MODULE_AUTHOR("Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>");
+MODULE_DESCRIPTION("Acer Aspire 4736 Backlight Driver");
+MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(dmi, acer_device_table);
-- 
1.7.2.5



------

Thanks , 

Pradeep Subrahmanion

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Matthew Garrett]

On Mon, Mar 12, 2012 at 11:12:17PM -0400, Pradeep Subrahmanion wrote:
> Hi ,
> 
>   Brightness control was not  working on Acer Aspire 4736 using default ACPI interface.  acer-acpi also do not support 4730 series since it uses new WMI interface.
> This driver adds brightness control by accessing the LBB PCI configuration register. This approach may also work on other laptops in 4730 series .But currently ,  it is only tested  for 
> Aspire 4736. 

1) If there's a WMI interface to brightness control, why not use that?
2) You're hitting a hardware resource that belongs to the i915 driver, 
which may well cause problems.
3) Why does the ACPI interface not work? Can you attach the acpidump 
output?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Matthew Garrett]

On Tue, Mar 13, 2012 at 08:09:52AM -0400, Pradeep Subrahmanion wrote:
> Before taking this approach , I had a look at the WMI interface.But I found from acer-acpi site that , the 4730 series 
> is using new WMI interface which needs to be reverse engineered.
> As far as  acpi interface is concerned , by default it is not at all causing any change in brightness.
> When 'acpi_osi=Linux' was added to the boot grub config , the brightness control with hot key started to work .
> But it was not changing to correct values. Increasing brightness after maximum level gives blank screen.

That page was last updated in 2009. Have you tried the current acer-wmi 
code? You'd probably need to pass backlight=vendor if there's a 
non-working ACPI interface.

When you say the ACPI interface doesn't work, what do you mean? Have you 
tried using the /sys/class/backlight interface directly?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Matthew Garrett]

On Tue, Mar 13, 2012 at 06:56:16PM +0530, Pradeep Subrahmanion wrote:
> I tried giving acpi_backlight = vendor . In that case hot key for
> brightness control is working. But i think  , it is not calculating the
> correct value for brightness because increasing brightness after maximum
> level gives blank screen .

Which backlight device appears then?

> By ' ACPI interface' , I mean 'acpi_video0' inside the
> /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> directly . I will try that also.

So writing values into /sys/class/backlight/acpi_video0/brightness does 
nothing?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

On Tue, 2012-03-13 at 13:34 +0000, Matthew Garrett wrote:
> On Tue, Mar 13, 2012 at 06:56:16PM +0530, Pradeep Subrahmanion wrote:
> > I tried giving acpi_backlight = vendor . In that case hot key for
> > brightness control is working. But i think  , it is not calculating the
> > correct value for brightness because increasing brightness after maximum
> > level gives blank screen .
> 
> Which backlight device appears then?
> 

'intel_backlight' appears when i gave option acpi_backlight = vendor. Writing to /sys/class/backlight/intel_backlight/brightness

does not cause any change in brightness.

> > By ' ACPI interface' , I mean 'acpi_video0' inside the
> > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> > directly . I will try that also.
> 
> So writing values into /sys/class/backlight/acpi_video0/brightness does 
> nothing?


No change in value when writing
to /sys/class/backlight/acpi_video0/brightness.

Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
in new kernel (3.3.0-rc7) , it shows following messages , 

[    8.350825] wmi: Mapper loaded
[   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
[   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
[   10.396385] acer_wmi: Brightness must be controlled by generic video
driver

Also there was no interface inside /sys/class/backlight for acer_wmi. 

I also tried writing directly to Embedded controller register .But no
change.

----

Thanks , 

Pradeep Subrahmanion
  

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

Hi Pradeep, 

於 二，2012-03-13 於 21:24 -0400，Pradeep Subrahmanion 提到：
> On Tue, 2012-03-13 at 13:34 +0000, Matthew Garrett wrote:
> > On Tue, Mar 13, 2012 at 06:56:16PM +0530, Pradeep Subrahmanion wrote:
> > > I tried giving acpi_backlight = vendor . In that case hot key for
> > > brightness control is working. But i think  , it is not calculating the
> > > correct value for brightness because increasing brightness after maximum
> > > level gives blank screen .
> > 
> > Which backlight device appears then?
> > 
> 
> 'intel_backlight' appears when i gave option acpi_backlight = vendor. Writing to /sys/class/backlight/intel_backlight/brightness
> 
> does not cause any change in brightness.
> 

The above command not work, that means EC didn't change backlight
value:

Method (_BCM, 1, NotSerialized)
{
    Divide (Arg0, 0x0A, Local0, Local1)
    Decrement (Local1)
    Store (Local1, ^^^^LPC.EC0.BRTS)    <== write backlight value to EC
register
}

Per my understood, EC firmware should change brightness but didn't do
that, another
way is touch i915 register in _BCM.

Acer machine provide a broken _BCM implementation and they didn't test
it.

> > > By ' ACPI interface' , I mean 'acpi_video0' inside the
> > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> > > directly . I will try that also.
> > 
> > So writing values into /sys/class/backlight/acpi_video0/brightness does 
> > nothing?
> 
> 
> No change in value when writing
> to /sys/class/backlight/acpi_video0/brightness.
> 
> Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
> in new kernel (3.3.0-rc7) , it shows following messages , 
> 
> [    8.350825] wmi: Mapper loaded
> [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
> [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
> [   10.396385] acer_wmi: Brightness must be controlled by generic video
> driver
> 
> Also there was no interface inside /sys/class/backlight for acer_wmi. 
> 

Yes, acer_wmi support backlight control with AMW0 interface, your
machine didn't have AMW0 interface.

Normally, backlight should control by standard acpi interface.

> I also tried writing directly to Embedded controller register .But no
> change.

The machine has broken _BCM method, because EC should do something after
_BCM changed EC register.

> ----
> 
> Thanks , 
> 
> Pradeep Subrahmanion
>   


Thanks a lot!
Joey Lee

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

Hi Joey , 

> Per my understood, EC firmware should change brightness but didn't do
> that, another
> way is touch i915 register in _BCM.

  how do we do this ? you mean change the _BCM implementation ? 
> 
> Acer machine provide a broken _BCM implementation and they didn't test
> it.
> 
> > > > By ' ACPI interface' , I mean 'acpi_video0' inside the
> > > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> > > > directly . I will try that also.
> > > 
> > > So writing values into /sys/class/backlight/acpi_video0/brightness does 
> > > nothing?
> > 
> > 
> > No change in value when writing
> > to /sys/class/backlight/acpi_video0/brightness.
> > 
> > Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
> > in new kernel (3.3.0-rc7) , it shows following messages , 
> > 
> > [    8.350825] wmi: Mapper loaded
> > [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
> > [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
> > [   10.396385] acer_wmi: Brightness must be controlled by generic video
> > driver
> > 
> > Also there was no interface inside /sys/class/backlight for acer_wmi. 
> > 
> 
> Yes, acer_wmi support backlight control with AMW0 interface, your
> machine didn't have AMW0 interface.
> 
> Normally, backlight should control by standard acpi interface.
> 
> > I also tried writing directly to Embedded controller register .But no
> > change.
> 
> The machine has broken _BCM method, because EC should do something after
> _BCM changed EC register.

Thanks , 

Pradeep Subrahmanion

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

於 三，2012-03-14 於 08:13 +0530，Pradeep Subrahmanion 提到：
> Hi Joey , 
> 
> > Per my understood, EC firmware should change brightness but didn't do
> > that, another
> > way is touch i915 register in _BCM.
> 
>   how do we do this ? you mean change the _BCM implementation ? 

"BIOS guy" should do something like this:

 Method (AINT, 2, NotSerialized)
{
...
        If (LEqual (Arg0, One))
        {
            Store (Divide (Multiply (Arg1, 0xFF), 0x64, ), BCLP)
            Or (BCLP, 0x80000000, BCLP)		<== touch BCLP register
            Store (0x02, ASLC)
        }

    Method (_BCM, 1, NotSerialized)
    {
        If (LAnd (LGreaterEqual (Arg0, Zero), LLessEqual (Arg0, 0x64)))
        {
            AINT (One, Arg0)     <== call AINT method
            Store (Arg0, BRTL)
        }
    }


Just for reference, they should do that when EC didn't wire to
backlight. 

> > 
> > Acer machine provide a broken _BCM implementation and they didn't test
> > it.
> > 
> > > > > By ' ACPI interface' , I mean 'acpi_video0' inside the
> > > > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> > > > > directly . I will try that also.
> > > > 
> > > > So writing values into /sys/class/backlight/acpi_video0/brightness does 
> > > > nothing?
> > > 
> > > 
> > > No change in value when writing
> > > to /sys/class/backlight/acpi_video0/brightness.
> > > 
> > > Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
> > > in new kernel (3.3.0-rc7) , it shows following messages , 
> > > 
> > > [    8.350825] wmi: Mapper loaded
> > > [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
> > > [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
> > > [   10.396385] acer_wmi: Brightness must be controlled by generic video
> > > driver
> > > 
> > > Also there was no interface inside /sys/class/backlight for acer_wmi. 
> > > 
> > 
> > Yes, acer_wmi support backlight control with AMW0 interface, your
> > machine didn't have AMW0 interface.
> > 
> > Normally, backlight should control by standard acpi interface.
> > 
> > > I also tried writing directly to Embedded controller register .But no
> > > change.
> > 
> > The machine has broken _BCM method, because EC should do something after
> > _BCM changed EC register.
> 
> Thanks , 
> 
> Pradeep Subrahmanion

Why they didn't find _BCM not work?

My guess is:

Because the backlight control is through WDDM driver on Windows platform
but not through standard ACPI method _BCM. They only test Windows
platform, so, they didn't find _BCM broken.

And, they also didn't really follow Microsoft WDDM spec:

 http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx

Per spec,
ODM should keep _BCM works fine for any other OS didn't support WDDM
driver, but they didn't.

At last year, I told Acer PM one time for this issue, they said will
check but finally didn't response me.


Thanks
Joey Lee

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

On Wed, Mar 14, 2012 at 11:21 AM, joeyli <jlee@suse.com> wrote:
> 於 三，2012-03-14 於 08:13 +0530，Pradeep Subrahmanion 提到：
>> Hi Joey ,
>>
>> > Per my understood, EC firmware should change brightness but didn't do
>> > that, another
>> > way is touch i915 register in _BCM.
>>
>>   how do we do this ? you mean change the _BCM implementation ?
>
> "BIOS guy" should do something like this:
>
>  Method (AINT, 2, NotSerialized)
> {
> ...
>        If (LEqual (Arg0, One))
>        {
>            Store (Divide (Multiply (Arg1, 0xFF), 0x64, ), BCLP)
>            Or (BCLP, 0x80000000, BCLP)         <== touch BCLP register
>            Store (0x02, ASLC)
>        }
>
>    Method (_BCM, 1, NotSerialized)
>    {
>        If (LAnd (LGreaterEqual (Arg0, Zero), LLessEqual (Arg0, 0x64)))
>        {
>            AINT (One, Arg0)     <== call AINT method
>            Store (Arg0, BRTL)
>        }
>    }
>
>
> Just for reference, they should do that when EC didn't wire to
> backlight.
>
>> >
>> > Acer machine provide a broken _BCM implementation and they didn't test
>> > it.
>> >
>> > > > > By ' ACPI interface' , I mean 'acpi_video0' inside the
>> > > > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
>> > > > > directly . I will try that also.
>> > > >
>> > > > So writing values into /sys/class/backlight/acpi_video0/brightness does
>> > > > nothing?
>> > >
>> > >
>> > > No change in value when writing
>> > > to /sys/class/backlight/acpi_video0/brightness.
>> > >
>> > > Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
>> > > in new kernel (3.3.0-rc7) , it shows following messages ,
>> > >
>> > > [    8.350825] wmi: Mapper loaded
>> > > [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
>> > > [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
>> > > [   10.396385] acer_wmi: Brightness must be controlled by generic video
>> > > driver
>> > >
>> > > Also there was no interface inside /sys/class/backlight for acer_wmi.
>> > >
>> >
>> > Yes, acer_wmi support backlight control with AMW0 interface, your
>> > machine didn't have AMW0 interface.
>> >
>> > Normally, backlight should control by standard acpi interface.
>> >
>> > > I also tried writing directly to Embedded controller register .But no
>> > > change.
>> >
>> > The machine has broken _BCM method, because EC should do something after
>> > _BCM changed EC register.
>>
>> Thanks ,
>>
>> Pradeep Subrahmanion
>
> Why they didn't find _BCM not work?
>
> My guess is:
>
> Because the backlight control is through WDDM driver on Windows platform
> but not through standard ACPI method _BCM. They only test Windows
> platform, so, they didn't find _BCM broken.
>
> And, they also didn't really follow Microsoft WDDM spec:
>
>  http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx
>
> Per spec,
> ODM should keep _BCM works fine for any other OS didn't support WDDM
> driver, but they didn't.
>
> At last year, I told Acer PM one time for this issue, they said will
> check but finally didn't response me.
>

>
> Thanks
> Joey Lee
>

So touching the PCI LBB register is the only feasible solution now
(even though it may not be a clean  method) ?

Thanks,
Pradeep Subrahmanion
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

Hi Pradeep, 

於 三，2012-03-14 於 11:47 +0530，Pradeep Subrahmanion 提到：
> On Wed, Mar 14, 2012 at 11:21 AM, joeyli <jlee@suse.com> wrote:
> > 於 三，2012-03-14 於 08:13 +0530，Pradeep Subrahmanion 提到：
> >> Hi Joey ,
> >>
> >> > Per my understood, EC firmware should change brightness but didn't do
> >> > that, another
> >> > way is touch i915 register in _BCM.
> >>
> >>   how do we do this ? you mean change the _BCM implementation ?
> >
> > "BIOS guy" should do something like this:
> >
> >  Method (AINT, 2, NotSerialized)
> > {
> > ...
> >        If (LEqual (Arg0, One))
> >        {
> >            Store (Divide (Multiply (Arg1, 0xFF), 0x64, ), BCLP)
> >            Or (BCLP, 0x80000000, BCLP)         <== touch BCLP register
> >            Store (0x02, ASLC)
> >        }
> >
> >    Method (_BCM, 1, NotSerialized)
> >    {
> >        If (LAnd (LGreaterEqual (Arg0, Zero), LLessEqual (Arg0, 0x64)))
> >        {
> >            AINT (One, Arg0)     <== call AINT method
> >            Store (Arg0, BRTL)
> >        }
> >    }
> >
> >
> > Just for reference, they should do that when EC didn't wire to
> > backlight.
> >
> >> >
> >> > Acer machine provide a broken _BCM implementation and they didn't test
> >> > it.
> >> >
> >> > > > > By ' ACPI interface' , I mean 'acpi_video0' inside the
> >> > > > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> >> > > > > directly . I will try that also.
> >> > > >
> >> > > > So writing values into /sys/class/backlight/acpi_video0/brightness does
> >> > > > nothing?
> >> > >
> >> > >
> >> > > No change in value when writing
> >> > > to /sys/class/backlight/acpi_video0/brightness.
> >> > >
> >> > > Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
> >> > > in new kernel (3.3.0-rc7) , it shows following messages ,
> >> > >
> >> > > [    8.350825] wmi: Mapper loaded
> >> > > [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
> >> > > [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
> >> > > [   10.396385] acer_wmi: Brightness must be controlled by generic video
> >> > > driver
> >> > >
> >> > > Also there was no interface inside /sys/class/backlight for acer_wmi.
> >> > >
> >> >
> >> > Yes, acer_wmi support backlight control with AMW0 interface, your
> >> > machine didn't have AMW0 interface.
> >> >
> >> > Normally, backlight should control by standard acpi interface.
> >> >
> >> > > I also tried writing directly to Embedded controller register .But no
> >> > > change.
> >> >
> >> > The machine has broken _BCM method, because EC should do something after
> >> > _BCM changed EC register.
> >>
> >> Thanks ,
> >>
> >> Pradeep Subrahmanion
> >
> > Why they didn't find _BCM not work?
> >
> > My guess is:
> >
> > Because the backlight control is through WDDM driver on Windows platform
> > but not through standard ACPI method _BCM. They only test Windows
> > platform, so, they didn't find _BCM broken.
> >
> > And, they also didn't really follow Microsoft WDDM spec:
> >
> >  http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx
> >
> > Per spec,
> > ODM should keep _BCM works fine for any other OS didn't support WDDM
> > driver, but they didn't.
> >
> > At last year, I told Acer PM one time for this issue, they said will
> > check but finally didn't response me.
> >
> 
> >
> > Thanks
> > Joey Lee
> >
> 
> So touching the PCI LBB register is the only feasible solution now
> (even though it may not be a clean  method) ?
> 
> Thanks,
> Pradeep Subrahmanion

That will be better leave LBB register only touched by i915 driver.

If 'acpi_backlight=vendor' works to you, maybe we can add a quirk to
video_detect.c. 
You can try the following patch.


Thanks a lot!
Joey Lee


From 038bd3c4e53b7195f34e9d46c999b8dcb279da5e Mon Sep 17 00:00:00 2001
From: "Lee, Chun-Yi" <jlee@suse.com>
Date: Thu, 15 Mar 2012 16:03:45 +0800
Subject: [PATCH] acer-wmi: Add quirk table for video backlight vendor mode

Add quirk table for video backlight vendor mode

Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
 drivers/acpi/video_detect.c |   27 +++++++++++++++++++++++++++
 1 files changed, 27 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index f3f0fe7..acb15d6 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -132,6 +132,32 @@ find_video(acpi_handle handle, u32 lvl, void *context, void **rv)
 	return AE_OK;
 }
 
+static int video_set_backlight_vendor(const struct dmi_system_id *d)
+{
+	acpi_video_support |= ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
+	return 0;
+}
+
+static const struct dmi_system_id video_vendor_dmi_table[] = {
+	{
+	 .callback = video_set_backlight_vendor,
+	 .ident = "Acer Aspire 4736",
+	 .matches = {
+		DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
+		},
+	},
+	{
+	 .callback = video_set_backlight_vendor,
+	 .ident = "Acer TravelMate 4750",
+	 .matches = {
+		DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
+		},
+	},
+	{}
+};
+
 /*
  * Returns the video capabilities of a specific ACPI graphics device
  *
@@ -164,6 +190,7 @@ long acpi_video_get_capabilities(acpi_handle graphics_handle)
 		 *		ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
 		 *}
 		 */
+		dmi_check_system(video_vendor_dmi_table);
 	} else {
 		status = acpi_bus_get_device(graphics_handle, &tmp_dev);
 		if (ACPI_FAILURE(status)) {
-- 
1.7.7

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

On Thu, 2012-03-15 at 16:05 +0800, joeyli wrote:
> Hi Pradeep, 
> 
> 於 三，2012-03-14 於 11:47 +0530，Pradeep Subrahmanion 提到：
> > On Wed, Mar 14, 2012 at 11:21 AM, joeyli <jlee@suse.com> wrote:
> > > 於 三，2012-03-14 於 08:13 +0530，Pradeep Subrahmanion 提到：
> > >> Hi Joey ,
> > >>
> > >> > Per my understood, EC firmware should change brightness but didn't do
> > >> > that, another
> > >> > way is touch i915 register in _BCM.
> > >>
> > >>   how do we do this ? you mean change the _BCM implementation ?
> > >
> > > "BIOS guy" should do something like this:
> > >
> > >  Method (AINT, 2, NotSerialized)
> > > {
> > > ...
> > >        If (LEqual (Arg0, One))
> > >        {
> > >            Store (Divide (Multiply (Arg1, 0xFF), 0x64, ), BCLP)
> > >            Or (BCLP, 0x80000000, BCLP)         <== touch BCLP register
> > >            Store (0x02, ASLC)
> > >        }
> > >
> > >    Method (_BCM, 1, NotSerialized)
> > >    {
> > >        If (LAnd (LGreaterEqual (Arg0, Zero), LLessEqual (Arg0, 0x64)))
> > >        {
> > >            AINT (One, Arg0)     <== call AINT method
> > >            Store (Arg0, BRTL)
> > >        }
> > >    }
> > >
> > >
> > > Just for reference, they should do that when EC didn't wire to
> > > backlight.
> > >
> > >> >
> > >> > Acer machine provide a broken _BCM implementation and they didn't test
> > >> > it.
> > >> >
> > >> > > > > By ' ACPI interface' , I mean 'acpi_video0' inside the
> > >> > > > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> > >> > > > > directly . I will try that also.
> > >> > > >
> > >> > > > So writing values into /sys/class/backlight/acpi_video0/brightness does
> > >> > > > nothing?
> > >> > >
> > >> > >
> > >> > > No change in value when writing
> > >> > > to /sys/class/backlight/acpi_video0/brightness.
> > >> > >
> > >> > > Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
> > >> > > in new kernel (3.3.0-rc7) , it shows following messages ,
> > >> > >
> > >> > > [    8.350825] wmi: Mapper loaded
> > >> > > [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
> > >> > > [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
> > >> > > [   10.396385] acer_wmi: Brightness must be controlled by generic video
> > >> > > driver
> > >> > >
> > >> > > Also there was no interface inside /sys/class/backlight for acer_wmi.
> > >> > >
> > >> >
> > >> > Yes, acer_wmi support backlight control with AMW0 interface, your
> > >> > machine didn't have AMW0 interface.
> > >> >
> > >> > Normally, backlight should control by standard acpi interface.
> > >> >
> > >> > > I also tried writing directly to Embedded controller register .But no
> > >> > > change.
> > >> >
> > >> > The machine has broken _BCM method, because EC should do something after
> > >> > _BCM changed EC register.
> > >>
> > >> Thanks ,
> > >>
> > >> Pradeep Subrahmanion
> > >
> > > Why they didn't find _BCM not work?
> > >
> > > My guess is:
> > >
> > > Because the backlight control is through WDDM driver on Windows platform
> > > but not through standard ACPI method _BCM. They only test Windows
> > > platform, so, they didn't find _BCM broken.
> > >
> > > And, they also didn't really follow Microsoft WDDM spec:
> > >
> > >  http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx
> > >
> > > Per spec,
> > > ODM should keep _BCM works fine for any other OS didn't support WDDM
> > > driver, but they didn't.
> > >
> > > At last year, I told Acer PM one time for this issue, they said will
> > > check but finally didn't response me.
> > >
> > 
> > >
> > > Thanks
> > > Joey Lee
> > >
> > 
> > So touching the PCI LBB register is the only feasible solution now
> > (even though it may not be a clean  method) ?
> > 
> > Thanks,
> > Pradeep Subrahmanion
> 
> That will be better leave LBB register only touched by i915 driver.
> 
> If 'acpi_backlight=vendor' works to you, maybe we can add a quirk to
> video_detect.c. 
> You can try the following patch.

Thanks . I tried your patch .acpi_backlight=vendor allows me to control
brightness with hot key.But there are problems with it like increasing
brightness after  maximum level causes blank screen.So I am trying it
sort it out.
 
Thank you , 

Pradeep Subrahmanion

> 
> 
> Thanks a lot!
> Joey Lee
> 
> 
> >From 038bd3c4e53b7195f34e9d46c999b8dcb279da5e Mon Sep 17 00:00:00 2001
> From: "Lee, Chun-Yi" <jlee@suse.com>
> Date: Thu, 15 Mar 2012 16:03:45 +0800
> Subject: [PATCH] acer-wmi: Add quirk table for video backlight vendor mode
> 
> Add quirk table for video backlight vendor mode
> 
> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> ---
>  drivers/acpi/video_detect.c |   27 +++++++++++++++++++++++++++
>  1 files changed, 27 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index f3f0fe7..acb15d6 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -132,6 +132,32 @@ find_video(acpi_handle handle, u32 lvl, void *context, void **rv)
>  	return AE_OK;
>  }
>  
> +static int video_set_backlight_vendor(const struct dmi_system_id *d)
> +{
> +	acpi_video_support |= ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
> +	return 0;
> +}
> +
> +static const struct dmi_system_id video_vendor_dmi_table[] = {
> +	{
> +	 .callback = video_set_backlight_vendor,
> +	 .ident = "Acer Aspire 4736",
> +	 .matches = {
> +		DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
> +		},
> +	},
> +	{
> +	 .callback = video_set_backlight_vendor,
> +	 .ident = "Acer TravelMate 4750",
> +	 .matches = {
> +		DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
> +		},
> +	},
> +	{}
> +};
> +
>  /*
>   * Returns the video capabilities of a specific ACPI graphics device
>   *
> @@ -164,6 +190,7 @@ long acpi_video_get_capabilities(acpi_handle graphics_handle)
>  		 *		ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
>  		 *}
>  		 */
> +		dmi_check_system(video_vendor_dmi_table);
>  	} else {
>  		status = acpi_bus_get_device(graphics_handle, &tmp_dev);
>  		if (ACPI_FAILURE(status)) {

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

於 日，2012-03-18 於 10:40 +0530，Pradeep Subrahmanion 提到：
> On Thu, 2012-03-15 at 16:05 +0800, joeyli wrote:
> > Hi Pradeep, 
> > 
> > 於 三，2012-03-14 於 11:47 +0530，Pradeep Subrahmanion 提到：
> > > On Wed, Mar 14, 2012 at 11:21 AM, joeyli <jlee@suse.com> wrote:
> > > > 於 三，2012-03-14 於 08:13 +0530，Pradeep Subrahmanion 提到：
> > > >> Hi Joey ,
> > > >>
> > > >> > Per my understood, EC firmware should change brightness but didn't do
> > > >> > that, another
> > > >> > way is touch i915 register in _BCM.
> > > >>
> > > >>   how do we do this ? you mean change the _BCM implementation ?
> > > >
> > > > "BIOS guy" should do something like this:
> > > >
> > > >  Method (AINT, 2, NotSerialized)
> > > > {
> > > > ...
> > > >        If (LEqual (Arg0, One))
> > > >        {
> > > >            Store (Divide (Multiply (Arg1, 0xFF), 0x64, ), BCLP)
> > > >            Or (BCLP, 0x80000000, BCLP)         <== touch BCLP register
> > > >            Store (0x02, ASLC)
> > > >        }
> > > >
> > > >    Method (_BCM, 1, NotSerialized)
> > > >    {
> > > >        If (LAnd (LGreaterEqual (Arg0, Zero), LLessEqual (Arg0, 0x64)))
> > > >        {
> > > >            AINT (One, Arg0)     <== call AINT method
> > > >            Store (Arg0, BRTL)
> > > >        }
> > > >    }
> > > >
> > > >
> > > > Just for reference, they should do that when EC didn't wire to
> > > > backlight.
> > > >
> > > >> >
> > > >> > Acer machine provide a broken _BCM implementation and they didn't test
> > > >> > it.
> > > >> >
> > > >> > > > > By ' ACPI interface' , I mean 'acpi_video0' inside the
> > > >> > > > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> > > >> > > > > directly . I will try that also.
> > > >> > > >
> > > >> > > > So writing values into /sys/class/backlight/acpi_video0/brightness does
> > > >> > > > nothing?
> > > >> > >
> > > >> > >
> > > >> > > No change in value when writing
> > > >> > > to /sys/class/backlight/acpi_video0/brightness.
> > > >> > >
> > > >> > > Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
> > > >> > > in new kernel (3.3.0-rc7) , it shows following messages ,
> > > >> > >
> > > >> > > [    8.350825] wmi: Mapper loaded
> > > >> > > [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
> > > >> > > [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
> > > >> > > [   10.396385] acer_wmi: Brightness must be controlled by generic video
> > > >> > > driver
> > > >> > >
> > > >> > > Also there was no interface inside /sys/class/backlight for acer_wmi.
> > > >> > >
> > > >> >
> > > >> > Yes, acer_wmi support backlight control with AMW0 interface, your
> > > >> > machine didn't have AMW0 interface.
> > > >> >
> > > >> > Normally, backlight should control by standard acpi interface.
> > > >> >
> > > >> > > I also tried writing directly to Embedded controller register .But no
> > > >> > > change.
> > > >> >
> > > >> > The machine has broken _BCM method, because EC should do something after
> > > >> > _BCM changed EC register.
> > > >>
> > > >> Thanks ,
> > > >>
> > > >> Pradeep Subrahmanion
> > > >
> > > > Why they didn't find _BCM not work?
> > > >
> > > > My guess is:
> > > >
> > > > Because the backlight control is through WDDM driver on Windows platform
> > > > but not through standard ACPI method _BCM. They only test Windows
> > > > platform, so, they didn't find _BCM broken.
> > > >
> > > > And, they also didn't really follow Microsoft WDDM spec:
> > > >
> > > >  http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx
> > > >
> > > > Per spec,
> > > > ODM should keep _BCM works fine for any other OS didn't support WDDM
> > > > driver, but they didn't.
> > > >
> > > > At last year, I told Acer PM one time for this issue, they said will
> > > > check but finally didn't response me.
> > > >
> > > 
> > > >
> > > > Thanks
> > > > Joey Lee
> > > >
> > > 
> > > So touching the PCI LBB register is the only feasible solution now
> > > (even though it may not be a clean  method) ?
> > > 
> > > Thanks,
> > > Pradeep Subrahmanion
> > 
> > That will be better leave LBB register only touched by i915 driver.
> > 
> > If 'acpi_backlight=vendor' works to you, maybe we can add a quirk to
> > video_detect.c. 
> > You can try the following patch.
> 
> Thanks . I tried your patch .acpi_backlight=vendor allows me to control
> brightness with hot key.But there are problems with it like increasing

OK, thanks for your testing, I will send out patch and add Cc. to you.

> brightness after  maximum level causes blank screen.So I am trying it
> sort it out.
>  
> Thank you , 
> 
> Pradeep Subrahmanion
> 

For the maximum level causes blank screen...

Please kindly help to identify which driver handle the brightness
change, run the following 2 commands:

# echo 5 > /sys/class/backlight/acer-wmi/brightness 
# echo 5 > /sys/class/backlight/intel_backlight/brightness 

Which one works to change brightness on your machine?


Thanks a lot!
Joey Lee

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

> For the maximum level causes blank screen...
> 
> Please kindly help to identify which driver handle the brightness
> change, run the following 2 commands:
> 
> # echo 5 > /sys/class/backlight/acer-wmi/brightness 
> # echo 5 > /sys/class/backlight/intel_backlight/brightness 
> 
> Which one works to change brightness on your machine?

	Both  of them do not work for me.Only hot keys are working. 

Writing to /sys/class/backlight/acer-wmi/brightness 

and /sys/class/backlight/intel_backlight/brightness do not cause any 

change in brightness.


Regards , 

Pradeep Subrahmanion

> 
> 
> Thanks a lot!
> Joey Lee

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

Hi Pradeep, 

於 一，2012-03-19 於 17:03 +0530，Pradeep Subrahmanion 提到：
> > For the maximum level causes blank screen...
> > 
> > Please kindly help to identify which driver handle the brightness
> > change, run the following 2 commands:
> > 
> > # echo 5 > /sys/class/backlight/acer-wmi/brightness 
> > # echo 5 > /sys/class/backlight/intel_backlight/brightness 
> > 
> > Which one works to change brightness on your machine?
> 
> 	Both  of them do not work for me.Only hot keys are working. 
> 
> Writing to /sys/class/backlight/acer-wmi/brightness 
> 
> and /sys/class/backlight/intel_backlight/brightness do not cause any 
> 
> change in brightness.
> 
> 
> Regards , 
> 
> Pradeep Subrahmanion

A bit strange...

Could you please paste your /proc/cmdline ? Did you add
acpi_osi="Linux" ?


Thanks a lot!
Joey Lee

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

於 一，2012-03-19 於 10:01 +0800，joeyli 提到：
> 於 日，2012-03-18 於 10:40 +0530，Pradeep Subrahmanion 提到：
> > On Thu, 2012-03-15 at 16:05 +0800, joeyli wrote:
> > > Hi Pradeep, 
> > > 
> > > 於 三，2012-03-14 於 11:47 +0530，Pradeep Subrahmanion 提到：
> > > > On Wed, Mar 14, 2012 at 11:21 AM, joeyli <jlee@suse.com> wrote:
> > > > > 於 三，2012-03-14 於 08:13 +0530，Pradeep Subrahmanion 提到：
> > > > >> Hi Joey ,
> > > > >>
> > > > >> > Per my understood, EC firmware should change brightness but didn't do
> > > > >> > that, another
> > > > >> > way is touch i915 register in _BCM.
> > > > >>
> > > > >>   how do we do this ? you mean change the _BCM implementation ?
> > > > >
> > > > > "BIOS guy" should do something like this:
> > > > >
> > > > >  Method (AINT, 2, NotSerialized)
> > > > > {
> > > > > ...
> > > > >        If (LEqual (Arg0, One))
> > > > >        {
> > > > >            Store (Divide (Multiply (Arg1, 0xFF), 0x64, ), BCLP)
> > > > >            Or (BCLP, 0x80000000, BCLP)         <== touch BCLP register
> > > > >            Store (0x02, ASLC)
> > > > >        }
> > > > >
> > > > >    Method (_BCM, 1, NotSerialized)
> > > > >    {
> > > > >        If (LAnd (LGreaterEqual (Arg0, Zero), LLessEqual (Arg0, 0x64)))
> > > > >        {
> > > > >            AINT (One, Arg0)     <== call AINT method
> > > > >            Store (Arg0, BRTL)
> > > > >        }
> > > > >    }
> > > > >
> > > > >
> > > > > Just for reference, they should do that when EC didn't wire to
> > > > > backlight.
> > > > >
> > > > >> >
> > > > >> > Acer machine provide a broken _BCM implementation and they didn't test
> > > > >> > it.
> > > > >> >
> > > > >> > > > > By ' ACPI interface' , I mean 'acpi_video0' inside the
> > > > >> > > > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> > > > >> > > > > directly . I will try that also.
> > > > >> > > >
> > > > >> > > > So writing values into /sys/class/backlight/acpi_video0/brightness does
> > > > >> > > > nothing?
> > > > >> > >
> > > > >> > >
> > > > >> > > No change in value when writing
> > > > >> > > to /sys/class/backlight/acpi_video0/brightness.
> > > > >> > >
> > > > >> > > Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
> > > > >> > > in new kernel (3.3.0-rc7) , it shows following messages ,
> > > > >> > >
> > > > >> > > [    8.350825] wmi: Mapper loaded
> > > > >> > > [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
> > > > >> > > [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
> > > > >> > > [   10.396385] acer_wmi: Brightness must be controlled by generic video
> > > > >> > > driver
> > > > >> > >
> > > > >> > > Also there was no interface inside /sys/class/backlight for acer_wmi.
> > > > >> > >
> > > > >> >
> > > > >> > Yes, acer_wmi support backlight control with AMW0 interface, your
> > > > >> > machine didn't have AMW0 interface.
> > > > >> >
> > > > >> > Normally, backlight should control by standard acpi interface.
> > > > >> >
> > > > >> > > I also tried writing directly to Embedded controller register .But no
> > > > >> > > change.
> > > > >> >
> > > > >> > The machine has broken _BCM method, because EC should do something after
> > > > >> > _BCM changed EC register.
> > > > >>
> > > > >> Thanks ,
> > > > >>
> > > > >> Pradeep Subrahmanion
> > > > >
> > > > > Why they didn't find _BCM not work?
> > > > >
> > > > > My guess is:
> > > > >
> > > > > Because the backlight control is through WDDM driver on Windows platform
> > > > > but not through standard ACPI method _BCM. They only test Windows
> > > > > platform, so, they didn't find _BCM broken.
> > > > >
> > > > > And, they also didn't really follow Microsoft WDDM spec:
> > > > >
> > > > >  http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx
> > > > >
> > > > > Per spec,
> > > > > ODM should keep _BCM works fine for any other OS didn't support WDDM
> > > > > driver, but they didn't.
> > > > >
> > > > > At last year, I told Acer PM one time for this issue, they said will
> > > > > check but finally didn't response me.
> > > > >
> > > > 
> > > > >
> > > > > Thanks
> > > > > Joey Lee
> > > > >
> > > > 
> > > > So touching the PCI LBB register is the only feasible solution now
> > > > (even though it may not be a clean  method) ?
> > > > 
> > > > Thanks,
> > > > Pradeep Subrahmanion
> > > 
> > > That will be better leave LBB register only touched by i915 driver.
> > > 
> > > If 'acpi_backlight=vendor' works to you, maybe we can add a quirk to
> > > video_detect.c. 
> > > You can try the following patch.
> > 
> > Thanks . I tried your patch .acpi_backlight=vendor allows me to control
> > brightness with hot key.But there are problems with it like increasing
> 
> OK, thanks for your testing, I will send out patch and add Cc. to you.
> 

Could you please kindly try this new patch? I follow Matthew's kindly
suggestion put the quirk table to acer-wmi driver.

Please help to apply the following patch to acer-wmi and remember remove
my last patch of video_detect.c, then rebuild your kernel.

Hope this patch also can fix your problem.


Thanks a lot!
Joey Lee

From 5da43d2ee6c87dcf17fda34f0b50fe11b04a16bf Mon Sep 17 00:00:00 2001
From: "Lee, Chun-Yi" <jlee@suse.com>
Date: Tue, 20 Mar 2012 19:00:58 +0800
Subject: [PATCH] acer-wmi: add quirk table for video backlight vendor mode

There have some acer laptop have broken _BCM implemenation, the AML
code wrote value to EC register but firmware didn't change brighenss.

Fortunately, the brightness control works on those machines with
vendor mode. So, add quirk table for video backlight vendor mode
and unregister acpi video interface on those machines.

Tested on Acer TravelMate 4750

Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/platform/x86/Kconfig    |    4 ++++
 drivers/platform/x86/acer-wmi.c |   38 +++++++++++++++++++++++++++++++++++---
 2 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 15dbd8c..fe3a494 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -26,6 +26,10 @@ config ACER_WMI
 	depends on RFKILL || RFKILL = n
 	depends on ACPI_WMI
 	select INPUT_SPARSEKMAP
+	# Acer WMI depends on ACPI_VIDEO when ACPI is enabled
+	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
+        select VIDEO_OUTPUT_CONTROL if ACPI
+        select ACPI_VIDEO if ACPI
 	---help---
 	  This is a driver for newer Acer (and Wistron) laptops. It adds
 	  wireless radio and bluetooth control, and on some laptops,
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1e5290b..984a7b5 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -43,6 +43,7 @@
 #include <linux/input/sparse-keymap.h>
 
 #include <acpi/acpi_drivers.h>
+#include <acpi/video.h>
 
 MODULE_AUTHOR("Carlos Corbacho");
 MODULE_DESCRIPTION("Acer Laptop WMI Extras Driver");
@@ -478,6 +479,33 @@ static struct dmi_system_id acer_quirks[] = {
 	{}
 };
 
+static int video_set_backlight_video_vendor(const struct dmi_system_id *d)
+{
+	interface->capability &= ~ACER_CAP_BRIGHTNESS;
+	pr_info("Brightness must be controlled by generic video driver\n");
+	return 0;
+}
+
+static const struct dmi_system_id video_vendor_dmi_table[] = {
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer Aspire 4736",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
+		},
+	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer TravelMate 4750",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
+		},
+	},
+	{}
+};
+
 /* Find which quirks are needed for a particular vendor/ model pair */
 static void find_quirks(void)
 {
@@ -1981,9 +2009,13 @@ static int __init acer_wmi_init(void)
 	set_quirks();
 
 	if (acpi_video_backlight_support()) {
-		interface->capability &= ~ACER_CAP_BRIGHTNESS;
-		pr_info("Brightness must be controlled by "
-		       "generic video driver\n");
+		if (dmi_check_system(video_vendor_dmi_table)) {
+			acpi_video_unregister();
+		} else {
+			interface->capability &= ~ACER_CAP_BRIGHTNESS;
+			pr_info("Brightness must be controlled by "
+				"acpi video driver\n");
+		}
 	}
 
 	if (wmi_has_guid(WMID_GUID3)) {
-- 
1.7.7

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

> >From 5da43d2ee6c87dcf17fda34f0b50fe11b04a16bf Mon Sep 17 00:00:00 2001
> From: "Lee, Chun-Yi" <jlee@suse.com>
> Date: Tue, 20 Mar 2012 19:00:58 +0800
> Subject: [PATCH] acer-wmi: add quirk table for video backlight vendor mode
> 
> There have some acer laptop have broken _BCM implemenation, the AML
> code wrote value to EC register but firmware didn't change brighenss.
> 
> Fortunately, the brightness control works on those machines with
> vendor mode. So, add quirk table for video backlight vendor mode
> and unregister acpi video interface on those machines.
> 
> Tested on Acer TravelMate 4750
> 
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> ---
>  drivers/platform/x86/Kconfig    |    4 ++++
>  drivers/platform/x86/acer-wmi.c |   38 +++++++++++++++++++++++++++++++++++---
>  2 files changed, 39 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 15dbd8c..fe3a494 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -26,6 +26,10 @@ config ACER_WMI
>  	depends on RFKILL || RFKILL = n
>  	depends on ACPI_WMI
>  	select INPUT_SPARSEKMAP
> +	# Acer WMI depends on ACPI_VIDEO when ACPI is enabled
> +	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
> +        select VIDEO_OUTPUT_CONTROL if ACPI
> +        select ACPI_VIDEO if ACPI
>  	---help---
>  	  This is a driver for newer Acer (and Wistron) laptops. It adds
>  	  wireless radio and bluetooth control, and on some laptops,
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1e5290b..984a7b5 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -43,6 +43,7 @@
>  #include <linux/input/sparse-keymap.h>
>  
>  #include <acpi/acpi_drivers.h>
> +#include <acpi/video.h>
>  
>  MODULE_AUTHOR("Carlos Corbacho");
>  MODULE_DESCRIPTION("Acer Laptop WMI Extras Driver");
> @@ -478,6 +479,33 @@ static struct dmi_system_id acer_quirks[] = {
>  	{}
>  };
>  
> +static int video_set_backlight_video_vendor(const struct dmi_system_id *d)
> +{
> +	interface->capability &= ~ACER_CAP_BRIGHTNESS;
> +	pr_info("Brightness must be controlled by generic video driver\n");
> +	return 0;
> +}
> +
> +static const struct dmi_system_id video_vendor_dmi_table[] = {
> +	{
> +		.callback = video_set_backlight_video_vendor,
> +		.ident = "Acer Aspire 4736",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
> +		},
> +	},
> +	{
> +		.callback = video_set_backlight_video_vendor,
> +		.ident = "Acer TravelMate 4750",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
> +		},
> +	},
> +	{}
> +};
> +
>  /* Find which quirks are needed for a particular vendor/ model pair */
>  static void find_quirks(void)
>  {
> @@ -1981,9 +2009,13 @@ static int __init acer_wmi_init(void)
>  	set_quirks();
>  
>  	if (acpi_video_backlight_support()) {
> -		interface->capability &= ~ACER_CAP_BRIGHTNESS;
> -		pr_info("Brightness must be controlled by "
> -		       "generic video driver\n");
> +		if (dmi_check_system(video_vendor_dmi_table)) {
> +			acpi_video_unregister();
> +		} else {
> +			interface->capability &= ~ACER_CAP_BRIGHTNESS;
> +			pr_info("Brightness must be controlled by "
> +				"acpi video driver\n");
> +		}
>  	}
>  
>  	if (wmi_has_guid(WMID_GUID3)) {

I tried out applied your patch . Boot message shows , 

[11.220410] acer_wmi: Brightness must be controlled by generic video
driver

Now 'acpi_video0' and 'intel_backlight' are present
inside /sys/class/backlight .Hot key works like earlier ( ie problem
after maximum level still exists).
I tried following commands , 

echo 5 > /sys/class/backlight/acpi_video0/brightness 
echo 5 > /sys/class/backlight/intel_backlight/brightness

But it doesn't make any change . 

In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control 

already starts working with 'acpi_osi=Linux' option.

cat /proc/cmdline gives , 

BOOT_IMAGE=/boot/vmlinuz-3.3.0+
root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux 


Thanks , 

Pradeep Subrahmanion

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 5181 bytes --]

於 三，2012-03-21 於 00:25 +0530，Pradeep Subrahmanion 提到：
> > >From 5da43d2ee6c87dcf17fda34f0b50fe11b04a16bf Mon Sep 17 00:00:00 2001
> > From: "Lee, Chun-Yi" <jlee@suse.com>
> > Date: Tue, 20 Mar 2012 19:00:58 +0800
> > Subject: [PATCH] acer-wmi: add quirk table for video backlight vendor mode
> > 
> > There have some acer laptop have broken _BCM implemenation, the AML
> > code wrote value to EC register but firmware didn't change brighenss.
> > 
> > Fortunately, the brightness control works on those machines with
> > vendor mode. So, add quirk table for video backlight vendor mode
> > and unregister acpi video interface on those machines.
> > 
> > Tested on Acer TravelMate 4750
> > 
> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> > ---
> >  drivers/platform/x86/Kconfig    |    4 ++++
> >  drivers/platform/x86/acer-wmi.c |   38 +++++++++++++++++++++++++++++++++++---
> >  2 files changed, 39 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 15dbd8c..fe3a494 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -26,6 +26,10 @@ config ACER_WMI
> >  	depends on RFKILL || RFKILL = n
> >  	depends on ACPI_WMI
> >  	select INPUT_SPARSEKMAP
> > +	# Acer WMI depends on ACPI_VIDEO when ACPI is enabled
> > +	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
> > +        select VIDEO_OUTPUT_CONTROL if ACPI
> > +        select ACPI_VIDEO if ACPI
> >  	---help---
> >  	  This is a driver for newer Acer (and Wistron) laptops. It adds
> >  	  wireless radio and bluetooth control, and on some laptops,
> > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > index 1e5290b..984a7b5 100644
> > --- a/drivers/platform/x86/acer-wmi.c
> > +++ b/drivers/platform/x86/acer-wmi.c
> > @@ -43,6 +43,7 @@
> >  #include <linux/input/sparse-keymap.h>
> >  
> >  #include <acpi/acpi_drivers.h>
> > +#include <acpi/video.h>
> >  
> >  MODULE_AUTHOR("Carlos Corbacho");
> >  MODULE_DESCRIPTION("Acer Laptop WMI Extras Driver");
> > @@ -478,6 +479,33 @@ static struct dmi_system_id acer_quirks[] = {
> >  	{}
> >  };
> >  
> > +static int video_set_backlight_video_vendor(const struct dmi_system_id *d)
> > +{
> > +	interface->capability &= ~ACER_CAP_BRIGHTNESS;
> > +	pr_info("Brightness must be controlled by generic video driver\n");
> > +	return 0;
> > +}
> > +
> > +static const struct dmi_system_id video_vendor_dmi_table[] = {
> > +	{
> > +		.callback = video_set_backlight_video_vendor,
> > +		.ident = "Acer Aspire 4736",
> > +		.matches = {
> > +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
> > +		},
> > +	},
> > +	{
> > +		.callback = video_set_backlight_video_vendor,
> > +		.ident = "Acer TravelMate 4750",
> > +		.matches = {
> > +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
> > +		},
> > +	},
> > +	{}
> > +};
> > +
> >  /* Find which quirks are needed for a particular vendor/ model pair */
> >  static void find_quirks(void)
> >  {
> > @@ -1981,9 +2009,13 @@ static int __init acer_wmi_init(void)
> >  	set_quirks();
> >  
> >  	if (acpi_video_backlight_support()) {
> > -		interface->capability &= ~ACER_CAP_BRIGHTNESS;
> > -		pr_info("Brightness must be controlled by "
> > -		       "generic video driver\n");
> > +		if (dmi_check_system(video_vendor_dmi_table)) {
> > +			acpi_video_unregister();
> > +		} else {
> > +			interface->capability &= ~ACER_CAP_BRIGHTNESS;
> > +			pr_info("Brightness must be controlled by "
> > +				"acpi video driver\n");
> > +		}
> >  	}
> >  
> >  	if (wmi_has_guid(WMID_GUID3)) {
> 
> I tried out applied your patch . Boot message shows , 
> 
> [11.220410] acer_wmi: Brightness must be controlled by generic video
> driver
> 
> Now 'acpi_video0' and 'intel_backlight' are present
> inside /sys/class/backlight .Hot key works like earlier ( ie problem
> after maximum level still exists).
> I tried following commands , 
> 

It's not the expected behavior.

This new patch should remove acpi_video0 interface on your machine.
Please kindly provide your dmidecode:
 dmidecode > dmidecode.log

And, 
please make should the patch really applied, you can do a bit change on
pr_info message by yourself.

> echo 5 > /sys/class/backlight/acpi_video0/brightness 
> echo 5 > /sys/class/backlight/intel_backlight/brightness
> 
> But it doesn't make any change . 
> 
> In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control 
> 
> already starts working with 'acpi_osi=Linux' option.
> 
> cat /proc/cmdline gives , 
> 
> BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux 
> 
> 
> Thanks , 
> 
> Pradeep Subrahmanion
> 

OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
think the hotkey of backlight control only works with acpi_osi=Linux ?


Thanks a lot!
Joey Lee


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 5788 bytes --]

On Wed, 2012-03-21 at 11:00 +0800, joeyli wrote:
> 於 三，2012-03-21 於 00:25 +0530，Pradeep Subrahmanion 提到：
> > > >From 5da43d2ee6c87dcf17fda34f0b50fe11b04a16bf Mon Sep 17 00:00:00 2001
> > > From: "Lee, Chun-Yi" <jlee@suse.com>
> > > Date: Tue, 20 Mar 2012 19:00:58 +0800
> > > Subject: [PATCH] acer-wmi: add quirk table for video backlight vendor mode
> > > 
> > > There have some acer laptop have broken _BCM implemenation, the AML
> > > code wrote value to EC register but firmware didn't change brighenss.
> > > 
> > > Fortunately, the brightness control works on those machines with
> > > vendor mode. So, add quirk table for video backlight vendor mode
> > > and unregister acpi video interface on those machines.
> > > 
> > > Tested on Acer TravelMate 4750
> > > 
> > > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> > > ---
> > >  drivers/platform/x86/Kconfig    |    4 ++++
> > >  drivers/platform/x86/acer-wmi.c |   38 +++++++++++++++++++++++++++++++++++---
> > >  2 files changed, 39 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > > index 15dbd8c..fe3a494 100644
> > > --- a/drivers/platform/x86/Kconfig
> > > +++ b/drivers/platform/x86/Kconfig
> > > @@ -26,6 +26,10 @@ config ACER_WMI
> > >  	depends on RFKILL || RFKILL = n
> > >  	depends on ACPI_WMI
> > >  	select INPUT_SPARSEKMAP
> > > +	# Acer WMI depends on ACPI_VIDEO when ACPI is enabled
> > > +	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
> > > +        select VIDEO_OUTPUT_CONTROL if ACPI
> > > +        select ACPI_VIDEO if ACPI
> > >  	---help---
> > >  	  This is a driver for newer Acer (and Wistron) laptops. It adds
> > >  	  wireless radio and bluetooth control, and on some laptops,
> > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > > index 1e5290b..984a7b5 100644
> > > --- a/drivers/platform/x86/acer-wmi.c
> > > +++ b/drivers/platform/x86/acer-wmi.c
> > > @@ -43,6 +43,7 @@
> > >  #include <linux/input/sparse-keymap.h>
> > >  
> > >  #include <acpi/acpi_drivers.h>
> > > +#include <acpi/video.h>
> > >  
> > >  MODULE_AUTHOR("Carlos Corbacho");
> > >  MODULE_DESCRIPTION("Acer Laptop WMI Extras Driver");
> > > @@ -478,6 +479,33 @@ static struct dmi_system_id acer_quirks[] = {
> > >  	{}
> > >  };
> > >  
> > > +static int video_set_backlight_video_vendor(const struct dmi_system_id *d)
> > > +{
> > > +	interface->capability &= ~ACER_CAP_BRIGHTNESS;
> > > +	pr_info("Brightness must be controlled by generic video driver\n");
> > > +	return 0;
> > > +}
> > > +
> > > +static const struct dmi_system_id video_vendor_dmi_table[] = {
> > > +	{
> > > +		.callback = video_set_backlight_video_vendor,
> > > +		.ident = "Acer Aspire 4736",
> > > +		.matches = {
> > > +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> > > +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
> > > +		},
> > > +	},
> > > +	{
> > > +		.callback = video_set_backlight_video_vendor,
> > > +		.ident = "Acer TravelMate 4750",
> > > +		.matches = {
> > > +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> > > +			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
> > > +		},
> > > +	},
> > > +	{}
> > > +};
> > > +
> > >  /* Find which quirks are needed for a particular vendor/ model pair */
> > >  static void find_quirks(void)
> > >  {
> > > @@ -1981,9 +2009,13 @@ static int __init acer_wmi_init(void)
> > >  	set_quirks();
> > >  
> > >  	if (acpi_video_backlight_support()) {
> > > -		interface->capability &= ~ACER_CAP_BRIGHTNESS;
> > > -		pr_info("Brightness must be controlled by "
> > > -		       "generic video driver\n");
> > > +		if (dmi_check_system(video_vendor_dmi_table)) {
> > > +			acpi_video_unregister();
> > > +		} else {
> > > +			interface->capability &= ~ACER_CAP_BRIGHTNESS;
> > > +			pr_info("Brightness must be controlled by "
> > > +				"acpi video driver\n");
> > > +		}
> > >  	}
> > >  
> > >  	if (wmi_has_guid(WMID_GUID3)) {
> > 
> > I tried out applied your patch . Boot message shows , 
> > 
> > [11.220410] acer_wmi: Brightness must be controlled by generic video
> > driver
> > 
> > Now 'acpi_video0' and 'intel_backlight' are present
> > inside /sys/class/backlight .Hot key works like earlier ( ie problem
> > after maximum level still exists).
> > I tried following commands , 
> > 
> 
> It's not the expected behavior.
> 
> This new patch should remove acpi_video0 interface on your machine.
> Please kindly provide your dmidecode:
>  dmidecode > dmidecode.log
>
> And, 
> please make should the patch really applied, you can do a bit change on
> pr_info message by yourself.

   Sorry . I think there was some mistake . I tried the patch again. Now
I see only intel_backlight inside /sys/class/backlight. There is no
acer-wmi interface . Is this the expected behavior ? . Or am I missing
anything ?



> 
> > echo 5 > /sys/class/backlight/acpi_video0/brightness 
> > echo 5 > /sys/class/backlight/intel_backlight/brightness
> > 
> > But it doesn't make any change . 
> > 
> > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control 
> > 
> > already starts working with 'acpi_osi=Linux' option.
> > 
> > cat /proc/cmdline gives , 
> > 
> > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux 
> > 
> > 
> > Thanks , 
> > 
> > Pradeep Subrahmanion
> > 
> 
> OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
> think the hotkey of backlight control only works with acpi_osi=Linux ?
> 
> 
> Thanks a lot!
> Joey Lee
> 
> 

Thanks , 

Pradeep Subrahmanion

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1731 bytes --]

於 四，2012-03-22 於 00:39 +0530，Pradeep Subrahmanion 提到：
> > This new patch should remove acpi_video0 interface on your machine.
> > Please kindly provide your dmidecode:
> >  dmidecode > dmidecode.log
> >
> > And, 
> > please make should the patch really applied, you can do a bit change on
> > pr_info message by yourself.
> 
>    Sorry . I think there was some mistake . I tried the patch again. Now
> I see only intel_backlight inside /sys/class/backlight. There is no
> acer-wmi interface . Is this the expected behavior ? . Or am I missing
> anything ?
> 

Yes, this is the expected behavior! But, now I doubt your issue was
workaround by acpi_osi=Linux but not intel_backlight.

> 
> 
> > 
> > > echo 5 > /sys/class/backlight/acpi_video0/brightness 
> > > echo 5 > /sys/class/backlight/intel_backlight/brightness
> > > 
> > > But it doesn't make any change . 
> > > 
> > > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control 
> > > 
> > > already starts working with 'acpi_osi=Linux' option.
> > > 
> > > cat /proc/cmdline gives , 
> > > 
> > > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> > > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux 
> > > 
> > > 
> > > Thanks , 
> > > 
> > > Pradeep Subrahmanion
> > > 
> > 
> > OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
> > think the hotkey of backlight control only works with acpi_osi=Linux ?
> > 

Does your backlight control still work if you remove acpi_osi=Linux ?


Thanks a lot!
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1987 bytes --]

On Thu, 2012-03-22 at 09:33 +0800, joeyli wrote:
> 於 四，2012-03-22 於 00:39 +0530，Pradeep Subrahmanion 提到：
> > > This new patch should remove acpi_video0 interface on your machine.
> > > Please kindly provide your dmidecode:
> > >  dmidecode > dmidecode.log
> > >
> > > And, 
> > > please make should the patch really applied, you can do a bit change on
> > > pr_info message by yourself.
> > 
> >    Sorry . I think there was some mistake . I tried the patch again. Now
> > I see only intel_backlight inside /sys/class/backlight. There is no
> > acer-wmi interface . Is this the expected behavior ? . Or am I missing
> > anything ?
> > 
> 
> Yes, this is the expected behavior! But, now I doubt your issue was
> workaround by acpi_osi=Linux but not intel_backlight.
>

> > 
> > 
> > > 
> > > > echo 5 > /sys/class/backlight/acpi_video0/brightness 
> > > > echo 5 > /sys/class/backlight/intel_backlight/brightness
> > > > 
> > > > But it doesn't make any change . 
> > > > 
> > > > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control 
> > > > 
> > > > already starts working with 'acpi_osi=Linux' option.
> > > > 
> > > > cat /proc/cmdline gives , 
> > > > 
> > > > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> > > > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux 
> > > > 
> > > > 
> > > > Thanks , 
> > > > 
> > > > Pradeep Subrahmanion
> > > > 
> > > 
> > > OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
> > > think the hotkey of backlight control only works with acpi_osi=Linux ?
> > > 
> 
> Does your backlight control still work if you remove acpi_osi=Linux ?

   If I remove acpi_osi=Linux , the hot key control stops working .

> 
> 
> Thanks a lot!
> Joey Lee
> 

Thanks , 

Pradeep Subrahmanion


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 2199 bytes --]

於 四，2012-03-22 於 08:03 +0530，Pradeep Subrahmanion 提到：
> On Thu, 2012-03-22 at 09:33 +0800, joeyli wrote:
> > 於 四，2012-03-22 於 00:39 +0530，Pradeep Subrahmanion 提到：
> > > > This new patch should remove acpi_video0 interface on your machine.
> > > > Please kindly provide your dmidecode:
> > > >  dmidecode > dmidecode.log
> > > >
> > > > And, 
> > > > please make should the patch really applied, you can do a bit change on
> > > > pr_info message by yourself.
> > > 
> > >    Sorry . I think there was some mistake . I tried the patch again. Now
> > > I see only intel_backlight inside /sys/class/backlight. There is no
> > > acer-wmi interface . Is this the expected behavior ? . Or am I missing
> > > anything ?
> > > 
> > 
> > Yes, this is the expected behavior! But, now I doubt your issue was
> > workaround by acpi_osi=Linux but not intel_backlight.
> >
> 
> > > 
> > > 
> > > > 
> > > > > echo 5 > /sys/class/backlight/acpi_video0/brightness 
> > > > > echo 5 > /sys/class/backlight/intel_backlight/brightness
> > > > > 
> > > > > But it doesn't make any change . 
> > > > > 
> > > > > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control 
> > > > > 
> > > > > already starts working with 'acpi_osi=Linux' option.
> > > > > 
> > > > > cat /proc/cmdline gives , 
> > > > > 
> > > > > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> > > > > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux 
> > > > > 
> > > > > 
> > > > > Thanks , 
> > > > > 
> > > > > Pradeep Subrahmanion
> > > > > 
> > > > 
> > > > OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
> > > > think the hotkey of backlight control only works with acpi_osi=Linux ?
> > > > 
> > 
> > Does your backlight control still work if you remove acpi_osi=Linux ?
> 
>    If I remove acpi_osi=Linux , the hot key control stops working .
> 

What is the preload OS in your machine when you bought it? Windows XP,
Vista or Windows 7?


thanks
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 2429 bytes --]

On Thu, 2012-03-22 at 11:25 +0800, joeyli wrote:
> 於 四，2012-03-22 於 08:03 +0530，Pradeep Subrahmanion 提到：
> > On Thu, 2012-03-22 at 09:33 +0800, joeyli wrote:
> > > 於 四，2012-03-22 於 00:39 +0530，Pradeep Subrahmanion 提到：
> > > > > This new patch should remove acpi_video0 interface on your machine.
> > > > > Please kindly provide your dmidecode:
> > > > >  dmidecode > dmidecode.log
> > > > >
> > > > > And, 
> > > > > please make should the patch really applied, you can do a bit change on
> > > > > pr_info message by yourself.
> > > > 
> > > >    Sorry . I think there was some mistake . I tried the patch again. Now
> > > > I see only intel_backlight inside /sys/class/backlight. There is no
> > > > acer-wmi interface . Is this the expected behavior ? . Or am I missing
> > > > anything ?
> > > > 
> > > 
> > > Yes, this is the expected behavior! But, now I doubt your issue was
> > > workaround by acpi_osi=Linux but not intel_backlight.
> > >
> > 
> > > > 
> > > > 
> > > > > 
> > > > > > echo 5 > /sys/class/backlight/acpi_video0/brightness 
> > > > > > echo 5 > /sys/class/backlight/intel_backlight/brightness
> > > > > > 
> > > > > > But it doesn't make any change . 
> > > > > > 
> > > > > > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control 
> > > > > > 
> > > > > > already starts working with 'acpi_osi=Linux' option.
> > > > > > 
> > > > > > cat /proc/cmdline gives , 
> > > > > > 
> > > > > > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> > > > > > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux 
> > > > > > 
> > > > > > 
> > > > > > Thanks , 
> > > > > > 
> > > > > > Pradeep Subrahmanion
> > > > > > 
> > > > > 
> > > > > OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
> > > > > think the hotkey of backlight control only works with acpi_osi=Linux ?
> > > > > 
> > > 
> > > Does your backlight control still work if you remove acpi_osi=Linux ?
> > 
> >    If I remove acpi_osi=Linux , the hot key control stops working .
> > 
> 
> What is the preload OS in your machine when you bought it? Windows XP,
> Vista or Windows 7?
  
   It was Windows XP.

> 
> 
> thanks
> Joey Lee
> 

Thanks , 

Pradeep Subrahmanion


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 2783 bytes --]

於 四，2012-03-22 於 09:02 +0530，Pradeep Subrahmanion 提到：
> On Thu, 2012-03-22 at 11:25 +0800, joeyli wrote:
> > 於 四，2012-03-22 於 08:03 +0530，Pradeep Subrahmanion 提到：
> > > On Thu, 2012-03-22 at 09:33 +0800, joeyli wrote:
> > > > 於 四，2012-03-22 於 00:39 +0530，Pradeep Subrahmanion 提到：
> > > > > > This new patch should remove acpi_video0 interface on your machine.
> > > > > > Please kindly provide your dmidecode:
> > > > > >  dmidecode > dmidecode.log
> > > > > >
> > > > > > And, 
> > > > > > please make should the patch really applied, you can do a bit change on
> > > > > > pr_info message by yourself.
> > > > > 
> > > > >    Sorry . I think there was some mistake . I tried the patch again. Now
> > > > > I see only intel_backlight inside /sys/class/backlight. There is no
> > > > > acer-wmi interface . Is this the expected behavior ? . Or am I missing
> > > > > anything ?
> > > > > 
> > > > 
> > > > Yes, this is the expected behavior! But, now I doubt your issue was
> > > > workaround by acpi_osi=Linux but not intel_backlight.
> > > >
> > > 
> > > > > 
> > > > > 
> > > > > > 
> > > > > > > echo 5 > /sys/class/backlight/acpi_video0/brightness 
> > > > > > > echo 5 > /sys/class/backlight/intel_backlight/brightness
> > > > > > > 
> > > > > > > But it doesn't make any change . 
> > > > > > > 
> > > > > > > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control 
> > > > > > > 
> > > > > > > already starts working with 'acpi_osi=Linux' option.
> > > > > > > 
> > > > > > > cat /proc/cmdline gives , 
> > > > > > > 
> > > > > > > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> > > > > > > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux 
> > > > > > > 
> > > > > > > 
> > > > > > > Thanks , 
> > > > > > > 
> > > > > > > Pradeep Subrahmanion
> > > > > > > 
> > > > > > 
> > > > > > OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
> > > > > > think the hotkey of backlight control only works with acpi_osi=Linux ?
> > > > > > 
> > > > 
> > > > Does your backlight control still work if you remove acpi_osi=Linux ?
> > > 
> > >    If I remove acpi_osi=Linux , the hot key control stops working .
> > > 
> > 
> > What is the preload OS in your machine when you bought it? Windows XP,
> > Vista or Windows 7?
>   
>    It was Windows XP.
> 

The WDDM driver didn't support by Windows XP, the brightness control on
XP should works with _BCM or OpRegion.

Wonder how does brightness control work on XP with your machine.

I will dig more in your dsdt...


Thanks
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

From acer acpi ,I came to know that the 4730 series uses new wmi interface .

http://code.google.com/p/aceracpi/wiki/SupportedHardware

Thanks ,

Pradeep Subrahmanion

On Thu, Mar 22, 2012 at 9:24 AM, joeyli <jlee@suse.com> wrote:
> ©ó ¥|¡A2012-03-22 ©ó 09:02 +0530¡APradeep Subrahmanion ´£¨ì¡G
>> On Thu, 2012-03-22 at 11:25 +0800, joeyli wrote:
>> > ©ó ¥|¡A2012-03-22 ©ó 08:03 +0530¡APradeep Subrahmanion ´£¨ì¡G
>> > > On Thu, 2012-03-22 at 09:33 +0800, joeyli wrote:
>> > > > ©ó ¥|¡A2012-03-22 ©ó 00:39 +0530¡APradeep Subrahmanion ´£¨ì¡G
>> > > > > > This new patch should remove acpi_video0 interface on your machine.
>> > > > > > Please kindly provide your dmidecode:
>> > > > > >  dmidecode > dmidecode.log
>> > > > > >
>> > > > > > And,
>> > > > > > please make should the patch really applied, you can do a bit change on
>> > > > > > pr_info message by yourself.
>> > > > >
>> > > > >    Sorry . I think there was some mistake . I tried the patch again. Now
>> > > > > I see only intel_backlight inside /sys/class/backlight. There is no
>> > > > > acer-wmi interface . Is this the expected behavior ? . Or am I missing
>> > > > > anything ?
>> > > > >
>> > > >
>> > > > Yes, this is the expected behavior! But, now I doubt your issue was
>> > > > workaround by acpi_osi=Linux but not intel_backlight.
>> > > >
>> > >
>> > > > >
>> > > > >
>> > > > > >
>> > > > > > > echo 5 > /sys/class/backlight/acpi_video0/brightness
>> > > > > > > echo 5 > /sys/class/backlight/intel_backlight/brightness
>> > > > > > >
>> > > > > > > But it doesn't make any change .
>> > > > > > >
>> > > > > > > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control
>> > > > > > >
>> > > > > > > already starts working with 'acpi_osi=Linux' option.
>> > > > > > >
>> > > > > > > cat /proc/cmdline gives ,
>> > > > > > >
>> > > > > > > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
>> > > > > > > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux
>> > > > > > >
>> > > > > > >
>> > > > > > > Thanks ,
>> > > > > > >
>> > > > > > > Pradeep Subrahmanion
>> > > > > > >
>> > > > > >
>> > > > > > OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
>> > > > > > think the hotkey of backlight control only works with acpi_osi=Linux ?
>> > > > > >
>> > > >
>> > > > Does your backlight control still work if you remove acpi_osi=Linux ?
>> > >
>> > >    If I remove acpi_osi=Linux , the hot key control stops working .
>> > >
>> >
>> > What is the preload OS in your machine when you bought it? Windows XP,
>> > Vista or Windows 7?
>>
>>    It was Windows XP.
>>
>
> The WDDM driver didn't support by Windows XP, the brightness control on
> XP should works with _BCM or OpRegion.
>
> Wonder how does brightness control work on XP with your machine.
>
> I will dig more in your dsdt...
>
>
> Thanks
> Joey Lee
>

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 3447 bytes --]

於 四，2012-03-22 於 11:26 +0530，Pradeep Subrahmanion 提到：
> >From acer acpi ,I came to know that the 4730 series uses new wmi interface .
> 
> http://code.google.com/p/aceracpi/wiki/SupportedHardware
> 

I am not sure what is the WMIDv2, but it's not the current WMI v2 in
acer-wmi driver.

> Thanks ,
> 
> Pradeep Subrahmanion
> 
> On Thu, Mar 22, 2012 at 9:24 AM, joeyli <jlee@suse.com> wrote:
> > 於 四，2012-03-22 於 09:02 +0530，Pradeep Subrahmanion 提到：
> >> On Thu, 2012-03-22 at 11:25 +0800, joeyli wrote:
> >> > 於 四，2012-03-22 於 08:03 +0530，Pradeep Subrahmanion 提到：
> >> > > On Thu, 2012-03-22 at 09:33 +0800, joeyli wrote:
> >> > > > 於 四，2012-03-22 於 00:39 +0530，Pradeep Subrahmanion 提到：
> >> > > > > > This new patch should remove acpi_video0 interface on your machine.
> >> > > > > > Please kindly provide your dmidecode:
> >> > > > > >  dmidecode > dmidecode.log
> >> > > > > >
> >> > > > > > And,
> >> > > > > > please make should the patch really applied, you can do a bit change on
> >> > > > > > pr_info message by yourself.
> >> > > > >
> >> > > > >    Sorry . I think there was some mistake . I tried the patch again. Now
> >> > > > > I see only intel_backlight inside /sys/class/backlight. There is no
> >> > > > > acer-wmi interface . Is this the expected behavior ? . Or am I missing
> >> > > > > anything ?
> >> > > > >
> >> > > >
> >> > > > Yes, this is the expected behavior! But, now I doubt your issue was
> >> > > > workaround by acpi_osi=Linux but not intel_backlight.
> >> > > >
> >> > >
> >> > > > >
> >> > > > >
> >> > > > > >
> >> > > > > > > echo 5 > /sys/class/backlight/acpi_video0/brightness
> >> > > > > > > echo 5 > /sys/class/backlight/intel_backlight/brightness
> >> > > > > > >
> >> > > > > > > But it doesn't make any change .
> >> > > > > > >
> >> > > > > > > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control
> >> > > > > > >
> >> > > > > > > already starts working with 'acpi_osi=Linux' option.
> >> > > > > > >
> >> > > > > > > cat /proc/cmdline gives ,
> >> > > > > > >
> >> > > > > > > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> >> > > > > > > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux
> >> > > > > > >
> >> > > > > > >
> >> > > > > > > Thanks ,
> >> > > > > > >
> >> > > > > > > Pradeep Subrahmanion
> >> > > > > > >
> >> > > > > >
> >> > > > > > OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
> >> > > > > > think the hotkey of backlight control only works with acpi_osi=Linux ?
> >> > > > > >
> >> > > >
> >> > > > Does your backlight control still work if you remove acpi_osi=Linux ?
> >> > >
> >> > >    If I remove acpi_osi=Linux , the hot key control stops working .
> >> > >
> >> >
> >> > What is the preload OS in your machine when you bought it? Windows XP,
> >> > Vista or Windows 7?
> >>
> >>    It was Windows XP.
> >>
> >
> > The WDDM driver didn't support by Windows XP, the brightness control on
> > XP should works with _BCM or OpRegion.
> >
> > Wonder how does brightness control work on XP with your machine.
> >
> > I will dig more in your dsdt...
> >
> >

Please kindly try acpi_osi="!Windows 2006", I think it also works to
you.


Thanks
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 3819 bytes --]

On Thu, 2012-03-22 at 17:34 +0800, joeyli wrote:
> 於 四，2012-03-22 於 11:26 +0530，Pradeep Subrahmanion 提到：
> > >From acer acpi ,I came to know that the 4730 series uses new wmi interface .
> > 
> > http://code.google.com/p/aceracpi/wiki/SupportedHardware
> > 
> 
> I am not sure what is the WMIDv2, but it's not the current WMI v2 in
> acer-wmi driver.
> 
> > Thanks ,
> > 
> > Pradeep Subrahmanion
> > 
> > On Thu, Mar 22, 2012 at 9:24 AM, joeyli <jlee@suse.com> wrote:
> > > 於 四，2012-03-22 於 09:02 +0530，Pradeep Subrahmanion 提到：
> > >> On Thu, 2012-03-22 at 11:25 +0800, joeyli wrote:
> > >> > 於 四，2012-03-22 於 08:03 +0530，Pradeep Subrahmanion 提到：
> > >> > > On Thu, 2012-03-22 at 09:33 +0800, joeyli wrote:
> > >> > > > 於 四，2012-03-22 於 00:39 +0530，Pradeep Subrahmanion 提到：
> > >> > > > > > This new patch should remove acpi_video0 interface on your machine.
> > >> > > > > > Please kindly provide your dmidecode:
> > >> > > > > >  dmidecode > dmidecode.log
> > >> > > > > >
> > >> > > > > > And,
> > >> > > > > > please make should the patch really applied, you can do a bit change on
> > >> > > > > > pr_info message by yourself.
> > >> > > > >
> > >> > > > >    Sorry . I think there was some mistake . I tried the patch again. Now
> > >> > > > > I see only intel_backlight inside /sys/class/backlight. There is no
> > >> > > > > acer-wmi interface . Is this the expected behavior ? . Or am I missing
> > >> > > > > anything ?
> > >> > > > >
> > >> > > >
> > >> > > > Yes, this is the expected behavior! But, now I doubt your issue was
> > >> > > > workaround by acpi_osi=Linux but not intel_backlight.
> > >> > > >
> > >> > >
> > >> > > > >
> > >> > > > >
> > >> > > > > >
> > >> > > > > > > echo 5 > /sys/class/backlight/acpi_video0/brightness
> > >> > > > > > > echo 5 > /sys/class/backlight/intel_backlight/brightness
> > >> > > > > > >
> > >> > > > > > > But it doesn't make any change .
> > >> > > > > > >
> > >> > > > > > > In my case  , 'acpi_backlight = vendor' does not make any difference since the hot key control
> > >> > > > > > >
> > >> > > > > > > already starts working with 'acpi_osi=Linux' option.
> > >> > > > > > >
> > >> > > > > > > cat /proc/cmdline gives ,
> > >> > > > > > >
> > >> > > > > > > BOOT_IMAGE=/boot/vmlinuz-3.3.0+
> > >> > > > > > > root=UUIDð197a59-c067-4fd8-ad90-c4d721816077 ro acpi_osi=Linux
> > >> > > > > > >
> > >> > > > > > >
> > >> > > > > > > Thanks ,
> > >> > > > > > >
> > >> > > > > > > Pradeep Subrahmanion
> > >> > > > > > >
> > >> > > > > >
> > >> > > > > > OK, that's more clearly, please remove acpi_osi=Linux then re-test, I
> > >> > > > > > think the hotkey of backlight control only works with acpi_osi=Linux ?
> > >> > > > > >
> > >> > > >
> > >> > > > Does your backlight control still work if you remove acpi_osi=Linux ?
> > >> > >
> > >> > >    If I remove acpi_osi=Linux , the hot key control stops working .
> > >> > >
> > >> >
> > >> > What is the preload OS in your machine when you bought it? Windows XP,
> > >> > Vista or Windows 7?
> > >>
> > >>    It was Windows XP.
> > >>
> > >
> > > The WDDM driver didn't support by Windows XP, the brightness control on
> > > XP should works with _BCM or OpRegion.
> > >
> > > Wonder how does brightness control work on XP with your machine.
> > >
> > > I will dig more in your dsdt...
> > >
> > >
> 
> Please kindly try acpi_osi="!Windows 2006", I think it also works to
> you.

   I tried giving this option . It gives me a blank screen while
booting. Hot keys are not working .


> 
> 
> Thanks
> Joey Lee
> 


Regards, 

Pradeep Subrahmanion.


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

On Wed, 2012-03-21 at 11:00 +0800, joeyli wrote:
> think the hotkey of backlight control only works with acpi_osi=Linux ?

yes , hot key control only works with this option.Any ideas about where
the hot key events gets handled ? I tried logging inside
'acpi_video_device_notify' method in video.c . But the control does not
seem to reach here . 

Thanks, 

Pradeep Subrahmanion

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

於 五，2012-03-23 於 09:06 +0530，Pradeep Subrahmanion 提到：
> On Wed, 2012-03-21 at 11:00 +0800, joeyli wrote:
> > think the hotkey of backlight control only works with acpi_osi=Linux ?
> 
> yes , hot key control only works with this option.Any ideas about where
> the hot key events gets handled ? I tried logging inside
> 'acpi_video_device_notify' method in video.c . But the control does not
> seem to reach here . 
> 
> Thanks, 
> 
> Pradeep Subrahmanion

Hotkey change status is through _Q11 and _Q12 event but not wmi:


    Method (_Q11, 0, NotSerialized)             /* Brightness down */
    {
        If (LGreaterEqual (OSYS, 0x07D6))       /* Vista or later */
        {
            If (LEqual (OBV, 0xFF))
            {
                Notify (^^^PEGP.VGA.LCD, 0x87)
            }
            Else
            {
                Notify (^^^OVGA.DD03, 0x87)
            }
        }
        Else                                    /* 0x07D1 (XP) or 0x03E8 (Linux) */
        {
            ^^^OVGA.AINT (One, BRTS)		/* access AINT, it touch BCLP register */
            If (LEqual (^^^WMID.BAEF, One))
            {
                Store (BRTS, Local1)
                Store (^^^WMID.LBL0, Local2)
                Add (Local2, Local1, Local2)
                Store (Local2, ^^^WMID.NTDC)
                Notify (WMID, 0x80)
            }
        }
    }

Method (AINT, 2, NotSerialized)
{
...
    Else
    {
        If (LEqual (Arg0, One))         /* Linux or XP */
        {
            Add (Arg1, One, Arg1)
            Store (Divide (Multiply (Arg1, 0xFF), 0x0A, ), BCLP)
            Or (BCLP, 0x80000000, BCLP)		/* touch BCLP register */
            Store (0x02, ASLC)
        }


That's why I said acpi_osi"!Windows 2006" should also works to you. Unfortunately,
there have something wrong in video driver for support this machine on XP mode.


thanks a lot!
Joey Lee

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

On Thu, 2012-03-15 at 16:05 +0800, joeyli wrote:
> Hi Pradeep, 
> 
> 於 三，2012-03-14 於 11:47 +0530，Pradeep Subrahmanion 提到：
> > On Wed, Mar 14, 2012 at 11:21 AM, joeyli <jlee@suse.com> wrote:
> > > 於 三，2012-03-14 於 08:13 +0530，Pradeep Subrahmanion 提到：
> > >> Hi Joey ,
> > >>
> > >> > Per my understood, EC firmware should change brightness but didn't do
> > >> > that, another
> > >> > way is touch i915 register in _BCM.
> > >>
> > >>   how do we do this ? you mean change the _BCM implementation ?
> > >
> > > "BIOS guy" should do something like this:
> > >
> > >  Method (AINT, 2, NotSerialized)
> > > {
> > > ...
> > >        If (LEqual (Arg0, One))
> > >        {
> > >            Store (Divide (Multiply (Arg1, 0xFF), 0x64, ), BCLP)
> > >            Or (BCLP, 0x80000000, BCLP)         <== touch BCLP register
> > >            Store (0x02, ASLC)
> > >        }
> > >
> > >    Method (_BCM, 1, NotSerialized)
> > >    {
> > >        If (LAnd (LGreaterEqual (Arg0, Zero), LLessEqual (Arg0, 0x64)))
> > >        {
> > >            AINT (One, Arg0)     <== call AINT method
> > >            Store (Arg0, BRTL)
> > >        }
> > >    }
> > >
> > >
> > > Just for reference, they should do that when EC didn't wire to
> > > backlight.
> > >
> > >> >
> > >> > Acer machine provide a broken _BCM implementation and they didn't test
> > >> > it.
> > >> >
> > >> > > > > By ' ACPI interface' , I mean 'acpi_video0' inside the
> > >> > > > > /sys/class/backlight. I havn't tried the /sys/class/backlight interface
> > >> > > > > directly . I will try that also.
> > >> > > >
> > >> > > > So writing values into /sys/class/backlight/acpi_video0/brightness does
> > >> > > > nothing?
> > >> > >
> > >> > >
> > >> > > No change in value when writing
> > >> > > to /sys/class/backlight/acpi_video0/brightness.
> > >> > >
> > >> > > Another thing is that when i did boot with acpi_backlight = 'acer_wmi' ,
> > >> > > in new kernel (3.3.0-rc7) , it shows following messages ,
> > >> > >
> > >> > > [    8.350825] wmi: Mapper loaded
> > >> > > [   10.363975] acer_wmi: Acer Laptop ACPI-WMI Extras
> > >> > > [   10.396186] acer_wmi: Function bitmap for Communication Device: 0x91
> > >> > > [   10.396385] acer_wmi: Brightness must be controlled by generic video
> > >> > > driver
> > >> > >
> > >> > > Also there was no interface inside /sys/class/backlight for acer_wmi.
> > >> > >
> > >> >
> > >> > Yes, acer_wmi support backlight control with AMW0 interface, your
> > >> > machine didn't have AMW0 interface.
> > >> >
> > >> > Normally, backlight should control by standard acpi interface.
> > >> >
> > >> > > I also tried writing directly to Embedded controller register .But no
> > >> > > change.
> > >> >
> > >> > The machine has broken _BCM method, because EC should do something after
> > >> > _BCM changed EC register.
> > >>
> > >> Thanks ,
> > >>
> > >> Pradeep Subrahmanion
> > >
> > > Why they didn't find _BCM not work?
> > >
> > > My guess is:
> > >
> > > Because the backlight control is through WDDM driver on Windows platform
> > > but not through standard ACPI method _BCM. They only test Windows
> > > platform, so, they didn't find _BCM broken.
> > >
> > > And, they also didn't really follow Microsoft WDDM spec:
> > >
> > >  http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx
> > >
> > > Per spec,
> > > ODM should keep _BCM works fine for any other OS didn't support WDDM
> > > driver, but they didn't.
> > >
> > > At last year, I told Acer PM one time for this issue, they said will
> > > check but finally didn't response me.
> > >
> > 
> > >
> > > Thanks
> > > Joey Lee
> > >
> > 
> > So touching the PCI LBB register is the only feasible solution now
> > (even though it may not be a clean  method) ?
> > 
> > Thanks,
> > Pradeep Subrahmanion
> 
> That will be better leave LBB register only touched by i915 driver.
> 
> If 'acpi_backlight=vendor' works to you, maybe we can add a quirk to
> video_detect.c. 
> You can try the following patch.

Thanks . I tried your patch .acpi_backlight=vendor allows me to control
brightness with hot key.But there are problems with it like increasing
brightness after  maximum level causes blank screen.So I am trying it
sort it out.
 
Thank you , 

Pradeep Subrahmanion

> 
> 
> Thanks a lot!
> Joey Lee
> 
> 
> >From 038bd3c4e53b7195f34e9d46c999b8dcb279da5e Mon Sep 17 00:00:00 2001
> From: "Lee, Chun-Yi" <jlee@suse.com>
> Date: Thu, 15 Mar 2012 16:03:45 +0800
> Subject: [PATCH] acer-wmi: Add quirk table for video backlight vendor mode
> 
> Add quirk table for video backlight vendor mode
> 
> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> ---
>  drivers/acpi/video_detect.c |   27 +++++++++++++++++++++++++++
>  1 files changed, 27 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index f3f0fe7..acb15d6 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -132,6 +132,32 @@ find_video(acpi_handle handle, u32 lvl, void *context, void **rv)
>  	return AE_OK;
>  }
>  
> +static int video_set_backlight_vendor(const struct dmi_system_id *d)
> +{
> +	acpi_video_support |= ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
> +	return 0;
> +}
> +
> +static const struct dmi_system_id video_vendor_dmi_table[] = {
> +	{
> +	 .callback = video_set_backlight_vendor,
> +	 .ident = "Acer Aspire 4736",
> +	 .matches = {
> +		DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
> +		},
> +	},
> +	{
> +	 .callback = video_set_backlight_vendor,
> +	 .ident = "Acer TravelMate 4750",
> +	 .matches = {
> +		DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
> +		},
> +	},
> +	{}
> +};
> +
>  /*
>   * Returns the video capabilities of a specific ACPI graphics device
>   *
> @@ -164,6 +190,7 @@ long acpi_video_get_capabilities(acpi_handle graphics_handle)
>  		 *		ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
>  		 *}
>  		 */
> +		dmi_check_system(video_vendor_dmi_table);
>  	} else {
>  		status = acpi_bus_get_device(graphics_handle, &tmp_dev);
>  		if (ACPI_FAILURE(status)) {

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

I tried giving acpi_backlight = vendor . In that case hot key for
brightness control is working. But i think  , it is not calculating
the correct value for brightness because increasing brightness after
maximum level gives blank screen .

 I also had tried 'acpi_backlight = acer_wmi' as the boot parameter
earlier . In that case  , the driver cannot find any acpi_wmi device
(showed error while booting).

By ' ACPI interface' , I mean 'acpi_video0' inside the
/sys/class/backlight. I havn't tried the /sys/class/backlight
interface directly . I will try that also.

Thanks ,

Pradeep Subrahmanion.

On Tue, Mar 13, 2012 at 6:17 PM, Matthew Garrett <mjg@redhat.com> wrote:
>
> On Tue, Mar 13, 2012 at 08:09:52AM -0400, Pradeep Subrahmanion wrote:
> > Before taking this approach , I had a look at the WMI interface.But I found from acer-acpi site that , the 4730 series
> > is using new WMI interface which needs to be reverse engineered.
> > As far as  acpi interface is concerned , by default it is not at all causing any change in brightness.
> > When 'acpi_osi=Linux' was added to the boot grub config , the brightness control with hot key started to work .
> > But it was not changing to correct values. Increasing brightness after maximum level gives blank screen.
>
> That page was last updated in 2009. Have you tried the current acer-wmi
> code? You'd probably need to pass backlight=vendor if there's a
> non-working ACPI interface.
>
> When you say the ACPI interface doesn't work, what do you mean? Have you
> tried using the /sys/class/backlight interface directly?
>
> --
> Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[Joe Perches]

On Mon, 2012-03-12 at 23:12 -0400, Pradeep Subrahmanion wrote:
> Hi ,

Hello yourself.

Just some trivial comments:

> diff --git a/drivers/video/backlight/acer4736_bl.c b/drivers/video/backlight/acer4736_bl.c
[]
Please add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any include

> +static int update_brightness(struct backlight_device *bd)
> +{
> +	u8 intensity = bd->props.brightness;
> +	if (intensity > max_brightness) {
> +		printk(KERN_INFO "Acer4736_bl: Invalid parameter. Maximum value is %d"
> +		, max_brightness);

Beginning a line with a comma is not at all common and
should be avoided.  printks need newline terminations,
and this would be better as pr_info.  Maybe:

		pr_info("Invalid parameter %u: Maximum allowed value: %u\n",
			intensity, max_brightness);

> +	printk(KERN_INFO "Loading Acer 4736 backlight driver\n");

	pr_info("Loading backlight driver\n");

[PATCH] Added backlight driver for Acer Aspire 4736

[Pradeep Subrahmanion]

Hi ,

  Brightness control was not  working on Acer Aspire 4736 using default ACPI interface.  acer-acpi also do not support 4730 series since it uses new WMI interface.
This driver adds brightness control by accessing the LBB PCI configuration register. This approach may also work on other laptops in 4730 series .But currently ,  it is only tested  for 
Aspire 4736. 

From 03dbda16c90278aa1c088e5208bd99ac3c76f911 Mon Sep 17 00:00:00 2001
From: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>
Date: Mon, 12 Mar 2012 23:08:20 -0400
Subject: [PATCH] Added backlight driver for Acer Aspire 4736

Added backlight driver for Acer Aspire 4736

Signed-off-by: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>
---
 drivers/video/backlight/acer4736_bl.c |  110 +++++++++++++++++++++++++++++++++
 1 files changed, 110 insertions(+), 0 deletions(-)
 create mode 100644 drivers/video/backlight/acer4736_bl.c

diff --git a/drivers/video/backlight/acer4736_bl.c b/drivers/video/backlight/acer4736_bl.c
new file mode 100644
index 0000000..6fe2937
--- /dev/null
+++ b/drivers/video/backlight/acer4736_bl.c
@@ -0,0 +1,110 @@
+/*
+ * Backlight driver for Acer Aspire 4736
+ *
+ * Copyright (C) Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This driver uses LBB PCI configuration register to change the
+ * backlight brightness.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/backlight.h>
+#include <linux/err.h>
+#include <linux/dmi.h>
+#include <linux/io.h>
+#include <linux/pci.h>
+
+static u8 max_brightness = 0xFF;
+static u8 lbb_offset =  0xF4;
+static unsigned int device_id = 0x2a42;
+static unsigned int vendor_id = 0x8086;
+
+struct backlight_device *acer_backlight_device;
+struct pci_dev *pdev;
+
+static int acer_dmi_match(const struct dmi_system_id *id)
+{
+	printk(KERN_INFO "acer4736_bl: %s detected\n", id->ident);
+	return 1;
+}
+
+static const struct dmi_system_id __initdata acer_device_table[] = {
+{
+		.callback	= acer_dmi_match,
+		.ident		= "Aspire 4736",
+		.matches	= {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
+		},
+	},
+	{}
+};
+static int read_brightness(struct backlight_device *bd)
+{
+	u8 result;
+	pci_read_config_byte(pdev, lbb_offset, &result);
+	return result;
+}
+
+static int update_brightness(struct backlight_device *bd)
+{
+	u8 intensity = bd->props.brightness;
+	if (intensity > max_brightness) {
+		printk(KERN_INFO "Acer4736_bl: Invalid parameter. Maximum value is %d"
+		, max_brightness);
+		return -1;
+	}
+	pci_write_config_byte(pdev, lbb_offset, intensity);
+	return 0;
+}
+static const struct  backlight_ops acer_backlight_ops = {
+	.get_brightness = read_brightness,
+	.update_status  = update_brightness,
+};
+
+static int __init acer4736_bl_init(void)
+{
+	struct backlight_properties props;
+	if (!dmi_check_system(acer_device_table))
+		return -ENODEV;
+
+	pdev = pci_get_device(vendor_id, device_id, NULL);
+
+	if (!pdev)
+		return -ENODEV;
+
+	printk(KERN_INFO "Loading Acer 4736 backlight driver\n");
+	memset(&props, 0, sizeof(struct backlight_properties));
+	props.type = BACKLIGHT_RAW;
+	props.max_brightness = max_brightness;
+
+	acer_backlight_device = backlight_device_register("acer_backlight",
+		NULL, NULL, &acer_backlight_ops, &props);
+	acer_backlight_device->props.max_brightness = max_brightness;
+	acer_backlight_device->props.brightness  +		read_brightness(acer_backlight_device);
+	backlight_update_status(acer_backlight_device);
+
+	return 0;
+}
+
+static void __exit acer4736_bl_exit(void)
+{
+	pci_dev_put(pdev);
+	backlight_device_unregister(acer_backlight_device);
+}
+
+module_init(acer4736_bl_init);
+module_exit(acer4736_bl_exit);
+
+MODULE_AUTHOR("Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>");
+MODULE_DESCRIPTION("Acer Aspire 4736 Backlight Driver");
+MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(dmi, acer_device_table);
-- 
1.7.2.5



------

Thanks , 

Pradeep Subrahmanion

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

Hi Pradeep, 

於 日，2012-03-11 於 19:42 +0000，Florian Tobias Schandinat 提到：
> Hi,
> 
> On 03/11/2012 06:21 PM, Pradeep Subrahmanion wrote:
> > Hi ,
> > 
> >          Brightness control was not  working on Acer Aspire 4736 using
> > default ACPI interface.  acer-acpi also do not support 4730 series since
> > it uses new WMI interface.
> > This driver adds brightness control by accessing the LBB PCI
> > configuration register. This approach may also work on other laptops in
> > 4730 series .But currently ,  it is only tested  for 
> > Aspire 4736.  
> > 

Pleae check does there have following interface?

/sys/class/backlight/intel_backlight

And,
did you try kernel parameter "acpi_backlight=vendor", does it work to
you?

Please attach acpidump: acpidump > acpidump.dat


Thanks
Joey Lee

> > From 893031c1e9bdefd9642b98825062b5df98af0d77 Mon Sep 17 00:00:00 2001
> > From: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> > <mailto:subrahmanion.pradeep@gmail.com>>
> > Date: Sun, 11 Mar 2012 23:11:23 -0400
> > Subject: [PATCH] Added backlight driver for Acer Aspire 4736
> > 
> 
> the commit message should be here, I think.
> 
> > 
> > Signed-off-by: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> > <mailto:subrahmanion.pradeep@gmail.com>>
> 
> Please resend this email in the correct format: As you can see in my
> email the text version of your patch is severely screwed up and nobody
> wants to even try converting a HTML format to a proper patch again,
> probably most people won't even receive an email that has a HTML part as
> their spam filter are going to handle it as spam. git send-email will
> take care of it for you if you configure it for your account.
> You should also cc Andrew Morton <akpm@linux-foundation.org> as he's the
> one who handles backlight patches at the moment.
> 
> 
> Best regards,
> 
> Florian Tobias Schandinat
> 
> > ---
> >  drivers/video/backlight/acer4736_bl.c |  110
> > +++++++++++++++++++++++++++++++++
> >  1 files changed, 110 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/video/backlight/acer4736_bl.c
> > 
> > diff --git a/drivers/video/backlight/acer4736_bl.c
> > b/drivers/video/backlight/acer4736_bl.c
> > new file mode 100644
> > index 0000000..6fe2937
> > --- /dev/null
> > +++ b/drivers/video/backlight/acer4736_bl.c
> > @@ -0,0 +1,110 @@
> > +/*
> > + * Backlight driver for Acer Aspire 4736
> > + *
> > + * Copyright (C) Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> > <mailto:subrahmanion.pradeep@gmail.com>>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + * This driver uses LBB PCI configuration register to change the
> > + * backlight brightness.
> > + *
> > + */
> > +
> > +#include <linux/module.h>
> > +#include <linux/kernel.h>
> > +#include <linux/init.h>
> > +#include <linux/backlight.h>
> > +#include <linux/err.h>
> > +#include <linux/dmi.h>
> > +#include <linux/io.h>
> > +#include <linux/pci.h>
> > +
> > +static u8 max_brightness = 0xFF;
> > +static u8 lbb_offset =  0xF4;
> > +static unsigned int device_id = 0x2a42;
> > +static unsigned int vendor_id = 0x8086;
> > +
> > +struct backlight_device *acer_backlight_device;
> > +struct pci_dev *pdev;
> > +
> > +static int acer_dmi_match(const struct dmi_system_id *id)
> > +{
> > + printk(KERN_INFO "acer4736_bl: %s detected\n", id->ident);
> > + return 1;
> > +}
> > +
> > +static const struct dmi_system_id __initdata acer_device_table[] = {
> > +{
> > + .callback = acer_dmi_match,
> > + .ident = "Aspire 4736",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
> > + },
> > + },
> > + {}
> > +};
> > +static int read_brightness(struct backlight_device *bd)
> > +{
> > + u8 result;
> > + pci_read_config_byte(pdev, lbb_offset, &result);
> > + return result;
> > +}
> > +
> > +static int update_brightness(struct backlight_device *bd)
> > +{
> > + u8 intensity = bd->props.brightness;
> > + if (intensity > max_brightness) {
> > + printk(KERN_INFO "Acer4736_bl: Invalid parameter. Maximum value is %d"
> > + , max_brightness);
> > + return -1;
> > + }
> > + pci_write_config_byte(pdev, lbb_offset, intensity);
> > + return 0;
> > +}
> > +static const struct  backlight_ops acer_backlight_ops = {
> > + .get_brightness = read_brightness,
> > + .update_status  = update_brightness,
> > +};
> > +
> > +static int __init acer4736_bl_init(void)
> > +{
> > + struct backlight_properties props;
> > + if (!dmi_check_system(acer_device_table))
> > + return -ENODEV;
> > +
> > + pdev = pci_get_device(vendor_id, device_id, NULL);
> > +
> > + if (!pdev)
> > + return -ENODEV;
> > +
> > + printk(KERN_INFO "Loading Acer 4736 backlight driver\n");
> > + memset(&props, 0, sizeof(struct backlight_properties));
> > + props.type = BACKLIGHT_RAW;
> > + props.max_brightness = max_brightness;
> > +
> > + acer_backlight_device = backlight_device_register("acer_backlight",
> > + NULL, NULL, &acer_backlight_ops, &props);
> > + acer_backlight_device->props.max_brightness = max_brightness;
> > + acer_backlight_device->props.brightness  > > + read_brightness(acer_backlight_device);
> > + backlight_update_status(acer_backlight_device);
> > +
> > + return 0;
> > +}
> > +
> > +static void __exit acer4736_bl_exit(void)
> > +{
> > + pci_dev_put(pdev);
> > + backlight_device_unregister(acer_backlight_device);
> > +}
> > +
> > +module_init(acer4736_bl_init);
> > +module_exit(acer4736_bl_exit);
> > +
> > +MODULE_AUTHOR("Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> > <mailto:subrahmanion.pradeep@gmail.com>>");
> > +MODULE_DESCRIPTION("Acer Aspire 4736 Backlight Driver");
> > +MODULE_LICENSE("GPL");
> > +MODULE_DEVICE_TABLE(dmi, acer_device_table);
> > -- 
> > 1.7.2.5
> > 
> > -------------  
> > 
> > Pradeep Subrahmanion
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: [PATCH] Added backlight driver for Acer Aspire 4736

[joeyli]

Hi Pradeep, 

I think the following command doesn't work to you:

echo 5 > /sys/class/backlight/acpi_video0/brightness

It the above command not work, that means EC didn't change backlight
value:

Method (_BCM, 1, NotSerialized)
{
    Divide (Arg0, 0x0A, Local0, Local1)
    Decrement (Local1)
    Store (Local1, ^^^^LPC.EC0.BRTS)	<== write backlight value to EC register
}

Per my understood, EC firmware should change brightness but didn't do that, another
way is touch i915 register in _BCM.

Acer machine provide a broken _BCM implementation and they didn't test it.


Thanks a lot!
Joey Lee

於 二，2012-03-13 於 09:12 -0400，Pradeep Subrahmanion 提到：
> Hi Joey, 
> 
> yes , /sys/class/backlight/intel_backlight exists . I tried giving
> acpi_backlight=vendor in grub config.Hot keys works like earlier.But
> increasing brightness after maximum levels give blank screen(like
> earlier). 
> 
> I have attached acpidump.
>  
> ----
> Thanks  , 
>  
> Pradeep Subrahmanion
> 
> On Tue, 2012-03-13 at 11:10 +0800, joeyli wrote:
> > Hi Pradeep, 
> > 
> > 於 日，2012-03-11 於 19:42 +0000，Florian Tobias Schandinat 提到：
> > > Hi,
> > > 
> > > On 03/11/2012 06:21 PM, Pradeep Subrahmanion wrote:
> > > > Hi ,
> > > > 
> > > >          Brightness control was not  working on Acer Aspire 4736 using
> > > > default ACPI interface.  acer-acpi also do not support 4730 series since
> > > > it uses new WMI interface.
> > > > This driver adds brightness control by accessing the LBB PCI
> > > > configuration register. This approach may also work on other laptops in
> > > > 4730 series .But currently ,  it is only tested  for 
> > > > Aspire 4736.  
> > > > 
> > 
> > Pleae check does there have following interface?
> > 
> > /sys/class/backlight/intel_backlight
> > 
> > And,
> > did you try kernel parameter "acpi_backlight=vendor", does it work to
> > you?
> > 
> > Please attach acpidump: acpidump > acpidump.dat
> > 
> > 
> > Thanks
> > Joey Lee
> > 
> > > > From 893031c1e9bdefd9642b98825062b5df98af0d77 Mon Sep 17 00:00:00 2001
> > > > From: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> > > > <mailto:subrahmanion.pradeep@gmail.com>>
> > > > Date: Sun, 11 Mar 2012 23:11:23 -0400
> > > > Subject: [PATCH] Added backlight driver for Acer Aspire 4736
> > > > 
> > > 
> > > the commit message should be here, I think.
> > > 
> > > > 
> > > > Signed-off-by: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> > > > <mailto:subrahmanion.pradeep@gmail.com>>
> > > 
> > > Please resend this email in the correct format: As you can see in my
> > > email the text version of your patch is severely screwed up and nobody
> > > wants to even try converting a HTML format to a proper patch again,
> > > probably most people won't even receive an email that has a HTML part as
> > > their spam filter are going to handle it as spam. git send-email will
> > > take care of it for you if you configure it for your account.
> > > You should also cc Andrew Morton <akpm@linux-foundation.org> as he's the
> > > one who handles backlight patches at the moment.
> > > 
> > > 
> > > Best regards,
> > > 
> > > Florian Tobias Schandinat
> > > 
> > > > ---
> > > >  drivers/video/backlight/acer4736_bl.c |  110
> > > > +++++++++++++++++++++++++++++++++
> > > >  1 files changed, 110 insertions(+), 0 deletions(-)
> > > >  create mode 100644 drivers/video/backlight/acer4736_bl.c
> > > > 
> > > > diff --git a/drivers/video/backlight/acer4736_bl.c
> > > > b/drivers/video/backlight/acer4736_bl.c
> > > > new file mode 100644
> > > > index 0000000..6fe2937
> > > > --- /dev/null
> > > > +++ b/drivers/video/backlight/acer4736_bl.c
> > > > @@ -0,0 +1,110 @@
> > > > +/*
> > > > + * Backlight driver for Acer Aspire 4736
> > > > + *
> > > > + * Copyright (C) Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> > > > <mailto:subrahmanion.pradeep@gmail.com>>
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or modify
> > > > + * it under the terms of the GNU General Public License version 2 as
> > > > + * published by the Free Software Foundation.
> > > > + *
> > > > + * This driver uses LBB PCI configuration register to change the
> > > > + * backlight brightness.
> > > > + *
> > > > + */
> > > > +
> > > > +#include <linux/module.h>
> > > > +#include <linux/kernel.h>
> > > > +#include <linux/init.h>
> > > > +#include <linux/backlight.h>
> > > > +#include <linux/err.h>
> > > > +#include <linux/dmi.h>
> > > > +#include <linux/io.h>
> > > > +#include <linux/pci.h>
> > > > +
> > > > +static u8 max_brightness = 0xFF;
> > > > +static u8 lbb_offset =  0xF4;
> > > > +static unsigned int device_id = 0x2a42;
> > > > +static unsigned int vendor_id = 0x8086;
> > > > +
> > > > +struct backlight_device *acer_backlight_device;
> > > > +struct pci_dev *pdev;
> > > > +
> > > > +static int acer_dmi_match(const struct dmi_system_id *id)
> > > > +{
> > > > + printk(KERN_INFO "acer4736_bl: %s detected\n", id->ident);
> > > > + return 1;
> > > > +}
> > > > +
> > > > +static const struct dmi_system_id __initdata acer_device_table[] = {
> > > > +{
> > > > + .callback = acer_dmi_match,
> > > > + .ident = "Aspire 4736",
> > > > + .matches = {
> > > > + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> > > > + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"),
> > > > + },
> > > > + },
> > > > + {}
> > > > +};
> > > > +static int read_brightness(struct backlight_device *bd)
> > > > +{
> > > > + u8 result;
> > > > + pci_read_config_byte(pdev, lbb_offset, &result);
> > > > + return result;
> > > > +}
> > > > +
> > > > +static int update_brightness(struct backlight_device *bd)
> > > > +{
> > > > + u8 intensity = bd->props.brightness;
> > > > + if (intensity > max_brightness) {
> > > > + printk(KERN_INFO "Acer4736_bl: Invalid parameter. Maximum value is %d"
> > > > + , max_brightness);
> > > > + return -1;
> > > > + }
> > > > + pci_write_config_byte(pdev, lbb_offset, intensity);
> > > > + return 0;
> > > > +}
> > > > +static const struct  backlight_ops acer_backlight_ops = {
> > > > + .get_brightness = read_brightness,
> > > > + .update_status  = update_brightness,
> > > > +};
> > > > +
> > > > +static int __init acer4736_bl_init(void)
> > > > +{
> > > > + struct backlight_properties props;
> > > > + if (!dmi_check_system(acer_device_table))
> > > > + return -ENODEV;
> > > > +
> > > > + pdev = pci_get_device(vendor_id, device_id, NULL);
> > > > +
> > > > + if (!pdev)
> > > > + return -ENODEV;
> > > > +
> > > > + printk(KERN_INFO "Loading Acer 4736 backlight driver\n");
> > > > + memset(&props, 0, sizeof(struct backlight_properties));
> > > > + props.type = BACKLIGHT_RAW;
> > > > + props.max_brightness = max_brightness;
> > > > +
> > > > + acer_backlight_device = backlight_device_register("acer_backlight",
> > > > + NULL, NULL, &acer_backlight_ops, &props);
> > > > + acer_backlight_device->props.max_brightness = max_brightness;
> > > > + acer_backlight_device->props.brightness  > > > > + read_brightness(acer_backlight_device);
> > > > + backlight_update_status(acer_backlight_device);
> > > > +
> > > > + return 0;
> > > > +}
> > > > +
> > > > +static void __exit acer4736_bl_exit(void)
> > > > +{
> > > > + pci_dev_put(pdev);
> > > > + backlight_device_unregister(acer_backlight_device);
> > > > +}
> > > > +
> > > > +module_init(acer4736_bl_init);
> > > > +module_exit(acer4736_bl_exit);
> > > > +
> > > > +MODULE_AUTHOR("Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com
> > > > <mailto:subrahmanion.pradeep@gmail.com>>");
> > > > +MODULE_DESCRIPTION("Acer Aspire 4736 Backlight Driver");
> > > > +MODULE_LICENSE("GPL");
> > > > +MODULE_DEVICE_TABLE(dmi, acer_device_table);
> > > > -- 
> > > > 1.7.2.5
> > > > 
> > > > -------------  
> > > > 
> > > > Pradeep Subrahmanion
> > > 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at  http://www.tux.org/lkml/
> > > 
> > 
> > 
>