From: Chris Wilson <chris@chris-wilson.co.uk>
To: linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Chris Wilson <chris@chris-wilson.co.uk>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Subject: [PATCH] video/console: Clip the right margin clear to the visible region
Date: Mon, 26 Mar 2012 20:17:02 +0000 [thread overview]
Message-ID: <1332793022-29292-1-git-send-email-chris@chris-wilson.co.uk> (raw)
For some unknown reason, yres_virtual was 2x larger the the size specified
by i915 and so when blit_clear_margins() tried to clear the full virtual
right-hand margin it tried to write far beyond the end of the buffer.
This limits the clear to only the visible portion of the right-hand
margin, similar to how the bottom margin is treated.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id8138
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/video/console/bitblit.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/console/bitblit.c b/drivers/video/console/bitblit.c
index 28b1a83..9f89e5a 100644
--- a/drivers/video/console/bitblit.c
+++ b/drivers/video/console/bitblit.c
@@ -219,9 +219,9 @@ static void bit_clear_margins(struct vc_data *vc, struct fb_info *info,
if (rw && !bottom_only) {
region.dx = info->var.xoffset + rs;
- region.dy = 0;
+ region.dy = info->var.yoffset;
region.width = rw;
- region.height = info->var.yres_virtual;
+ region.height = info->var.yres;
info->fbops->fb_fillrect(info, ®ion);
}
--
1.7.9.1
next reply other threads:[~2012-03-26 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 20:17 Chris Wilson [this message]
2012-03-30 1:16 ` [PATCH] video/console: Clip the right margin clear to the visible region Florian Tobias Schandinat
2012-03-30 7:56 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332793022-29292-1-git-send-email-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=FlorianSchandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).