[PATCH] video: s3c-fb: s3c_fb_missing_pixclock() can't be __devinit

[PATCH] video: s3c-fb: s3c_fb_missing_pixclock() can't be __devinit

[Mark Brown]

Since s3c_fb_missing_pixclock() is called from s3c_fb_set_rgb_timing()
which is used in the suspend/resume paths it can't be marked __devinit
as this could result in it being discarded after boot.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/video/s3c-fb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index 18c84b8..d8f0018 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -1056,7 +1056,7 @@ static struct fb_ops s3c_fb_ops = {
  *
  * Calculate the pixel clock when none has been given through platform data.
  */
-static void __devinit s3c_fb_missing_pixclock(struct fb_videomode *mode)
+static void s3c_fb_missing_pixclock(struct fb_videomode *mode)
 {
 	u64 pixclk = 1000000000000ULL;
 	u32 div;
-- 
1.7.9.1

RE: [PATCH] video: s3c-fb: s3c_fb_missing_pixclock() can't be __devinit

[Jingoo Han]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Sunday, April 15, 2012 7:39 PM
> To: Jingoo Han; Florian Tobias Schandinat
> Cc: linux-fbdev@vger.kernel.org; Mark Brown
> Subject: [PATCH] video: s3c-fb: s3c_fb_missing_pixclock() can't be __devinit
> 
> Since s3c_fb_missing_pixclock() is called from s3c_fb_set_rgb_timing()
> which is used in the suspend/resume paths it can't be marked __devinit
> as this could result in it being discarded after boot.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

It looks good. Thank you.

Acked-by: Jingoo Han <jg1.han@samsung.com>


> ---
>  drivers/video/s3c-fb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 18c84b8..d8f0018 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -1056,7 +1056,7 @@ static struct fb_ops s3c_fb_ops = {
>   *
>   * Calculate the pixel clock when none has been given through platform data.
>   */
> -static void __devinit s3c_fb_missing_pixclock(struct fb_videomode *mode)
> +static void s3c_fb_missing_pixclock(struct fb_videomode *mode)
>  {
>  	u64 pixclk = 1000000000000ULL;
>  	u32 div;
> --
> 1.7.9.1

Re: [PATCH] video: s3c-fb: s3c_fb_missing_pixclock() can't be __devinit

[Florian Tobias Schandinat]

On 04/15/2012 10:39 AM, Mark Brown wrote:
> Since s3c_fb_missing_pixclock() is called from s3c_fb_set_rgb_timing()
> which is used in the suspend/resume paths it can't be marked __devinit
> as this could result in it being discarded after boot.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

I'm not sure that this can actually happen. But the code looks saner
with the patch applied so I applied it.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/s3c-fb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 18c84b8..d8f0018 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -1056,7 +1056,7 @@ static struct fb_ops s3c_fb_ops = {
>   *
>   * Calculate the pixel clock when none has been given through platform data.
>   */
> -static void __devinit s3c_fb_missing_pixclock(struct fb_videomode *mode)
> +static void s3c_fb_missing_pixclock(struct fb_videomode *mode)
>  {
>  	u64 pixclk = 1000000000000ULL;
>  	u32 div;

Re: [PATCH] video: s3c-fb: s3c_fb_missing_pixclock() can't be __devinit

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

On Thu, May 10, 2012 at 12:10:13AM +0000, Florian Tobias Schandinat wrote:
> On 04/15/2012 10:39 AM, Mark Brown wrote:
> > Since s3c_fb_missing_pixclock() is called from s3c_fb_set_rgb_timing()
> > which is used in the suspend/resume paths it can't be marked __devinit
> > as this could result in it being discarded after boot.

> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

> I'm not sure that this can actually happen. But the code looks saner
> with the patch applied so I applied it.

Thanks.  To trigger you'd need to disable CONFIG_HOTPLUG and modules
(possibly some other stuff too) but the main motiviation is that the
build system complains loudly about section mismatches.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]