From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/4] OMAP: DSS2: Remove suspicous and unused TAAL regulator API usage
Date: Thu, 03 May 2012 13:11:00 +0000 [thread overview]
Message-ID: <1336050660.14378.12.camel@deskari> (raw)
In-Reply-To: <1336042634-28486-1-git-send-email-broonie@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
Hi,
On Thu, 2012-05-03 at 11:57 +0100, Mark Brown wrote:
> The TAAL driver contains some regulator support which is currently unused
> (the code is there but the one panel supported by the driver doesn't have
> any regulators provided). This code mostly looks like an open coded
> version of the regulator core bulk API.
>
> The only additional feature is that a voltage range can be set once when
> the device is opened, though this is never varied at runtime. The general
> expectation is that if the device is not actively managing the voltage of
> the device (eg, doing DVFS) then any configuration will be done using the
> constraints rather than by drivers, saving them code and ensuring that
> they work well with systems where the voltage is not configurable.
>
> If systems are added needing regulator support this can be added back in,
> though it should be based on core features rather than open coding things.
I've already applied this and the three other patches that you sent in
March to my omapdss tree. Have there been any changes?
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-03 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 10:57 [PATCH 1/4] OMAP: DSS2: Remove suspicous and unused TAAL regulator API usage Mark Brown
2012-05-03 10:57 ` [PATCH 2/4] OMAPDSS: VENC: Check for errors from regulator_enable() Mark Brown
2012-05-03 10:57 ` [PATCH 3/4] OMAPDSS: TPO-TD03MTEA1: " Mark Brown
2012-05-03 10:57 ` [PATCH 4/4] OMAPDSS: TPO-TD03MTEA1: Correct comment for power on delay Mark Brown
2012-05-03 13:11 ` Tomi Valkeinen [this message]
2012-05-03 13:21 ` [PATCH 1/4] OMAP: DSS2: Remove suspicous and unused TAAL regulator API usage Mark Brown
2012-05-03 13:23 ` Tomi Valkeinen
2012-05-03 13:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336050660.14378.12.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=FlorianSchandinat@gmx.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).