Re: [PATCH 11/25] OMAPDSS: create custom pdevs for DSS omap_devices

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]

On Fri, 2012-05-04 at 11:33 +0530, Archit Taneja wrote:
> Hi,
> 
> On Thursday 03 May 2012 07:27 PM, Tomi Valkeinen wrote:
> > Instead of using omap_device_build() to create the omap_devices for DSS
> > hwmods, create them with a custom function. This will allow us to create
> > a parent-child hierarchy for the devices so that the omapdss_core device
> > is parent for the rest of the dss hwmod devices.
> >
> > Signed-off-by: Tomi Valkeinen<tomi.valkeinen@ti.com>
> > ---
> >   arch/arm/mach-omap2/display.c |   88 ++++++++++++++++++++++++++++++++++-------
> >   1 file changed, 74 insertions(+), 14 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
> > index 07232fd..46d2a98 100644
> > --- a/arch/arm/mach-omap2/display.c
> > +++ b/arch/arm/mach-omap2/display.c
> > @@ -185,13 +185,71 @@ static int omap_dss_set_min_bus_tput(struct device *dev, unsigned long tput)
> >   	return omap_pm_set_min_bus_tput(dev, OCP_INITIATOR_AGENT, tput);
> >   }
> >
> > +static struct platform_device *create_dss_pdev(const char *pdev_name,
> > +		int pdev_id, const char *oh_name, void *pdata, int pdata_len,
> > +		struct platform_device *parent)
> 
> This function looks quite generic, it's like omap_device_build() but 
> with a parent associated. omap_device_build() seems to be a special case 
> of this function with parent passed as null. Won't this
> function be needed by other devices too?
> 
> Maybe we could modify omap_device_build_ss() to take a parent argument, 
> and make a function called omap_device_build_parent(), where both 
> omap_device_build() and omap_device_build_parent() call 
> omap_device_build_ss()?

Yes, that sounds good to me.

Paul, Kevin, what do you think, could the omap_device functions be
extended to allow setting a parent device?

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]