linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@googlemail.com>
To: linux-serial@vger.kernel.org
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Herrmann <dh.herrmann@googlemail.com>
Subject: [PATCH 09/10] fblog: register all handlers on module-init
Date: Sat, 16 Jun 2012 22:04:25 +0000	[thread overview]
Message-ID: <1339884266-9201-10-git-send-email-dh.herrmann@googlemail.com> (raw)
In-Reply-To: <1339884266-9201-1-git-send-email-dh.herrmann@googlemail.com>

We now create a new "fblog" device when initializing the fblog module. We
register the "active" sysfs-file with it so user-space can now access
fblog. We also register the framebuffer-notifier and console-handler so
fblog is ready to go.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 drivers/video/console/fblog.c |   59 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c
index 79bfbcc..9d3b072 100644
--- a/drivers/video/console/fblog.c
+++ b/drivers/video/console/fblog.c
@@ -92,6 +92,7 @@ struct fblog_fb {
 };
 
 static struct fblog_fb *fblog_fbs[FB_MAX];
+static struct device *fblog_device;
 static atomic_t fblog_active;
 
 static void fblog_buf_resize(struct fblog_buf *buf, size_t width,
@@ -609,13 +610,71 @@ static ssize_t fblog_dev_active_store(struct device *dev,
 static DEVICE_ATTR(active, S_IRUGO | S_IWUSR | S_IWGRP, fblog_dev_active_show,
 		   fblog_dev_active_store);
 
+static void fblog_dev_release(struct device *dev)
+{
+	kfree(dev);
+	module_put(THIS_MODULE);
+}
+
 static int __init fblog_init(void)
 {
+	int ret;
+
+	fblog_device = kzalloc(sizeof(*fblog_device), GFP_KERNEL);
+	if (!fblog_device) {
+		pr_err("fblog: cannot allocate device\n");
+		ret = -ENOMEM;
+		goto err_out;
+	}
+
+	__module_get(THIS_MODULE);
+	device_initialize(fblog_device);
+	fblog_device->class = fb_class;
+	fblog_device->release = fblog_dev_release;
+	dev_set_name(fblog_device, "fblog");
+
+	ret = device_add(fblog_device);
+	if (ret) {
+		pr_err("fblog: cannot add device\n");
+		goto err_dev;
+	}
+
+	ret = fb_register_client(&fblog_notifier);
+	if (ret) {
+		pr_err("fblog: cannot register framebuffer notifier\n");
+		goto err_dev_rm;
+	}
+
+	ret = device_create_file(fblog_device, &dev_attr_active);
+	if (ret) {
+		pr_err("fblog: cannot create sysfs entry\n");
+		goto err_fb;
+	}
+
+	register_console(&fblog_con_driver);
+
 	return 0;
+
+err_fb:
+	fb_unregister_client(&fblog_notifier);
+err_dev_rm:
+	device_del(fblog_device);
+err_dev:
+	put_device(fblog_device);
+err_out:
+	return ret;
 }
 
 static void __exit fblog_exit(void)
 {
+	unregister_console(&fblog_con_driver);
+	device_remove_file(fblog_device, &dev_attr_active);
+	device_del(fblog_device);
+	fb_unregister_client(&fblog_notifier);
+	console_lock();
+	fblog_deactivate();
+	console_unlock();
+	put_device(fblog_device);
 }
 
 module_init(fblog_init);
-- 
1.7.10.4


  parent reply	other threads:[~2012-06-16 22:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-16 22:04 [RFC 00/10] fblog: framebuffer kernel log driver David Herrmann
2012-06-16 22:04 ` [PATCH 01/10] fblog: new framebuffer kernel log dummy driver David Herrmann
2012-06-16 22:04 ` [PATCH 02/10] fblog: implement buffer management David Herrmann
2012-06-16 22:04 ` [PATCH 03/10] fblog: register framebuffer objects David Herrmann
2012-06-16 22:04 ` [PATCH 04/10] fblog: implement fblog_redraw() David Herrmann
2012-06-16 22:35   ` Alan Cox
2012-06-18 18:36     ` David Herrmann
2012-06-16 22:04 ` [PATCH 05/10] fblog: add framebuffer helpers David Herrmann
2012-06-16 22:33   ` Bruno Prémont
2012-06-18 18:50     ` David Herrmann
2012-06-16 22:04 ` [PATCH 06/10] fblog: allow enabling/disabling fblog on runtime David Herrmann
2012-06-16 22:04 ` [PATCH 07/10] fblog: forward kernel log messages to all framebuffers David Herrmann
2012-06-16 22:04 ` [PATCH 08/10] fblog: react on framebuffer events David Herrmann
2012-06-16 22:04 ` David Herrmann [this message]
2012-06-16 22:04 ` [PATCH 10/10] fblog: add "activate" module parameter David Herrmann
2012-06-18 19:06 ` [RFC 00/10] fblog: framebuffer kernel log driver David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339884266-9201-10-git-send-email-dh.herrmann@googlemail.com \
    --to=dh.herrmann@googlemail.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).