From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Tue, 26 Jun 2012 15:11:54 +0000 Subject: Re: [PATCH] OMAPDSS: Check if RPM enabled before trying to change state Message-Id: <1340723514.24530.70.camel@deskari> MIME-Version: 1 Content-Type: multipart/mixed; boundary="=-j3/ILLjQocy97i5AyV2l" List-Id: References: <1340438771-25587-1-git-send-email-jaswinder.singh@linaro.org> <1340605221.12683.30.camel@lappyti> <1340616643.3395.19.camel@deskari> <1340628094.3395.63.camel@deskari> <1340632161.3395.100.camel@deskari> <1340695166.2093.22.camel@lappyti> <1340701660.24530.17.camel@deskari> <1340712213.24530.21.camel@deskari> <1340723296.24530.68.camel@deskari> In-Reply-To: To: Jassi Brar Cc: mythripk@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, andy.green@linaro.org, n-dechesne@ti.com --=-j3/ILLjQocy97i5AyV2l Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2012-06-26 at 20:39 +0530, Jassi Brar wrote: > On 26 June 2012 20:38, Tomi Valkeinen wrote: > > On Tue, 2012-06-26 at 20:19 +0530, Jassi Brar wrote: > >> On 26 June 2012 17:33, Tomi Valkeinen wrote: > >> > On Tue, 2012-06-26 at 15:27 +0530, Jassi Brar wrote: > >> > > >> >> Seems similar, but I only tested OMAP4 HDMI. > >> > > >> > Would something like this one below work for you? It fixes the issue= s on > >> > my overo board. > >> > > >> I think this should work too (I will get to test it only tomorrow). > >> > >> Though I don't think it'll fix stack spew when run without > >> CONFIG_PM_RUNTIME. Maybe we could simply remove the WARN_ON in the > >> xxx_runtime_put() as Alan noted? > > > > Yes, that's a different issue. I'll look at that also. > > > Well, my patch took care of that also. But I agree, that could be > added separately as well. Well, I don't agree that your patch is correct =3D). I don't think it's right to skip runtime get and put when pm_runtime_enabled() returns false. Tomi --=-j3/ILLjQocy97i5AyV2l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJP6dE6AAoJEPo9qoy8lh71Je0P+wdrtfhUe5FBhPiQI7KVuwh9 ATT9ObxqXUlXi6H6MP5lD54P7QYvlvYRT7dtThc9p/yV7axZbpLJkBflAmViKFu+ igiWY1p3FMc/eYjseQvZootXiLnNLBLS4LkWLpzltL2bCDc+moAgIj7hc7pJeQZ4 UOWXnd0nYFyeZ6NpPECg29PnnIFEGyIttqKTA3A+6QOjj1VTe9Fc1RuNifPnrPg+ sTmSb1EjHDm4Y5VedabBttxszd2snl06fqOwP+34J+oF3nAh0feZiA7NzrWlB7sc QRNOlgR6EEozwY8O7RsAnzKHI3lwAjbgnKFn+fJ6UDX6l4ZYGD/9FkRlcVtrp3qW bHnaQcI+HH7HWXbKvIZQu+9P4WZUZH3E+xWc60KKwGUFmkf7cs0pdADedmYMyheQ 59Dnpl8qSPbdoHL3USpMzWLWkc9RyZJgZqNpOub0qy1shb0QBS6JQN9nIJnaLUey 848e2TL9zL1ClTMly/Gcjdj29Gg7gba+x2uGPm+NLXsZwDScjo40mJg3WuVP+zxr kNdy8kzvUyqcglLXlU4kwb/qwlvysT+OHsrD/MioRJdQWtipJCAUWamYOXmjwi3D xhdr8LRIZubtiUpH59urSqTpCmvOlmHj5IPdk8ai6cGEutCp+VIXP6JxnkadMwVE kzC5oQUSnheKkRYSEOOx =5pAv -----END PGP SIGNATURE----- --=-j3/ILLjQocy97i5AyV2l--