From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jassi Brar <jaswinder.singh@linaro.org>
Cc: mythripk@ti.com, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org, andy.green@linaro.org,
n-dechesne@ti.com, patches@linaro.org
Subject: Re: [PATCH 3/3] OMAPDSS: HDMI: Cache EDID
Date: Thu, 28 Jun 2012 13:35:26 +0000 [thread overview]
Message-ID: <1340890526.5037.93.camel@deskari> (raw)
In-Reply-To: <CAJe_ZhfehDquDcyefb7Z9odH+hfQTFiRAux_iyvAycs9Otovtw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Thu, 2012-06-28 at 16:28 +0530, Jassi Brar wrote:
> > I think among the first things, while enabling HDMI, should be to see
> > if there is really some display connected on the port i.e, HPD
> > asserted. Only if ti_hdmi_4_detect() returned true, should we
> > proceed otherwise wait for HPQ irq.
> >
> > Unconditionally invalidating edid really seems like a regression - we
> > impose atleast 50ms (edid read) as extra cost on
> > hdmi_check_hpd_state(), which kills half the purpose of this patch.
> >
> Sorry a correction. Reading detect() won't work. I suggest we keep HPD
> IRQ enabled for the lifetime of the driver.
By the way, when the device is in system suspend, we surely won't detect
the HPD even if we kept the HPD always enabled. So there we'll miss the
HPD interrupt anyway, and the EDID cache would be invalid.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-28 13:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 14:17 [PATCH 3/3] OMAPDSS: HDMI: Cache EDID jaswinder.singh
2012-06-28 7:48 ` Tomi Valkeinen
2012-06-28 9:51 ` Jassi Brar
2012-06-28 10:14 ` Tomi Valkeinen
2012-06-28 10:59 ` Jassi Brar
2012-06-28 11:04 ` Tomi Valkeinen
2012-06-28 11:10 ` Jassi Brar
2012-06-28 11:10 ` Tomi Valkeinen
2012-06-28 11:38 ` Tomi Valkeinen
2012-06-28 12:15 ` Andy Green
2012-06-28 12:03 ` Andy Green
2012-06-28 13:08 ` Tomi Valkeinen
2012-06-28 13:25 ` Jassi Brar
2012-06-28 13:31 ` Tomi Valkeinen
2012-06-28 15:26 ` Jassi Brar
2012-06-28 15:27 ` Tomi Valkeinen
2012-06-28 15:51 ` Jassi Brar
2012-06-28 16:32 ` Jassi Brar
2012-06-28 15:14 ` Tomi Valkeinen
2012-06-28 15:30 ` Jassi Brar
2012-06-28 12:43 ` Jassi Brar
2012-06-28 13:35 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340890526.5037.93.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=andy.green@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
--cc=n-dechesne@ti.com \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).