From: Joe Perches <joe@perches.com>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
florianschandinat@gmx.de, linux-fbdev@vger.kernel.org,
gregkh@linuxfoundation.org, alan@lxorguk.ukuu.org.uk,
bonbons@linux-vserver.org
Subject: Re: [PATCH v2 05/11] fblog: register one fblog object per framebuffer
Date: Sun, 08 Jul 2012 22:13:48 +0000 [thread overview]
Message-ID: <1341785628.13174.28.camel@joe2Laptop> (raw)
In-Reply-To: <1341784614-2797-6-git-send-email-dh.herrmann@googlemail.com>
On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote:
>
Hi David. Trivial comments only:
> diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c
[]
> @@ -23,15 +23,204 @@
> * all fblog instances before running other graphics applications.
> */
Please add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include and...
> static int __init fblog_init(void)
> {
> + int ret;
> +
> + ret = fb_register_client(&fblog_notifier);
> + if (ret) {
> + pr_err("fblog: cannot register framebuffer notifier");
Missing newline, pr_fmt would add module name.
pr_err("cannot register framebuffer notifier\n");
next prev parent reply other threads:[~2012-07-08 22:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 21:56 [PATCH v2 00/11] fblog: framebuffer kernel log driver David Herrmann
2012-07-08 21:56 ` [PATCH v2 01/11] fbcon: move update_attr() into separate source file David Herrmann
2012-07-08 21:56 ` [PATCH v2 02/11] fbcon: move bit_putcs() " David Herrmann
2012-07-08 21:56 ` [PATCH v2 03/11] fblog: new framebuffer kernel log dummy driver David Herrmann
2012-07-08 21:56 ` [PATCH v2 04/11] fbdev: export get_fb_info()/put_fb_info() David Herrmann
2012-07-09 7:34 ` Geert Uytterhoeven
2012-07-09 17:34 ` David Herrmann
2012-07-08 21:56 ` [PATCH v2 05/11] fblog: register one fblog object per framebuffer David Herrmann
2012-07-08 22:13 ` Joe Perches [this message]
2012-07-09 17:55 ` David Herrmann
2012-07-08 21:56 ` [PATCH v2 06/11] fblog: open fb on registration David Herrmann
2012-07-08 21:56 ` [PATCH v2 07/11] fblog: allow selecting fbs via sysfs David Herrmann
2012-07-08 21:56 ` [PATCH v2 08/11] fblog: cache framebuffer BLANK and SUSPEND states David Herrmann
2012-07-08 21:56 ` [PATCH v2 09/11] fblog: register console driver David Herrmann
2012-07-08 22:09 ` Joe Perches
2012-07-09 18:25 ` David Herrmann
2012-07-08 21:56 ` [PATCH v2 10/11] fblog: draw console to framebuffers David Herrmann
2012-07-08 21:56 ` [PATCH v2 11/11] MAINTAINERS: add fblog entry David Herrmann
2012-07-09 7:33 ` Geert Uytterhoeven
2012-07-09 18:38 ` David Herrmann
2012-07-17 12:57 ` Geert Uytterhoeven
2012-07-17 13:15 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341785628.13174.28.camel@joe2Laptop \
--to=joe@perches.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bonbons@linux-vserver.org \
--cc=dh.herrmann@googlemail.com \
--cc=florianschandinat@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).