linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Damien Cassou <damien.cassou@lifl.fr>
To: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] drivers/video/cobalt_lcdfb.c: use devm_ functions
Date: Tue, 31 Jul 2012 13:54:18 +0000	[thread overview]
Message-ID: <1343742860-16213-4-git-send-email-damien.cassou@lifl.fr> (raw)
In-Reply-To: <1343742860-16213-1-git-send-email-damien.cassou@lifl.fr>

From: Damien Cassou <damien.cassou@lifl.fr>

The various devm_ functions allocate memory that is released when a driver
detaches.  This patch uses these functions for data that is allocated in
the probe function of a platform device and is only freed in the remove
function.

Signed-off-by: Damien Cassou <damien.cassou@lifl.fr>

---
 drivers/video/cobalt_lcdfb.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/video/cobalt_lcdfb.c b/drivers/video/cobalt_lcdfb.c
index eae46f6..01a4ee7 100644
--- a/drivers/video/cobalt_lcdfb.c
+++ b/drivers/video/cobalt_lcdfb.c
@@ -348,7 +348,8 @@ static int __devinit cobalt_lcdfb_probe(struct platform_device *dev)
 	}
 
 	info->screen_size = resource_size(res);
-	info->screen_base = ioremap(res->start, info->screen_size);
+	info->screen_base = devm_ioremap(&dev->dev, res->start,
+					 info->screen_size);
 	info->fbops = &cobalt_lcd_fbops;
 	info->fix = cobalt_lcdfb_fix;
 	info->fix.smem_start = res->start;
@@ -359,7 +360,6 @@ static int __devinit cobalt_lcdfb_probe(struct platform_device *dev)
 
 	retval = register_framebuffer(info);
 	if (retval < 0) {
-		iounmap(info->screen_base);
 		framebuffer_release(info);
 		return retval;
 	}
@@ -380,7 +380,6 @@ static int __devexit cobalt_lcdfb_remove(struct platform_device *dev)
 
 	info = platform_get_drvdata(dev);
 	if (info) {
-		iounmap(info->screen_base);
 		unregister_framebuffer(info);
 		framebuffer_release(info);
 	}


  parent reply	other threads:[~2012-07-31 13:54 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31 13:54 [PATCH 0/5] use devm_ functions Damien Cassou
2012-07-31 13:54 ` [PATCH 5/5] drivers/video/ep93xx-fb.c: " Damien Cassou
2012-08-23 20:35   ` Florian Tobias Schandinat
2012-07-31 13:54 ` [PATCH 4/5] drivers/video/da8xx-fb.c: " Damien Cassou
2012-07-31 15:59   ` Sachin Kamat
2012-07-31 16:01     ` Damien Cassou
2012-07-31 13:54 ` Damien Cassou [this message]
2012-08-23 20:36   ` [PATCH 3/5] drivers/video/cobalt_lcdfb.c: " Florian Tobias Schandinat
2012-07-31 13:54 ` [PATCH 2/5] drivers/video/bfin-t350mcqb-fb.c: " Damien Cassou
2012-07-31 13:57   ` Mike Frysinger
2012-07-31 16:18     ` Damien Cassou
2012-07-31 13:54 ` [PATCH 1/5] drivers/video/bf537-lq035.c: " Damien Cassou
2012-08-23 20:36   ` Florian Tobias Schandinat
2012-07-31 16:39 ` [PATCH 0/5] " Damien Cassou
2012-07-31 16:39   ` [PATCH 3/5] drivers/video/mbx/mbxfb.c: " Damien Cassou
2012-08-23 20:37     ` Florian Tobias Schandinat
2012-07-31 16:39   ` [PATCH 2/5] drivers/video/gbefb.c: " Damien Cassou
2012-08-23 20:37     ` Florian Tobias Schandinat
2012-09-13 19:06       ` Geert Uytterhoeven
2012-09-20 21:58         ` Florian Tobias Schandinat
2012-10-11  0:38           ` [PATCH] gbefb: fix compile error Florian Tobias Schandinat
2012-07-31 16:39   ` [PATCH 1/5] drivers/video/fsl-diu-fb.c: use devm_ functions Damien Cassou
2012-08-23 20:38     ` Florian Tobias Schandinat
2012-07-31 16:39   ` [PATCH 4/5] drivers/video/exynos/exynos_mipi_dsi.c: " Damien Cassou
2012-07-31 16:39   ` [PATCH 5/5] drivers/video/exynos/exynos_dp_core.c: " Damien Cassou
2012-07-31 23:21     ` Jingoo Han
2012-08-01  4:11       ` Sachin Kamat
2012-08-01  4:30         ` Jingoo Han
2012-08-01  4:50           ` Sachin Kamat
2012-08-01  4:57             ` Jingoo Han
2012-08-01  5:13               ` Julia Lawall
2012-08-01  5:08         ` Jingoo Han
2012-08-01 16:36           ` Damien Cassou
2012-08-03 15:40 ` [PATCH 0/5] " Damien Cassou
2012-08-03 15:40   ` [PATCH 1/5] drivers/video/epson1355fb.c: " Damien Cassou
2012-08-23 20:40     ` Florian Tobias Schandinat
2012-08-03 15:40   ` [PATCH 3/5] drivers/video/jz4740_fb.c: " Damien Cassou
2012-08-23 20:41     ` Florian Tobias Schandinat
2012-09-02 15:19       ` Lars-Peter Clausen
2012-08-03 15:40   ` [PATCH 2/5] drivers/video/bf54x-lq043fb.c: " Damien Cassou
2012-08-23 20:41     ` Florian Tobias Schandinat
2012-08-03 15:40   ` [PATCH 5/5] drivers/video/msm/mddi_client_nt35399.c: " Damien Cassou
2012-08-06  9:06     ` Dan Carpenter
2012-08-09 17:38     ` David Brown
2012-08-23 20:42     ` Florian Tobias Schandinat
2012-08-03 15:40   ` [PATCH 4/5] drivers/video/msm/mddi_client_dummy.c: " Damien Cassou
2012-08-09 17:39     ` David Brown
2012-08-09 17:57     ` David Brown
2012-08-28  8:42       ` Damien Cassou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343742860-16213-4-git-send-email-damien.cassou@lifl.fr \
    --to=damien.cassou@lifl.fr \
    --cc=FlorianSchandinat@gmx.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).