linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V4 0/2] arm: samsung: Move FIMD headers to include/video/
@ 2012-08-07 12:38 Leela Krishna Amudala
  0 siblings, 0 replies; 5+ messages in thread
From: Leela Krishna Amudala @ 2012-08-07 12:38 UTC (permalink / raw)
  To: linux-arm-kernel, linux-samsung-soc
  Cc: dri-devel, linux-fbdev, ben-linux, kgene.kim, m.szyprowski

This patchset moves the contents of regs-fb-v4.h and regs-fb.h from arch side
to include/video/samsung_fimd.h

This patchset is created and rebased against master branch of torvalds tree.
Tested on smdk5250 board, build tested for other boards.

Changes from version 3:
	- Squashed 1st, 3rd, 4th and 5th patches from version 3

Changes from version 2:
	- Changed the EXYNOS5_xxx macro name to FIMD_V8_xxx
	- Moved the header inclusion under same kind

Changes from version 1:
	- Split the patches as per Sylwester comments
	- Changed FIMD_V8_xxx macro to EXYNOS5_xxx	

Leela Krishna Amudala (2):
  include/video: move fimd register headers from platform to
    include/video
  include/video: Add register offsets for FIMD version 8

 arch/arm/mach-exynos/mach-nuri.c                   |    2 +-
 arch/arm/mach-exynos/mach-origen.c                 |    2 +-
 arch/arm/mach-exynos/mach-smdk4x12.c               |    2 +-
 arch/arm/mach-exynos/mach-smdkv310.c               |    2 +-
 arch/arm/mach-exynos/mach-universal_c210.c         |    2 +-
 arch/arm/mach-exynos/setup-fimd0.c                 |    2 +-
 arch/arm/mach-s3c24xx/mach-smdk2416.c              |    2 +-
 arch/arm/mach-s3c64xx/mach-anw6410.c               |    2 +-
 arch/arm/mach-s3c64xx/mach-crag6410.c              |    2 +-
 arch/arm/mach-s3c64xx/mach-hmt.c                   |    2 +-
 arch/arm/mach-s3c64xx/mach-mini6410.c              |    2 +-
 arch/arm/mach-s3c64xx/mach-ncp.c                   |    2 +-
 arch/arm/mach-s3c64xx/mach-real6410.c              |    2 +-
 arch/arm/mach-s3c64xx/mach-smartq5.c               |    2 +-
 arch/arm/mach-s3c64xx/mach-smartq7.c               |    2 +-
 arch/arm/mach-s3c64xx/mach-smdk6410.c              |    2 +-
 arch/arm/mach-s5p64x0/mach-smdk6440.c              |    2 +-
 arch/arm/mach-s5p64x0/mach-smdk6450.c              |    2 +-
 arch/arm/mach-s5pc100/mach-smdkc100.c              |    2 +-
 arch/arm/mach-s5pv210/mach-aquila.c                |    2 +-
 arch/arm/mach-s5pv210/mach-goni.c                  |    2 +-
 arch/arm/mach-s5pv210/mach-smdkv210.c              |    2 +-
 arch/arm/plat-samsung/include/plat/regs-fb-v4.h    |  159 --------------------
 drivers/gpu/drm/exynos/exynos_drm_fimd.c           |    2 +-
 drivers/video/s3c-fb.c                             |    2 +-
 .../plat/regs-fb.h => include/video/samsung_fimd.h |  152 +++++++++++++++++--
 26 files changed, 165 insertions(+), 194 deletions(-)
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
 rename arch/arm/plat-samsung/include/plat/regs-fb.h => include/video/samsung_fimd.h (73%)


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH V4 0/2] arm: samsung: Move FIMD headers to include/video/
@ 2012-08-07 12:46 Leela Krishna Amudala
  2012-08-07 14:33 ` Russell King - ARM Linux
  2012-08-08  6:20 ` Kukjin Kim
  0 siblings, 2 replies; 5+ messages in thread
From: Leela Krishna Amudala @ 2012-08-07 12:46 UTC (permalink / raw)
  To: linux-arm-kernel, linux-samsung-soc
  Cc: dri-devel, linux-fbdev, ben-linux, kgene.kim, m.szyprowski

This patchset moves the contents of regs-fb-v4.h and regs-fb.h from arch side
to include/video/samsung_fimd.h

This patchset is created and rebased against master branch of torvalds tree.
Tested on smdk5250 board, build tested for other boards.

Changes from version 3:
	- Squashed 1st, 3rd, 4th and 5th patches from version 3

Changes from version 2:
	- Changed the EXYNOS5_xxx macro name to FIMD_V8_xxx
	- Moved the header inclusion under same kind

Changes from version 1:
	- Split the patches as per Sylwester comments
	- Changed FIMD_V8_xxx macro to EXYNOS5_xxx	

Leela Krishna Amudala (2):
  include/video: move fimd register headers from platform to
    include/video
  include/video: Add register offsets for FIMD version 8

 arch/arm/mach-exynos/mach-nuri.c                   |    2 +-
 arch/arm/mach-exynos/mach-origen.c                 |    2 +-
 arch/arm/mach-exynos/mach-smdk4x12.c               |    2 +-
 arch/arm/mach-exynos/mach-smdkv310.c               |    2 +-
 arch/arm/mach-exynos/mach-universal_c210.c         |    2 +-
 arch/arm/mach-exynos/setup-fimd0.c                 |    2 +-
 arch/arm/mach-s3c24xx/mach-smdk2416.c              |    2 +-
 arch/arm/mach-s3c64xx/mach-anw6410.c               |    2 +-
 arch/arm/mach-s3c64xx/mach-crag6410.c              |    2 +-
 arch/arm/mach-s3c64xx/mach-hmt.c                   |    2 +-
 arch/arm/mach-s3c64xx/mach-mini6410.c              |    2 +-
 arch/arm/mach-s3c64xx/mach-ncp.c                   |    2 +-
 arch/arm/mach-s3c64xx/mach-real6410.c              |    2 +-
 arch/arm/mach-s3c64xx/mach-smartq5.c               |    2 +-
 arch/arm/mach-s3c64xx/mach-smartq7.c               |    2 +-
 arch/arm/mach-s3c64xx/mach-smdk6410.c              |    2 +-
 arch/arm/mach-s5p64x0/mach-smdk6440.c              |    2 +-
 arch/arm/mach-s5p64x0/mach-smdk6450.c              |    2 +-
 arch/arm/mach-s5pc100/mach-smdkc100.c              |    2 +-
 arch/arm/mach-s5pv210/mach-aquila.c                |    2 +-
 arch/arm/mach-s5pv210/mach-goni.c                  |    2 +-
 arch/arm/mach-s5pv210/mach-smdkv210.c              |    2 +-
 arch/arm/plat-samsung/include/plat/regs-fb-v4.h    |  159 --------------------
 drivers/gpu/drm/exynos/exynos_drm_fimd.c           |    2 +-
 drivers/video/s3c-fb.c                             |    2 +-
 .../plat/regs-fb.h => include/video/samsung_fimd.h |  152 +++++++++++++++++--
 26 files changed, 165 insertions(+), 194 deletions(-)
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
 rename arch/arm/plat-samsung/include/plat/regs-fb.h => include/video/samsung_fimd.h (73%)


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V4 0/2] arm: samsung: Move FIMD headers to include/video/
  2012-08-07 12:46 Leela Krishna Amudala
@ 2012-08-07 14:33 ` Russell King - ARM Linux
  2012-08-07 15:05   ` Sylwester Nawrocki
  2012-08-08  6:20 ` Kukjin Kim
  1 sibling, 1 reply; 5+ messages in thread
From: Russell King - ARM Linux @ 2012-08-07 14:33 UTC (permalink / raw)
  To: Leela Krishna Amudala
  Cc: linux-arm-kernel, linux-samsung-soc, linux-fbdev, kgene.kim,
	ben-linux, dri-devel, m.szyprowski

On Tue, Aug 07, 2012 at 06:04:30PM +0530, Leela Krishna Amudala wrote:
>  arch/arm/plat-samsung/include/plat/regs-fb-v4.h    |  159 --------------------
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c           |    2 +-
>  drivers/video/s3c-fb.c                             |    2 +-
>  .../plat/regs-fb.h => include/video/samsung_fimd.h |  152 +++++++++++++++++--

Isn't include/video for framebuffer drivers?  Isn't this more a DRM thing?
Wouldn't include/drm therefore be more appropriate?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V4 0/2] arm: samsung: Move FIMD headers to include/video/
  2012-08-07 14:33 ` Russell King - ARM Linux
@ 2012-08-07 15:05   ` Sylwester Nawrocki
  0 siblings, 0 replies; 5+ messages in thread
From: Sylwester Nawrocki @ 2012-08-07 15:05 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: Leela Krishna Amudala, linux-arm-kernel, linux-samsung-soc,
	linux-fbdev, kgene.kim, ben-linux, dri-devel, m.szyprowski

On 08/07/2012 04:33 PM, Russell King - ARM Linux wrote:
> On Tue, Aug 07, 2012 at 06:04:30PM +0530, Leela Krishna Amudala wrote:
>>  arch/arm/plat-samsung/include/plat/regs-fb-v4.h    |  159 --------------------
>>  drivers/gpu/drm/exynos/exynos_drm_fimd.c           |    2 +-
>>  drivers/video/s3c-fb.c                             |    2 +-
>>  .../plat/regs-fb.h => include/video/samsung_fimd.h |  152 +++++++++++++++++--
> 
> Isn't include/video for framebuffer drivers?  Isn't this more a DRM thing?
> Wouldn't include/drm therefore be more appropriate?

Those headers are now used by both: framebuffer and Exynos DRM
driver. And probably the framebuffer driver has more users, as it
also covers older FIMD devices than those found on exynos4/5 SoCs.

So include/video seems equally right (or wrong) as include/drm.

There have been some efforts, or at least requirements raised, to
create some common low level API for framebuffer and DRM drivers,
but nothing has clarified yet AFAICS.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH V4 0/2] arm: samsung: Move FIMD headers to include/video/
  2012-08-07 12:46 Leela Krishna Amudala
  2012-08-07 14:33 ` Russell King - ARM Linux
@ 2012-08-08  6:20 ` Kukjin Kim
  1 sibling, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2012-08-08  6:20 UTC (permalink / raw)
  To: 'Leela Krishna Amudala', linux-arm-kernel,
	linux-samsung-soc
  Cc: dri-devel, linux-fbdev, ben-linux, m.szyprowski,
	'Florian Tobias Schandinat'

Leela Krishna Amudala wrote:
> 
> This patchset moves the contents of regs-fb-v4.h and regs-fb.h from arch
> side
> to include/video/samsung_fimd.h
> 
> This patchset is created and rebased against master branch of torvalds
> tree.
> Tested on smdk5250 board, build tested for other boards.
> 
> Changes from version 3:
> 	- Squashed 1st, 3rd, 4th and 5th patches from version 3
> 
> Changes from version 2:
> 	- Changed the EXYNOS5_xxx macro name to FIMD_V8_xxx
> 	- Moved the header inclusion under same kind
> 
> Changes from version 1:
> 	- Split the patches as per Sylwester comments
> 	- Changed FIMD_V8_xxx macro to EXYNOS5_xxx
> 
> Leela Krishna Amudala (2):
>   include/video: move fimd register headers from platform to
>     include/video
>   include/video: Add register offsets for FIMD version 8
> 
>  arch/arm/mach-exynos/mach-nuri.c                   |    2 +-
>  arch/arm/mach-exynos/mach-origen.c                 |    2 +-
>  arch/arm/mach-exynos/mach-smdk4x12.c               |    2 +-
>  arch/arm/mach-exynos/mach-smdkv310.c               |    2 +-
>  arch/arm/mach-exynos/mach-universal_c210.c         |    2 +-
>  arch/arm/mach-exynos/setup-fimd0.c                 |    2 +-
>  arch/arm/mach-s3c24xx/mach-smdk2416.c              |    2 +-
>  arch/arm/mach-s3c64xx/mach-anw6410.c               |    2 +-
>  arch/arm/mach-s3c64xx/mach-crag6410.c              |    2 +-
>  arch/arm/mach-s3c64xx/mach-hmt.c                   |    2 +-
>  arch/arm/mach-s3c64xx/mach-mini6410.c              |    2 +-
>  arch/arm/mach-s3c64xx/mach-ncp.c                   |    2 +-
>  arch/arm/mach-s3c64xx/mach-real6410.c              |    2 +-
>  arch/arm/mach-s3c64xx/mach-smartq5.c               |    2 +-
>  arch/arm/mach-s3c64xx/mach-smartq7.c               |    2 +-
>  arch/arm/mach-s3c64xx/mach-smdk6410.c              |    2 +-
>  arch/arm/mach-s5p64x0/mach-smdk6440.c              |    2 +-
>  arch/arm/mach-s5p64x0/mach-smdk6450.c              |    2 +-
>  arch/arm/mach-s5pc100/mach-smdkc100.c              |    2 +-
>  arch/arm/mach-s5pv210/mach-aquila.c                |    2 +-
>  arch/arm/mach-s5pv210/mach-goni.c                  |    2 +-
>  arch/arm/mach-s5pv210/mach-smdkv210.c              |    2 +-
>  arch/arm/plat-samsung/include/plat/regs-fb-v4.h    |  159
----------------
> ----
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c           |    2 +-
>  drivers/video/s3c-fb.c                             |    2 +-
>  .../plat/regs-fb.h => include/video/samsung_fimd.h |  152
> +++++++++++++++++--
>  26 files changed, 165 insertions(+), 194 deletions(-)
>  delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
>  rename arch/arm/plat-samsung/include/plat/regs-fb.h =>
> include/video/samsung_fimd.h (73%)

Looks OK to me. Will apply into topic branch, 'v3.7-for-florian' for
Florian's pulling.

If there is no objection for a couple of days, I will merge this into
for-next and send to Florian.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-08-08  6:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-07 12:38 [PATCH V4 0/2] arm: samsung: Move FIMD headers to include/video/ Leela Krishna Amudala
  -- strict thread matches above, loose matches on Subject: below --
2012-08-07 12:46 Leela Krishna Amudala
2012-08-07 14:33 ` Russell King - ARM Linux
2012-08-07 15:05   ` Sylwester Nawrocki
2012-08-08  6:20 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).