From: Sean Paul <seanpaul@chromium.org>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH 05/10] video: exynos_dp: Remove sink control to D0
Date: Wed, 08 Aug 2012 03:54:19 +0000 [thread overview]
Message-ID: <1344398064-13563-6-git-send-email-seanpaul@chromium.org> (raw)
Don't reset the sink power to D0. Removing this for three reasons:
1) It's not required in the SW link training documentation
2) The comment is incorrect, D0 is normal operation, not "power down"
3) It seems to change things in the link training that causes glitches
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/video/exynos/exynos_dp_core.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c
index 207bd7e..1c998d9 100644
--- a/drivers/video/exynos/exynos_dp_core.c
+++ b/drivers/video/exynos/exynos_dp_core.c
@@ -273,12 +273,6 @@ static int exynos_dp_link_start(struct exynos_dp_device *dp)
for (lane = 0; lane < lane_count; lane++)
dp->link_train.cr_loop[lane] = 0;
- /* Set sink to D0 (Sink Not Ready) mode. */
- ret = exynos_dp_write_byte_to_dpcd(dp, DPCD_ADDR_SINK_POWER_STATE,
- DPCD_SET_POWER_STATE_D0);
- if (ret)
- return ret;
-
/* Set link rate and count as you want to establish*/
exynos_dp_set_link_bandwidth(dp, dp->link_train.link_rate);
exynos_dp_set_lane_count(dp, dp->link_train.lane_count);
--
1.7.7.3
next reply other threads:[~2012-08-08 3:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 3:54 Sean Paul [this message]
2012-08-20 9:19 ` [PATCH 05/10] video: exynos_dp: Remove sink control to D0 Jingoo Han
2012-10-31 17:05 ` Sean Paul
2012-11-01 0:45 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344398064-13563-6-git-send-email-seanpaul@chromium.org \
--to=seanpaul@chromium.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).