From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Date: Thu, 09 Aug 2012 11:56:32 +0000 Subject: [PATCH v2 08/13] OMAPDSS: HDMI: Add locking for hdmi interface get/set timing functions Message-Id: <1344512989-4071-9-git-send-email-archit@ti.com> List-Id: References: <1343817088-29645-1-git-send-email-archit@ti.com> <1344512989-4071-1-git-send-email-archit@ti.com> In-Reply-To: <1344512989-4071-1-git-send-email-archit@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: tomi.valkeinen@ti.com Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, Archit Taneja The hdmi interface driver exposes functions to the hdmi panel driver to get and configure the interface timings maintained by the hdmi driver. These timings(stored in hdmi.ip_data.cfg) should be protected by the hdmi lock to ensure they are called sequentially, this is similar to how hdmi enable and disable functions need locking. Signed-off-by: Archit Taneja --- drivers/video/omap2/dss/hdmi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index f577c8e..171c695 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c @@ -547,7 +547,11 @@ static void hdmi_power_off(struct omap_dss_device *dssdev) void omapdss_hdmi_display_get_timing(struct omap_dss_device *dssdev, struct omap_video_timings *timings) { + mutex_lock(&hdmi.lock); + *timings = hdmi.ip_data.cfg.timings; + + mutex_unlock(&hdmi.lock); } int omapdss_hdmi_display_check_timing(struct omap_dss_device *dssdev, @@ -570,6 +574,8 @@ void omapdss_hdmi_display_set_timing(struct omap_dss_device *dssdev, struct hdmi_cm cm; const struct hdmi_config *t; + mutex_lock(&hdmi.lock); + cm = hdmi_get_code(timings); hdmi.ip_data.cfg.cm = cm; @@ -588,6 +594,8 @@ void omapdss_hdmi_display_set_timing(struct omap_dss_device *dssdev, } else { dss_mgr_set_timings(dssdev->manager, &t->timings); } + + mutex_unlock(&hdmi.lock); } static void hdmi_dump_regs(struct seq_file *s) -- 1.7.9.5