From: Tony Prisk <linux@prisktech.co.nz>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for
Date: Wed, 22 Aug 2012 06:34:38 +0000 [thread overview]
Message-ID: <1345617278.7491.4.camel@gitbox> (raw)
In-Reply-To: <20120821231255.71a7515a@pyramind.ukuu.org.uk>
On Tue, 2012-08-21 at 23:12 +0100, Alan Cox wrote:
> On Wed, 22 Aug 2012 08:47:32 +1200
> Tony Prisk <linux@prisktech.co.nz> wrote:
>
> > Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> > ---
> > drivers/tty/serial/vt8500_serial.c | 37 ++++++++++++++++++++++++++++++++----
> > 1 file changed, 33 insertions(+), 4 deletions(-)
>
> Can we have a comment attached to a change this size. In particular one
> describing why it gone from 4 to 6 ports, and why the port id twiddling.
>
> Is there a reason you can't use the device tree port id ?
>
> What are the regression risks for existing users expecting the pdev->id
> binding ?
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sorry Alan,
The original patch was very simple, but I revisited it to fix other
issues and forgot to add the relevant comments.
Port size is changed to fix a problem - WM8505 actually had 6 uart's
defined in platform data but the vt8500_ports variable was only 4.
I have added devicetree port id support as well.
No regression risks as the entire platform is being converted to
devicetree and existing code dropped in this patchset.
Patchv4 3/9 to follow.
Regards
Tony Prisk
next prev parent reply other threads:[~2012-08-22 6:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 20:47 [PATCHv3 0/9] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-21 20:47 ` [PATCHv3 1/9] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's Tony Prisk
2012-08-21 20:47 ` [PATCHv3 2/9] rtc: vt8500: Add devicetree support for vt8500-rtc Tony Prisk
2012-08-21 20:47 ` [PATCHv3 3/9] serial: vt8500: Add devicetree support for vt8500-serial Tony Prisk
2012-08-21 22:12 ` Alan Cox
2012-08-22 6:34 ` Tony Prisk [this message]
2012-08-22 6:44 ` [PATCHv3 3/9] serial: vt8500: Add devicetree support for Arnd Bergmann
2012-08-23 21:29 ` Rob Landley
2012-08-21 20:47 ` [PATCHv3 4/9] usb: vt8500: Add devicetree support for vt8500-ehci and -uhci Tony Prisk
2012-08-21 20:47 ` [PATCHv3 5/9] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb Tony Prisk
2012-08-21 20:47 ` [PATCHv3 6/9] arm: vt8500: Update arch-vt8500 to devicetree support Tony Prisk
2012-08-21 20:47 ` [PATCHv3 7/9] arm: vt8500: doc: Add device tree bindings for arch-vt8500 devices Tony Prisk
2012-08-22 21:07 ` Stephen Warren
2012-08-22 21:32 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500 Tony Prisk
2012-08-22 9:21 ` [rtc-linux] " Linus Walleij
2012-08-22 13:33 ` Tony Prisk
2012-08-21 20:47 ` [PATCHv3 9/9] arm: vt8500: clk: Add Common Clock Framework support Tony Prisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345617278.7491.4.camel@gitbox \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).