From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <a0393947@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 12/17] OMAPDSS: clean up dss_mgr_set_timings
Date: Wed, 05 Sep 2012 10:41:53 +0000 [thread overview]
Message-ID: <1346841713.32747.6.camel@deskari> (raw)
In-Reply-To: <5047182F.3030507@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]
On Wed, 2012-09-05 at 14:45 +0530, Archit Taneja wrote:
> On Wednesday 05 September 2012 01:55 PM, Tomi Valkeinen wrote:
> > dss_mgr_set_timings() can only be called when the output is not active.
> > This means that most of the code in the function is extra, as there's no
> > need to write the values to registers, etc, because that will be handled
> > when the output will be enabled.
>
> We need to fix dpi_set_timings() before we can make this change. DPI
> still tries to change timings on the fly, i.e, with manager enabled. We
> need to disable and enable the DPI output like we do for other outputs.
Yep, and for HDMI also (I didn't check the others yet).
I think the simplest way to handle this is to only write the dpi.timings
in omapdss_dpi_set_timings, and remove the call to dss_mgr_set_timings.
This is not perfect, as a call to omapdss_dpi_set_timings when the
display is enabled would result in changing the dpi.timings, but the
changes wouldn't be actually in use.
However, there are only a few places where set_timings is called, and we
can make sure in those places to first disable the output and then
enable it again.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-05 10:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 8:25 [PATCH 00/17] Misc OMAP DSS patches part 2 Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 01/17] OMAPDSS: Taal: use devm_* functions Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 02/17] OMAPFB1: remove unnecessary includes Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 03/17] OMAPFB1: remove a non-used table Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 04/17] OMAPDSS: remove unnecessary includes Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 05/17] OMAPFB: clear framebuffers with CPU Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 06/17] OMAPDSS: VRAM: Remove clearing with sDMA Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 07/17] OMAPDSS: Taal: Reogranize for device tree Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 08/17] OMAPDSS: TFP410: use devm_gpio_request_one Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 09/17] OMAPDSS: split overlay sysfs code Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 10/17] OMAPDSS: split manager " Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 11/17] OMAPDSS: clean up dss_mgr_set_lcd_config Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 12/17] OMAPDSS: clean up dss_mgr_set_timings Tomi Valkeinen
2012-09-05 9:27 ` Archit Taneja
2012-09-05 10:41 ` Tomi Valkeinen [this message]
2012-09-05 11:46 ` Archit Taneja
2012-09-05 11:41 ` Tomi Valkeinen
2012-09-05 11:48 ` Archit Taneja
2012-09-07 10:11 ` Tomi Valkeinen
2012-09-07 11:48 ` Archit Taneja
2012-09-05 8:25 ` [PATCH 13/17] Revert "OMAPDSS: APPLY: add fifo-merge support" Tomi Valkeinen
2012-09-05 13:55 ` Archit Taneja
2012-09-06 12:55 ` Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 14/17] Revert "OMAPDSS: APPLY: add fifo merge support funcs" Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 15/17] OMAPDSS: remove extra_info completion code Tomi Valkeinen
2012-09-05 13:43 ` Archit Taneja
2012-09-06 13:04 ` Tomi Valkeinen
2012-09-06 13:47 ` Archit Taneja
2012-09-06 13:42 ` Tomi Valkeinen
2012-09-06 14:13 ` Archit Taneja
2012-09-06 14:29 ` Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 16/17] OMAPDSS: Improve fifo management code Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 17/17] OMAPDSS: Use WB fifo for GFX overlay Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346841713.32747.6.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=a0393947@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).