From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Airlie Date: Tue, 19 May 2015 23:29:00 +0000 Subject: Re: [PATCH v5 1/5] pci: add pci_iomap_wc() variants Message-Id: <1347189446.1486831.1432078140756.JavaMail.zimbra@redhat.com> List-Id: References: <1430415364-19679-1-git-send-email-mcgrof@do-not-panic.com> <20150519224452.GT31666@google.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Luis R. Rodriguez" Cc: Bjorn Helgaas , Tomi Valkeinen , "Michael S. Tsirkin" , Jean-Christophe Plagniol-Villard , Dave Airlie , Daniel Vetter , linux-fbdev , Andy Lutomirski , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Toshi Kani , Suresh Siddha , Ingo Molnar , Thomas Gleixner , Juergen Gross , Daniel Vetter , Antonino Daplas , Dave Hansen , Arnd Bergmann , Stefan Bader , Ville =?utf-8?B?U3lyasOkbMOk?= , Mel Gorman , Vlastimil Babka , Borislav Petkov , Davidlohr Bueso , Konrad Rzeszutek Wilk , Ville =?utf-8?B?U3lyasOkbMOk?= , David Vrabel , Jan Beulich , Roger Pau =?utf-8?Q?Monn=C3=A9?= , xen-devel@lists.xensource.com > On Tue, May 19, 2015 at 4:02 PM, Bjorn Helgaas wrote: > > [-cc Venkatesh (bouncing) > > > > On Tue, May 19, 2015 at 5:46 PM, Luis R. Rodriguez > > wrote: > >> On Tue, May 19, 2015 at 3:44 PM, Bjorn Helgaas > >> wrote: > >>> Acked-by: Bjorn Helgaas > >> > >> Thanks! Who's tree should this go through? > > > > I don't know. This is the only patch that went to linux-pci, so I > > haven't seen the rest. > > Oh I only rev'd a v5 for 1/5 as that's the only one that had feedback > asking for changes. > > Patch v4 2/5 was for "lib: devres: add pcim_iomap_wc() variants", you > had questions about EXPORT_SYMBOL_GPL() and the fact that this is not > yet used. I replied. This patch can then be ignored but again, I'd > hate for folks to go in and try to add a non EXPORT_SYMBOL_GPL() > symbol of this. > > Patches v4 3-5 remain intact, I had addressed it to you, but failed to > Cc linux-pci, I'll go ahead and bounce those now. > > Just today Dave Arlie provided a Reviewed-by to some simple > framebuffer device driver changes. I wonder if these changes should go > through the framebuffer tree provided you already gave the Acked-by > for the PCI parts, or if the PCI parts should go in first and only > later (I guess we'd have to wait) then intake the driver changes that > use the symbol. > > What we decide should likely also apply to the series that adds > pci_ioremap_wc_bar() and makes use of it on drivers. > > Dave, Tomi, any preference? > Maybe send Bjorn a pull request with a tree with the pci changes, and the fb changes reviewed-by me and acked by Tomi. Seems like it could be the simplest path forward. Dave.