* [PATCH 02/10] drivers/video/sunxvr1000.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
@ 2012-09-18 12:07 ` Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 03/10] drivers/video/cg3.c: " Peter Senna Tschudin
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:07 UTC (permalink / raw)
To: FlorianSchandinat
Cc: linux-fbdev, linux-kernel, kernel-janitors, Peter Senna Tschudin
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/sunxvr1000.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/sunxvr1000.c b/drivers/video/sunxvr1000.c
index b7f27ac..729a507 100644
--- a/drivers/video/sunxvr1000.c
+++ b/drivers/video/sunxvr1000.c
@@ -141,8 +141,10 @@ static int __devinit gfb_probe(struct platform_device *op)
gp->fb_base = of_ioremap(&op->resource[6], 0,
gp->fb_size, "gfb fb");
- if (!gp->fb_base)
+ if (!gp->fb_base) {
+ err = -ENOMEM;
goto err_release_fb;
+ }
err = gfb_set_fbinfo(gp);
if (err)
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 03/10] drivers/video/cg3.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 02/10] drivers/video/sunxvr1000.c: " Peter Senna Tschudin
@ 2012-09-18 12:07 ` Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 04/10] drivers/video/sunxvr500.c: " Peter Senna Tschudin
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:07 UTC (permalink / raw)
To: FlorianSchandinat
Cc: linux-fbdev, linux-kernel, kernel-janitors, Peter Senna Tschudin
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/cg3.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/cg3.c b/drivers/video/cg3.c
index f927a7b..c5e7612 100644
--- a/drivers/video/cg3.c
+++ b/drivers/video/cg3.c
@@ -398,7 +398,8 @@ static int __devinit cg3_probe(struct platform_device *op)
goto out_unmap_screen;
}
- if (fb_alloc_cmap(&info->cmap, 256, 0))
+ err = fb_alloc_cmap(&info->cmap, 256, 0);
+ if (err)
goto out_unmap_screen;
fb_set_cmap(&info->cmap, info);
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 04/10] drivers/video/sunxvr500.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 02/10] drivers/video/sunxvr1000.c: " Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 03/10] drivers/video/cg3.c: " Peter Senna Tschudin
@ 2012-09-18 12:07 ` Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 05/10] drivers/video/atmel_lcdfb.c: " Peter Senna Tschudin
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:07 UTC (permalink / raw)
To: FlorianSchandinat
Cc: linux-fbdev, linux-kernel, kernel-janitors, Peter Senna Tschudin
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/sunxvr500.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/video/sunxvr500.c b/drivers/video/sunxvr500.c
index eb931b8..6c71b1b 100644
--- a/drivers/video/sunxvr500.c
+++ b/drivers/video/sunxvr500.c
@@ -298,8 +298,10 @@ static int __devinit e3d_pci_register(struct pci_dev *pdev,
goto err_release_fb;
}
ep->ramdac = ioremap(ep->regs_base_phys + 0x8000, 0x1000);
- if (!ep->ramdac)
+ if (!ep->ramdac) {
+ err = -ENOMEM;
goto err_release_pci1;
+ }
ep->fb8_0_off = readl(ep->ramdac + RAMDAC_VID_8FB_0);
ep->fb8_0_off -= ep->fb_base_reg;
@@ -343,8 +345,10 @@ static int __devinit e3d_pci_register(struct pci_dev *pdev,
ep->fb_size = info->fix.line_length * ep->height;
ep->fb_base = ioremap(ep->fb_base_phys, ep->fb_size);
- if (!ep->fb_base)
+ if (!ep->fb_base) {
+ err = -ENOMEM;
goto err_release_pci0;
+ }
err = e3d_set_fbinfo(ep);
if (err)
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 05/10] drivers/video/atmel_lcdfb.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
` (2 preceding siblings ...)
2012-09-18 12:07 ` [PATCH 04/10] drivers/video/sunxvr500.c: " Peter Senna Tschudin
@ 2012-09-18 12:07 ` Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 06/10] drivers/video/imxfb.c: " Peter Senna Tschudin
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:07 UTC (permalink / raw)
To: nicolas.ferre
Cc: FlorianSchandinat, linux-fbdev, linux-kernel, kernel-janitors,
Peter Senna Tschudin
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/atmel_lcdfb.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 1505539..94cac9f 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -931,8 +931,10 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
}
info->screen_base = ioremap(info->fix.smem_start, info->fix.smem_len);
- if (!info->screen_base)
+ if (!info->screen_base) {
+ ret = -ENOMEM;
goto release_intmem;
+ }
/*
* Don't clear the framebuffer -- someone may have set
@@ -960,6 +962,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
sinfo->mmio = ioremap(info->fix.mmio_start, info->fix.mmio_len);
if (!sinfo->mmio) {
dev_err(dev, "cannot map LCDC registers\n");
+ ret = -ENOMEM;
goto release_mem;
}
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 06/10] drivers/video/imxfb.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
` (3 preceding siblings ...)
2012-09-18 12:07 ` [PATCH 05/10] drivers/video/atmel_lcdfb.c: " Peter Senna Tschudin
@ 2012-09-18 12:07 ` Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 07/10] drivers/video/bw2.c: " Peter Senna Tschudin
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:07 UTC (permalink / raw)
To: linux-arm-kernel
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/imxfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c
index caad368..469b07c 100644
--- a/drivers/video/imxfb.c
+++ b/drivers/video/imxfb.c
@@ -803,6 +803,7 @@ static int __init imxfb_probe(struct platform_device *pdev)
fbi->regs = ioremap(res->start, resource_size(res));
if (fbi->regs = NULL) {
dev_err(&pdev->dev, "Cannot map frame buffer registers\n");
+ ret = -ENOMEM;
goto failed_ioremap;
}
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 07/10] drivers/video/bw2.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
` (4 preceding siblings ...)
2012-09-18 12:07 ` [PATCH 06/10] drivers/video/imxfb.c: " Peter Senna Tschudin
@ 2012-09-18 12:07 ` Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 08/10] drivers/video/cyber2000fb.c: " Peter Senna Tschudin
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:07 UTC (permalink / raw)
To: FlorianSchandinat
Cc: linux-fbdev, linux-kernel, kernel-janitors, Peter Senna Tschudin
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/bw2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/bw2.c b/drivers/video/bw2.c
index 7ba74cd..6bea9a9 100644
--- a/drivers/video/bw2.c
+++ b/drivers/video/bw2.c
@@ -319,8 +319,10 @@ static int __devinit bw2_probe(struct platform_device *op)
info->screen_base = of_ioremap(&op->resource[0], 0,
info->fix.smem_len, "bw2 ram");
- if (!info->screen_base)
+ if (!info->screen_base) {
+ err = -ENOMEM;
goto out_unmap_regs;
+ }
bw2_blank(FB_BLANK_UNBLANK, info);
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 08/10] drivers/video/cyber2000fb.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
` (5 preceding siblings ...)
2012-09-18 12:07 ` [PATCH 07/10] drivers/video/bw2.c: " Peter Senna Tschudin
@ 2012-09-18 12:07 ` Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 09/10] drivers/video/ps3fb.c: " Peter Senna Tschudin
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:07 UTC (permalink / raw)
To: linux-arm-kernel
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/cyber2000fb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/cyber2000fb.c b/drivers/video/cyber2000fb.c
index c1527f5..e40125c 100644
--- a/drivers/video/cyber2000fb.c
+++ b/drivers/video/cyber2000fb.c
@@ -1804,8 +1804,10 @@ cyberpro_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
cfb->irq = dev->irq;
cfb->region = pci_ioremap_bar(dev, 0);
- if (!cfb->region)
+ if (!cfb->region) {
+ err = -ENOMEM;
goto failed_ioremap;
+ }
cfb->regs = cfb->region + MMIO_OFFSET;
cfb->fb.device = &dev->dev;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 09/10] drivers/video/ps3fb.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
` (6 preceding siblings ...)
2012-09-18 12:07 ` [PATCH 08/10] drivers/video/cyber2000fb.c: " Peter Senna Tschudin
@ 2012-09-18 12:07 ` Peter Senna Tschudin
2012-09-18 12:08 ` [PATCH 10/10] drivers/video/arcfb.c: " Peter Senna Tschudin
2012-09-23 19:52 ` [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: " Florian Tobias Schandinat
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:07 UTC (permalink / raw)
To: geoff
Cc: cbe-oss-dev, linux-fbdev, FlorianSchandinat, Peter Senna Tschudin,
kernel-janitors, linux-kernel, linuxppc-dev
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/ps3fb.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
index 4e292f2..0b340d6 100644
--- a/drivers/video/ps3fb.c
+++ b/drivers/video/ps3fb.c
@@ -1034,6 +1034,7 @@ static int __devinit ps3fb_probe(struct ps3_system_bus_device *dev)
if (status) {
dev_err(&dev->core, "%s: lv1_gpu_memory_allocate failed: %d\n",
__func__, status);
+ retval = -ENOMEM;
goto err_close_device;
}
dev_dbg(&dev->core, "ddr:lpar:0x%llx\n", ddr_lpar);
@@ -1046,6 +1047,7 @@ static int __devinit ps3fb_probe(struct ps3_system_bus_device *dev)
dev_err(&dev->core,
"%s: lv1_gpu_context_allocate failed: %d\n", __func__,
status);
+ retval = -ENOMEM;
goto err_gpu_memory_free;
}
@@ -1053,6 +1055,7 @@ static int __devinit ps3fb_probe(struct ps3_system_bus_device *dev)
dinfo = (void __force *)ioremap(lpar_driver_info, 128 * 1024);
if (!dinfo) {
dev_err(&dev->core, "%s: ioremap failed\n", __func__);
+ retval = -ENOMEM;
goto err_gpu_context_free;
}
@@ -1121,8 +1124,10 @@ static int __devinit ps3fb_probe(struct ps3_system_bus_device *dev)
}
info = framebuffer_alloc(sizeof(struct ps3fb_par), &dev->core);
- if (!info)
+ if (!info) {
+ retval = -ENOMEM;
goto err_context_fb_close;
+ }
par = info->par;
par->mode_id = ~ps3fb_mode; /* != ps3fb_mode, to trigger change */
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 10/10] drivers/video/arcfb.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
` (7 preceding siblings ...)
2012-09-18 12:07 ` [PATCH 09/10] drivers/video/ps3fb.c: " Peter Senna Tschudin
@ 2012-09-18 12:08 ` Peter Senna Tschudin
2012-09-23 19:52 ` [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: " Florian Tobias Schandinat
9 siblings, 0 replies; 11+ messages in thread
From: Peter Senna Tschudin @ 2012-09-18 12:08 UTC (permalink / raw)
To: jayalk
Cc: FlorianSchandinat, linux-fbdev, linux-kernel, kernel-janitors,
Peter Senna Tschudin
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/video/arcfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c
index a1d58e9..4659d5d 100644
--- a/drivers/video/arcfb.c
+++ b/drivers/video/arcfb.c
@@ -552,6 +552,7 @@ static int __devinit arcfb_probe(struct platform_device *dev)
"arcfb", info)) {
printk(KERN_INFO
"arcfb: Failed req IRQ %d\n", par->irq);
+ retval = -EBUSY;
goto err1;
}
}
--
1.7.11.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
` (8 preceding siblings ...)
2012-09-18 12:08 ` [PATCH 10/10] drivers/video/arcfb.c: " Peter Senna Tschudin
@ 2012-09-23 19:52 ` Florian Tobias Schandinat
9 siblings, 0 replies; 11+ messages in thread
From: Florian Tobias Schandinat @ 2012-09-23 19:52 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: paul.gortmaker, hsweeten, agust, davidb, linux-fbdev,
linux-kernel, kernel-janitors
Applied all 10 patches of this series.
Thanks,
Florian Tobias Schandinat
On 09/18/2012 12:07 PM, Peter Senna Tschudin wrote:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/video/mb862xx/mb862xxfbdrv.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c b/drivers/video/mb862xx/mb862xxfbdrv.c
> index 57d940b..d68e332 100644
> --- a/drivers/video/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/mb862xx/mb862xxfbdrv.c
> @@ -1052,12 +1052,14 @@ static int __devinit mb862xx_pci_probe(struct pci_dev *pdev,
> break;
> default:
> /* should never occur */
> + ret = -EIO;
> goto rel_reg;
> }
>
> par->fb_base = ioremap(par->fb_base_phys, par->mapped_vram);
> if (par->fb_base = NULL) {
> dev_err(dev, "Cannot map framebuffer\n");
> + ret = -EIO;
> goto rel_reg;
> }
>
> @@ -1073,11 +1075,13 @@ static int __devinit mb862xx_pci_probe(struct pci_dev *pdev,
> dev_dbg(dev, "mmio phys 0x%llx 0x%lx\n",
> (unsigned long long)par->mmio_base_phys, (ulong)par->mmio_len);
>
> - if (mb862xx_pci_gdc_init(par))
> + ret = mb862xx_pci_gdc_init(par);
> + if (ret)
> goto io_unmap;
>
> - if (request_irq(par->irq, mb862xx_intr, IRQF_SHARED,
> - DRV_NAME, (void *)par)) {
> + ret = request_irq(par->irq, mb862xx_intr, IRQF_SHARED,
> + DRV_NAME, (void *)par);
> + if (ret) {
> dev_err(dev, "Cannot request irq\n");
> goto io_unmap;
> }
^ permalink raw reply [flat|nested] 11+ messages in thread