linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Senna Tschudin <peter.senna@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] drivers/video/cyber2000fb.c: fix error return code
Date: Tue, 18 Sep 2012 12:07:58 +0000	[thread overview]
Message-ID: <1347970080-25175-8-git-send-email-peter.senna@gmail.com> (raw)
In-Reply-To: <1347970080-25175-1-git-send-email-peter.senna@gmail.com>

From: Peter Senna Tschudin <peter.senna@gmail.com>

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
 drivers/video/cyber2000fb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/video/cyber2000fb.c b/drivers/video/cyber2000fb.c
index c1527f5..e40125c 100644
--- a/drivers/video/cyber2000fb.c
+++ b/drivers/video/cyber2000fb.c
@@ -1804,8 +1804,10 @@ cyberpro_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 
 	cfb->irq = dev->irq;
 	cfb->region = pci_ioremap_bar(dev, 0);
-	if (!cfb->region)
+	if (!cfb->region) {
+		err = -ENOMEM;
 		goto failed_ioremap;
+	}
 
 	cfb->regs = cfb->region + MMIO_OFFSET;
 	cfb->fb.device = &dev->dev;
-- 
1.7.11.4


  parent reply	other threads:[~2012-09-18 12:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 12:07 [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 02/10] drivers/video/sunxvr1000.c: " Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 03/10] drivers/video/cg3.c: " Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 04/10] drivers/video/sunxvr500.c: " Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 05/10] drivers/video/atmel_lcdfb.c: " Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 06/10] drivers/video/imxfb.c: " Peter Senna Tschudin
2012-09-18 12:07 ` [PATCH 07/10] drivers/video/bw2.c: " Peter Senna Tschudin
2012-09-18 12:07 ` Peter Senna Tschudin [this message]
2012-09-18 12:07 ` [PATCH 09/10] drivers/video/ps3fb.c: " Peter Senna Tschudin
2012-09-18 12:08 ` [PATCH 10/10] drivers/video/arcfb.c: " Peter Senna Tschudin
2012-09-23 19:52 ` [PATCH 01/10] drivers/video/mb862xx/mb862xxfbdrv.c: " Florian Tobias Schandinat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347970080-25175-8-git-send-email-peter.senna@gmail.com \
    --to=peter.senna@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).