Re: [PATCH v3] video: Versatile Express DVI output driver

[Pawel Moll <pawel.moll@arm.com>]

On Mon, 2012-11-19 at 15:43 +0000, Arnd Bergmann wrote:
> * vexpress_dvi_fb_select uses the 'fb' argument as an index into
>   the registered_fb array, but does not check for overflow against
>   FB_MAX. 

Uh, right. Will fix in a second.

> I think you need to use get_fb_info().

I was considering this, but it's a static. And I don't want to change
the fb core, as I'm planning to plug this driver into the "Generic
Panel/Display Framework" [1] that Laurent is working on when it's
available. Then I won't have to hack into the core at all...

[1] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/52565

> * There is no documentation for the newly introduced sysfs interface.

Hm, I didn't want to do that, as it's currently just a debug feature -
there is no class symlink to the device available
(Documentation/ABI/testing/sysfs-devices) so there's no universal way of
describing the path to the device.

I'll do my best and post v4 soon.

Paweł