From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: devicetree-discuss@lists.ozlabs.org
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Rob Herring <robherring2@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Guennady Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
kernel@pengutronix.de,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
David Airlie <airlied@linux.ie>, Rob Clark <robdclark@gmail.com>,
Leela Krishna Amudala <leelakrishna.a@gmail.com>
Subject: [PATCHv16 7/7] drm_modes: add of_videomode helpers
Date: Tue, 18 Dec 2012 17:04:16 +0000 [thread overview]
Message-ID: <1355850256-16135-8-git-send-email-s.trumtrar@pengutronix.de> (raw)
In-Reply-To: <1355850256-16135-1-git-send-email-s.trumtrar@pengutronix.de>
Add helper to get drm_display_mode from devicetree.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
Tested-by: Thierry Reding <thierry.reding@avionic-design.de>
Tested-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/drm_modes.c | 33 +++++++++++++++++++++++++++++++++
include/drm/drmP.h | 4 ++++
2 files changed, 37 insertions(+)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 184a22d..fd53454 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -35,6 +35,7 @@
#include <linux/export.h>
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
+#include <video/of_videomode.h>
#include <video/videomode.h>
/**
@@ -541,6 +542,38 @@ int drm_display_mode_from_videomode(const struct videomode *vm,
EXPORT_SYMBOL_GPL(drm_display_mode_from_videomode);
#endif
+#if IS_ENABLED(CONFIG_OF_VIDEOMODE)
+/**
+ * of_get_drm_display_mode - get a drm_display_mode from devicetree
+ * @np: device_node with the timing specification
+ * @dmode: will be set to the return value
+ * @index: index into the list of display timings in devicetree
+ *
+ * This function is expensive and should only be used, if only one mode is to be
+ * read from DT. To get multiple modes start with of_get_display_timings and
+ * work with that instead.
+ */
+int of_get_drm_display_mode(struct device_node *np,
+ struct drm_display_mode *dmode, int index)
+{
+ struct videomode vm;
+ int ret;
+
+ ret = of_get_videomode(np, &vm, index);
+ if (ret)
+ return ret;
+
+ drm_display_mode_from_videomode(&vm, dmode);
+
+ pr_debug("%s: got %dx%d display mode from %s\n",
+ of_node_full_name(np), vm.hactive, vm.vactive, np->name);
+ drm_mode_debug_printmodeline(dmode);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(of_get_drm_display_mode);
+#endif
+
/**
* drm_mode_set_name - set the name on a mode
* @mode: name will be set in this mode
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 5fbb0fe..e26ca59 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -85,6 +85,7 @@ struct module;
struct drm_file;
struct drm_device;
+struct device_node;
struct videomode;
#include <drm/drm_os_linux.h>
@@ -1458,6 +1459,9 @@ drm_mode_create_from_cmdline_mode(struct drm_device *dev,
extern int drm_display_mode_from_videomode(const struct videomode *vm,
struct drm_display_mode *dmode);
+extern int of_get_drm_display_mode(struct device_node *np,
+ struct drm_display_mode *dmode,
+ int index);
/* Modesetting support */
extern void drm_vblank_pre_modeset(struct drm_device *dev, int crtc);
--
1.7.10.4
next prev parent reply other threads:[~2012-12-18 17:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 16:57 [PATCHv16 0/7] of: add display helper Steffen Trumtrar
2012-12-18 16:57 ` [PATCHv16 1/7] viafb: rename display_timing to via_display_timing Steffen Trumtrar
2012-12-18 16:57 ` [PATCHv16 2/7] video: add display_timing and videomode Steffen Trumtrar
2012-12-18 16:57 ` [PATCHv16 3/7] video: add of helper for display timings/videomode Steffen Trumtrar
2012-12-18 16:57 ` [PATCHv16 4/7] fbmon: add videomode helpers Steffen Trumtrar
2012-12-18 16:57 ` [PATCHv16 5/7] fbmon: add of_videomode helpers Steffen Trumtrar
2012-12-18 16:57 ` [PATCHv16 6/7] drm_modes: add videomode helpers Steffen Trumtrar
2012-12-18 16:57 ` [PATCHv16 7/7] drm_modes: add of_videomode helpers Steffen Trumtrar
2012-12-18 17:04 ` [PATCHv16 0/7] of: add display helper Steffen Trumtrar
2012-12-18 17:04 ` [PATCHv16 1/7] viafb: rename display_timing to via_display_timing Steffen Trumtrar
2012-12-18 17:04 ` [PATCHv16 2/7] video: add display_timing and videomode Steffen Trumtrar
2012-12-18 17:04 ` [PATCHv16 3/7] video: add of helper for display timings/videomode Steffen Trumtrar
2012-12-18 17:04 ` [PATCHv16 4/7] fbmon: add videomode helpers Steffen Trumtrar
2012-12-18 17:04 ` [PATCHv16 5/7] fbmon: add of_videomode helpers Steffen Trumtrar
[not found] ` <1355850256-16135-6-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-07 6:10 ` Mohammed, Afzal
2013-01-07 8:06 ` Steffen Trumtrar
[not found] ` <20130107080648.GB23478-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-07 8:46 ` Mohammed, Afzal
2013-01-07 20:06 ` Rob Clark
2013-01-08 5:31 ` Mohammed, Afzal
2012-12-18 17:04 ` [PATCHv16 6/7] drm_modes: add videomode helpers Steffen Trumtrar
2012-12-18 17:04 ` Steffen Trumtrar [this message]
[not found] ` <1355850256-16135-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-12-21 15:48 ` [PATCHv16 0/7] of: add display helper Leela Krishna Amudala
2013-01-07 6:23 ` Mohammed, Afzal
2013-01-07 7:46 ` Steffen Trumtrar
2013-01-09 19:12 ` Marek Vasut
2013-01-09 19:39 ` Steffen Trumtrar
2013-01-09 19:56 ` Marek Vasut
2013-01-09 20:15 ` Steffen Trumtrar
[not found] ` <20130109201541.GB4780-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-09 20:37 ` Thierry Reding
2013-01-09 20:42 ` Laurent Pinchart
2013-01-09 20:59 ` Marek Vasut
2013-01-10 2:52 ` Leela Krishna Amudala
2013-01-10 4:58 ` Mohammed, Afzal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355850256-16135-8-git-send-email-s.trumtrar@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=FlorianSchandinat@gmx.de \
--cc=airlied@linux.ie \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=g.liakhovetski@gmx.de \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leelakrishna.a@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robherring2@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).