* [PATCH 1/1] video: exynos_mipi_dsi: Fix an error check condition
@ 2013-01-02 11:12 Sachin Kamat
2013-01-03 0:35 ` Donghwa Lee
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2013-01-02 11:12 UTC (permalink / raw)
To: linux-fbdev
Checking an unsigned variable for negative value returns false.
Hence use the macro to fix it.
Fixes the following smatch warning:
drivers/video/exynos/exynos_mipi_dsi.c:417 exynos_mipi_dsi_probe()
warn: unsigned 'dsim->irq' is never less than zero.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/video/exynos/exynos_mipi_dsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
index 4a17cdc..f623dfc 100644
--- a/drivers/video/exynos/exynos_mipi_dsi.c
+++ b/drivers/video/exynos/exynos_mipi_dsi.c
@@ -414,7 +414,7 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
}
dsim->irq = platform_get_irq(pdev, 0);
- if (dsim->irq < 0) {
+ if (IS_ERR_VALUE(dsim->irq)) {
dev_err(&pdev->dev, "failed to request dsim irq resource\n");
ret = -EINVAL;
goto err_platform_get_irq;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] video: exynos_mipi_dsi: Fix an error check condition
2013-01-02 11:12 [PATCH 1/1] video: exynos_mipi_dsi: Fix an error check condition Sachin Kamat
@ 2013-01-03 0:35 ` Donghwa Lee
0 siblings, 0 replies; 2+ messages in thread
From: Donghwa Lee @ 2013-01-03 0:35 UTC (permalink / raw)
To: linux-fbdev
On 01/02/2013 20:00, Sachin Kamat wrote:
> Checking an unsigned variable for negative value returns false.
> Hence use the macro to fix it.
>
> Fixes the following smatch warning:
> drivers/video/exynos/exynos_mipi_dsi.c:417 exynos_mipi_dsi_probe()
> warn: unsigned 'dsim->irq' is never less than zero.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/video/exynos/exynos_mipi_dsi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
> index 4a17cdc..f623dfc 100644
> --- a/drivers/video/exynos/exynos_mipi_dsi.c
> +++ b/drivers/video/exynos/exynos_mipi_dsi.c
> @@ -414,7 +414,7 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
> }
>
> dsim->irq = platform_get_irq(pdev, 0);
> - if (dsim->irq < 0) {
> + if (IS_ERR_VALUE(dsim->irq)) {
> dev_err(&pdev->dev, "failed to request dsim irq resource\n");
> ret = -EINVAL;
> goto err_platform_get_irq;
Hi,
It looks good to me.
Acked-by: Donghwa Lee <dh09.lee@samsung.com>
Thank you,
Donghwa Lee
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-03 0:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-02 11:12 [PATCH 1/1] video: exynos_mipi_dsi: Fix an error check condition Sachin Kamat
2013-01-03 0:35 ` Donghwa Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).