linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: linux-kernel@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org,
	Bernie Thompson <bernie@plugable.com>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Steve Glendinning <steve.glendinning@shawell.net>,
	Dave Airlie <airlied@redhat.com>,
	Alexander Holler <holler@ahsoftware.de>,
	stable@vger.kernel.org
Subject: [PATCH] fb: udlfb: fix hang at disconnect
Date: Sat, 12 Jan 2013 13:20:22 +0000	[thread overview]
Message-ID: <1357996822-13072-1-git-send-email-holler@ahsoftware.de> (raw)

When a device was disconnected the driver may hang at waiting for urbs it never
will get. Fix this by using a timeout while waiting for the used semaphore.

There is still a memory leak if a timeout happens, but at least the driver
now continues his disconnect routine.

Cc: <stable@vger.kernel.org>
Signed-off-by: Alexander Holler <holler@ahsoftware.de>
---
 drivers/video/udlfb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
index 86d449e..cc4a8d1 100644
--- a/drivers/video/udlfb.c
+++ b/drivers/video/udlfb.c
@@ -1832,8 +1832,8 @@ static void dlfb_free_urb_list(struct dlfb_data *dev)
 	/* keep waiting and freeing, until we've got 'em all */
 	while (count--) {
 
-		/* Getting interrupted means a leak, but ok at disconnect */
-		ret = down_interruptible(&dev->urbs.limit_sem);
+		/* Timeout likely occurs at disconnect (resulting in a leak) */
+		ret = down_timeout(&dev->urbs.limit_sem, GET_URB_TIMEOUT);
 		if (ret)
 			break;
 
-- 
1.7.11.7


             reply	other threads:[~2013-01-12 13:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-12 13:20 Alexander Holler [this message]
2013-01-12 22:22 ` [PATCH] fb: udlfb: fix hang at disconnect Bernie Thompson
2013-01-13 12:05   ` Alexander Holler
2013-01-13 12:24     ` Alexander Holler
2013-01-25 18:49     ` [PATCH 1/3] semaphore: introduce down_timeout_killable() Alexander Holler
2013-01-25 18:49       ` [PATCH 2/3 v2] fb: udlfb: fix hang at disconnect Alexander Holler
2013-01-29  0:22         ` Andrew Morton
2013-01-29  0:56           ` Alexander Holler
2013-01-29 10:35             ` Alexander Holler
2013-01-29 11:11               ` Alexander Holler
2013-01-29 15:51                 ` Alexander Holler
2013-01-29 20:35                   ` Alexander Holler
2013-01-29 20:56                     ` Alexander Holler
2013-02-04  1:14                     ` Greg KH
2013-02-04 12:05                       ` Alexander Holler
2013-02-04 19:17                         ` Alexander Holler
2013-02-04 19:25                           ` Greg KH
2013-02-05  7:08                             ` Alexander Holler
2013-02-05 17:22                               ` Greg KH
2013-02-05 17:36                                 ` Alexander Holler
2013-02-08  4:07                                   ` Dave Airlie
2013-02-08  9:53                                     ` Alexander Holler
2013-01-25 18:49       ` [PATCH 3/3] fb: smscufx: " Alexander Holler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357996822-13072-1-git-send-email-holler@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=FlorianSchandinat@gmx.de \
    --cc=airlied@redhat.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bernie@plugable.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=steve.glendinning@shawell.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).