From mboxrd@z Thu Jan 1 00:00:00 1970 From: Devendra Naga Date: Mon, 11 Mar 2013 23:27:34 +0000 Subject: [PATCH v2] video: backlight: adp5520: fix compiler warning in adp5520_show Message-Id: <1363044454-25111-1-git-send-email-devendra.aaru@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-fbdev@vger.kernel.org while compiling with make W=1 (gcc gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)) found the following warning drivers/video/backlight/adp5520_bl.c: In function ‘adp5520_show’: drivers/video/backlight/adp5520_bl.c:146:6: warning: variable ‘error’ set but not used [-Wunused-but-set-variable] fixed by checking the return value of the variable Cc: Jingoo Han Cc: Michael Hennerich Cc: Richard Purdie Signed-off-by: Devendra Naga --- drivers/video/backlight/adp5520_bl.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/adp5520_bl.c b/drivers/video/backlight/adp5520_bl.c index a1e41d4..d923f23 100644 --- a/drivers/video/backlight/adp5520_bl.c +++ b/drivers/video/backlight/adp5520_bl.c @@ -143,13 +143,16 @@ static int adp5520_bl_setup(struct backlight_device *bl) static ssize_t adp5520_show(struct device *dev, char *buf, int reg) { struct adp5520_bl *data = dev_get_drvdata(dev); - int error; + int ret; uint8_t reg_val; mutex_lock(&data->lock); - error = adp5520_read(data->master, reg, ®_val); + ret = adp5520_read(data->master, reg, ®_val); mutex_unlock(&data->lock); + if (ret < 0) + return ret; + return sprintf(buf, "%u\n", reg_val); } -- 1.8.1.2