From: Wolfram Sang <wsa@the-dreams.de>
To: linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: [RFC 33/42] drivers/video/omap2: don't check resource with devm_ioremap_resource
Date: Fri, 10 May 2013 08:17:18 +0000 [thread overview]
Message-ID: <1368173847-5661-34-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1368173847-5661-1-git-send-email-wsa@the-dreams.de>
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/video/omap2/vrfb.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/video/omap2/vrfb.c b/drivers/video/omap2/vrfb.c
index 5261229..f346b02 100644
--- a/drivers/video/omap2/vrfb.c
+++ b/drivers/video/omap2/vrfb.c
@@ -353,11 +353,6 @@ static int __init vrfb_probe(struct platform_device *pdev)
/* first resource is the register res, the rest are vrfb contexts */
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!mem) {
- dev_err(&pdev->dev, "can't get vrfb base address\n");
- return -EINVAL;
- }
-
vrfb_base = devm_ioremap_resource(&pdev->dev, mem);
if (IS_ERR(vrfb_base))
return PTR_ERR(vrfb_base);
--
1.7.10.4
next prev parent reply other threads:[~2013-05-10 8:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368173847-5661-1-git-send-email-wsa@the-dreams.de>
2013-05-10 8:17 ` [RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource Wolfram Sang
2013-05-11 5:33 ` Jingoo Han
2013-05-13 5:39 ` Shawn Guo
2013-05-10 8:17 ` Wolfram Sang [this message]
2013-05-11 5:37 ` [RFC 33/42] drivers/video/omap2: " Jingoo Han
2013-05-10 8:17 ` [RFC 34/42] drivers/video/omap2/dss: " Wolfram Sang
2013-05-11 5:36 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368173847-5661-34-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=FlorianSchandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).