From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Date: Fri, 10 May 2013 08:17:19 +0000 Subject: [RFC 34/42] drivers/video/omap2/dss: don't check resource with devm_ioremap_resource Message-Id: <1368173847-5661-35-git-send-email-wsa@the-dreams.de> List-Id: References: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> In-Reply-To: <1368173847-5661-1-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , Tomi Valkeinen , Florian Tobias Schandinat , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/video/omap2/dss/hdmi.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index 17f4d55..7bc6762 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c @@ -1064,13 +1064,8 @@ static int omapdss_hdmihw_probe(struct platform_device *pdev) mutex_init(&hdmi.lock); mutex_init(&hdmi.ip_data.lock); - res = platform_get_resource(hdmi.pdev, IORESOURCE_MEM, 0); - if (!res) { - DSSERR("can't get IORESOURCE_MEM HDMI\n"); - return -EINVAL; - } - /* Base address taken from platform */ + res = platform_get_resource(hdmi.pdev, IORESOURCE_MEM, 0); hdmi.ip_data.base_wp = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(hdmi.ip_data.base_wp)) return PTR_ERR(hdmi.ip_data.base_wp); -- 1.7.10.4