* [PATCH 25/33] drivers/video/omap2: don't check resource with devm_ioremap_resource [not found] <1368702961-4325-1-git-send-email-wsa@the-dreams.de> @ 2013-05-16 11:15 ` Wolfram Sang 2013-05-16 11:15 ` [PATCH 26/33] drivers/video/omap2/dss: " Wolfram Sang 1 sibling, 0 replies; 2+ messages in thread From: Wolfram Sang @ 2013-05-16 11:15 UTC (permalink / raw) To: linux-kernel Cc: Wolfram Sang, Tomi Valkeinen, Florian Tobias Schandinat, linux-omap, linux-fbdev devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/video/omap2/vrfb.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/video/omap2/vrfb.c b/drivers/video/omap2/vrfb.c index 5261229..f346b02 100644 --- a/drivers/video/omap2/vrfb.c +++ b/drivers/video/omap2/vrfb.c @@ -353,11 +353,6 @@ static int __init vrfb_probe(struct platform_device *pdev) /* first resource is the register res, the rest are vrfb contexts */ mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) { - dev_err(&pdev->dev, "can't get vrfb base address\n"); - return -EINVAL; - } - vrfb_base = devm_ioremap_resource(&pdev->dev, mem); if (IS_ERR(vrfb_base)) return PTR_ERR(vrfb_base); -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 26/33] drivers/video/omap2/dss: don't check resource with devm_ioremap_resource [not found] <1368702961-4325-1-git-send-email-wsa@the-dreams.de> 2013-05-16 11:15 ` [PATCH 25/33] drivers/video/omap2: don't check resource with devm_ioremap_resource Wolfram Sang @ 2013-05-16 11:15 ` Wolfram Sang 1 sibling, 0 replies; 2+ messages in thread From: Wolfram Sang @ 2013-05-16 11:15 UTC (permalink / raw) To: linux-kernel Cc: Wolfram Sang, Tomi Valkeinen, Florian Tobias Schandinat, linux-omap, linux-fbdev devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/video/omap2/dss/hdmi.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index 17f4d55..a109934 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c @@ -1065,10 +1065,6 @@ static int omapdss_hdmihw_probe(struct platform_device *pdev) mutex_init(&hdmi.ip_data.lock); res = platform_get_resource(hdmi.pdev, IORESOURCE_MEM, 0); - if (!res) { - DSSERR("can't get IORESOURCE_MEM HDMI\n"); - return -EINVAL; - } /* Base address taken from platform */ hdmi.ip_data.base_wp = devm_ioremap_resource(&pdev->dev, res); -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-16 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1368702961-4325-1-git-send-email-wsa@the-dreams.de>
2013-05-16 11:15 ` [PATCH 25/33] drivers/video/omap2: don't check resource with devm_ioremap_resource Wolfram Sang
2013-05-16 11:15 ` [PATCH 26/33] drivers/video/omap2/dss: " Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).