From: Mike Galbraith <bitbucket@online.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] video: hx8357: Make IM pins optional
Date: Tue, 16 Jul 2013 03:29:40 +0000 [thread overview]
Message-ID: <1373945380.7549.26.camel@marge.simpson.net> (raw)
In-Reply-To: <003501ce81be$4a945ed0$dfbd1c70$@samsung.com>
On Tue, 2013-07-16 at 09:49 +0900, Jingoo Han wrote:
> On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote:
> > +
> > + ret = devm_gpio_request_one(&spi->dev, lcd->im_pins[i],
> > + GPIOF_OUT_INIT_LOW, "im_pins");
>
> This makes a checkpatch warning such as 'WARNING: line over 80 characters'.
> How about the following?
>
> ret = devm_gpio_request_one(&spi->dev, lcd->im_pins[i],
> GPIOF_OUT_INIT_LOW, "im_pins");
IIRC, some maintainers gripe (davem?) when they see such alignment,
preferring the original arg below arg alignment vs strict 80 column.
-Mike
next prev parent reply other threads:[~2013-07-16 3:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 15:26 [PATCH 0/3] Few ignored framebuffer fixes/additions Maxime Ripard
2013-07-15 15:27 ` [PATCH 1/3] video: mxsfb: fix color settings for 18bit data bus and 32bpp Maxime Ripard
2013-07-15 15:27 ` [PATCH 2/3] video: hx8357: Make IM pins optional Maxime Ripard
2013-07-16 0:49 ` Jingoo Han
2013-07-16 3:29 ` Mike Galbraith [this message]
2013-07-19 8:35 ` 'Maxime Ripard'
2013-07-22 8:30 ` Jingoo Han
2013-07-15 15:27 ` [PATCH 3/3] fb: backlight: HX8357: Add HX8369 support Maxime Ripard
2013-07-16 2:04 ` Jingoo Han
2013-07-16 15:46 ` 'Maxime Ripard'
2013-07-17 21:37 ` [PATCH 0/3] Few ignored framebuffer fixes/additions Andrew Morton
2013-07-19 8:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373945380.7549.26.camel@marge.simpson.net \
--to=bitbucket@online.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).