* [PATCH] vga16fb: Remove unused variable
@ 2013-07-10 22:57 Luis Henriques
2013-07-22 15:41 ` [PATCH] vga16fb: remove " andi.shyti
2013-07-26 7:30 ` [PATCH] vga16fb: Remove " Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Luis Henriques @ 2013-07-10 22:57 UTC (permalink / raw)
To: linux-fbdev
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-kernel
Fix build warning of unused variable:
drivers/video/vga16fb.c:1268:26: warning: unused variable ‘dev’ [-Wunused-variable]
Signed-off-by: Luis Henriques<luis.henriques@canonical.com>
---
drivers/video/vga16fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
static void vga16fb_destroy(struct fb_info *info)
{
- struct platform_device *dev = container_of(info->device, struct platform_device, dev);
iounmap(info->screen_base);
fb_dealloc_cmap(&info->cmap);
/* XXX unshare VGA regions */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] vga16fb: remove unused variable
2013-07-10 22:57 [PATCH] vga16fb: Remove unused variable Luis Henriques
@ 2013-07-22 15:41 ` andi.shyti
2013-07-26 7:30 ` [PATCH] vga16fb: Remove " Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: andi.shyti @ 2013-07-22 15:41 UTC (permalink / raw)
To: plagnioj, tomi.valkeinen; +Cc: linux-fbdev, linux-kernel, andi, andi.shyti
From: Andi Shyti <andi.shyti@gmail.com>
This patch gets rid of the following warning:
drivers/video/vga16fb.c: In function ‘vga16fb_destroy’:
drivers/video/vga16fb.c:1268:26: warning: unused variable ‘dev’ [-Wunused-variable]
struct platform_device *dev = container_of(info->device, struct platform_device, dev);
^
As described, the 'dev' variable is no longer used, therefore it
can be removed.
Signed-off-by: Andi Shyti <andi.shyti@gmail.com>
---
drivers/video/vga16fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
static void vga16fb_destroy(struct fb_info *info)
{
- struct platform_device *dev = container_of(info->device, struct platform_device, dev);
iounmap(info->screen_base);
fb_dealloc_cmap(&info->cmap);
/* XXX unshare VGA regions */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vga16fb: Remove unused variable
2013-07-10 22:57 [PATCH] vga16fb: Remove unused variable Luis Henriques
2013-07-22 15:41 ` [PATCH] vga16fb: remove " andi.shyti
@ 2013-07-26 7:30 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2013-07-26 7:30 UTC (permalink / raw)
To: Luis Henriques
Cc: linux-fbdev, Jean-Christophe Plagniol-Villard, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
On 11/07/13 01:57, Luis Henriques wrote:
> Fix build warning of unused variable:
>
> drivers/video/vga16fb.c:1268:26: warning: unused variable ‘dev’ [-Wunused-variable]
>
> Signed-off-by: Luis Henriques<luis.henriques@canonical.com>
> ---
> drivers/video/vga16fb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>
> static void vga16fb_destroy(struct fb_info *info)
> {
> - struct platform_device *dev = container_of(info->device, struct platform_device, dev);
> iounmap(info->screen_base);
> fb_dealloc_cmap(&info->cmap);
> /* XXX unshare VGA regions */
>
Thanks, I've applied this into my 3.12/fbdev branch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-26 7:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-10 22:57 [PATCH] vga16fb: Remove unused variable Luis Henriques
2013-07-22 15:41 ` [PATCH] vga16fb: remove " andi.shyti
2013-07-26 7:30 ` [PATCH] vga16fb: Remove " Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).