Re: [PATCH 7/9] fbdev: sh_mobile_lcdc: Support horizontal panning

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Damian,

Thank you for the review.

On Thursday 19 July 2012 10:40:03 Damian Hobson-Garcia wrote:
> On 2012/07/19 9:39, Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > 
> >  drivers/video/sh_mobile_lcdcfb.c |   22 ++++++++++++++++------
> >  1 files changed, 16 insertions(+), 6 deletions(-)
> > 
> > -	if (ovl->format->fourcc = V4L2_PIX_FMT_NV12 ||
> > -	    ovl->format->fourcc = V4L2_PIX_FMT_NV21)
> > +	switch (ovl->format->fourcc) {
> > +	case V4L2_PIX_FMT_NV16:
> > +	case V4L2_PIX_FMT_NV61:
> > +		info->fix.xpanstep = 2;
> > +	case V4L2_PIX_FMT_NV12:
> > +	case V4L2_PIX_FMT_NV21:
> >  		info->fix.ypanstep = 2;
> > +	}
> > 
> > 
> > -	if (ch->format->fourcc = V4L2_PIX_FMT_NV12 ||
> > -	    ch->format->fourcc = V4L2_PIX_FMT_NV21)
> > +	switch (ch->format->fourcc) {
> > +	case V4L2_PIX_FMT_NV16:
> > +	case V4L2_PIX_FMT_NV61:
> > +		info->fix.xpanstep = 2;
> > +	case V4L2_PIX_FMT_NV12:
> > +	case V4L2_PIX_FMT_NV21:
> >  		info->fix.ypanstep = 2;
> > +	}
> 
> I think that the panstep settings are backwards.  The pansteps should be
> NV16: x = 2, y = 1; NV12: x = 2, y = 2.

Good catch, thanks. I've fixed that.

-- 
Regards,

Laurent Pinchart