[PATCH] video/ps3fb: Fix section mismatch warning

[PATCH] video/ps3fb: Fix section mismatch warning

[Geoff Levand]

Remove the __initdata attribute from the ps3fb_fix variable.  This is in
follow up to the removal of the __devinit attribute on the ps3fb_probe()
routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
video: remove __dev* attributes).

Fixes build warnings like these:

  WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix
  The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
  This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.

Signed-off-by: Geoff Levand <geoff@infradead.org>
---
 drivers/video/ps3fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
index a397271d..4819cdf 100644
--- a/drivers/video/ps3fb.c
+++ b/drivers/video/ps3fb.c
@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = {
 	.fb_compat_ioctl = ps3fb_ioctl
 };
 
-static struct fb_fix_screeninfo ps3fb_fix __initdata = {
+static struct fb_fix_screeninfo ps3fb_fix = {
 	.id =		DEVICE_NAME,
 	.type =		FB_TYPE_PACKED_PIXELS,
 	.visual =	FB_VISUAL_TRUECOLOR,
-- 
1.8.1.2

Re: [PATCH] video/ps3fb: Fix section mismatch warning

[Geert Uytterhoeven]

On Tue, May 21, 2013 at 3:01 PM, Geoff Levand <geoff@infradead.org> wrote:
> Remove the __initdata attribute from the ps3fb_fix variable.  This is in
> follow up to the removal of the __devinit attribute on the ps3fb_probe()
> routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
> video: remove __dev* attributes).
>
> Fixes build warnings like these:
>
>   WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix
>   The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
>   This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH] video/ps3fb: Fix section mismatch warning

[Geoff Levand]

Remove the __initdata attribute from the ps3fb_fix variable.  This is in
follow up to the removal of the __devinit attribute on the ps3fb_probe()
routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
video: remove __dev* attributes).

Fixes build warnings like these:

  WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix
  The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
  This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.

Signed-off-by: Geoff Levand <geoff@infradead.org>
---

This is a re-send.  Could we please get this applied.

-Geoff

 drivers/video/ps3fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
index a397271d..4819cdf 100644
--- a/drivers/video/ps3fb.c
+++ b/drivers/video/ps3fb.c
@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = {
        .fb_compat_ioctl = ps3fb_ioctl
 };
 
-static struct fb_fix_screeninfo ps3fb_fix __initdata = {
+static struct fb_fix_screeninfo ps3fb_fix = {
        .id =           DEVICE_NAME,
        .type =         FB_TYPE_PACKED_PIXELS,
        .visual =       FB_VISUAL_TRUECOLOR,
-- 
1.8.1.2

Re: [PATCH] video/ps3fb: Fix section mismatch warning

[Jingoo Han]

On Wednesday, September 11, 2013 7:00 AM, Geoff Levand  wrote:
> 
> Remove the __initdata attribute from the ps3fb_fix variable.  This is in
> follow up to the removal of the __devinit attribute on the ps3fb_probe()
> routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
> video: remove __dev* attributes).
> 
> Fixes build warnings like these:
> 
>   WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the
> variable .init.data:ps3fb_fix
>   The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
>   This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is
> wrong.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>


CC'ed Jean-Christophe Plagniol-Villard, Tomi Valkeinen (Framebuffer maintainer)

Currently, the maintainers of FRAMEBUFFER LAYER are
Jean-Christophe Plagniol-Villard, and Tomi Valkeinen.
So, I CC'ed them.

Best regards,
Jingoo Han

> ---
> 
> This is a re-send.  Could we please get this applied.
> 
> -Geoff
> 
>  drivers/video/ps3fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
> index a397271d..4819cdf 100644
> --- a/drivers/video/ps3fb.c
> +++ b/drivers/video/ps3fb.c
> @@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = {
>         .fb_compat_ioctl = ps3fb_ioctl
>  };
> 
> -static struct fb_fix_screeninfo ps3fb_fix __initdata = {
> +static struct fb_fix_screeninfo ps3fb_fix = {
>         .id =           DEVICE_NAME,
>         .type =         FB_TYPE_PACKED_PIXELS,
>         .visual =       FB_VISUAL_TRUECOLOR,
> --
> 1.8.1.2
> 

Re: [PATCH] video/ps3fb: Fix section mismatch warning

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

On 21/05/13 16:01, Geoff Levand wrote:
> Remove the __initdata attribute from the ps3fb_fix variable.  This is in
> follow up to the removal of the __devinit attribute on the ps3fb_probe()
> routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
> video: remove __dev* attributes).
> 
> Fixes build warnings like these:
> 
>   WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix
>   The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
>   This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
>  drivers/video/ps3fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
> index a397271d..4819cdf 100644
> --- a/drivers/video/ps3fb.c
> +++ b/drivers/video/ps3fb.c
> @@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = {
>  	.fb_compat_ioctl = ps3fb_ioctl
>  };
>  
> -static struct fb_fix_screeninfo ps3fb_fix __initdata = {
> +static struct fb_fix_screeninfo ps3fb_fix = {
>  	.id =		DEVICE_NAME,
>  	.type =		FB_TYPE_PACKED_PIXELS,
>  	.visual =	FB_VISUAL_TRUECOLOR,
> 

Thanks, applied for 3.13.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

Re: [PATCH] video/ps3fb: Fix section mismatch warning

[Geert Uytterhoeven]

On Mon, Sep 16, 2013 at 11:20 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 21/05/13 16:01, Geoff Levand wrote:
>> Remove the __initdata attribute from the ps3fb_fix variable.  This is in
>> follow up to the removal of the __devinit attribute on the ps3fb_probe()
>> routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
>> video: remove __dev* attributes).
>>
>> Fixes build warnings like these:
>>
>>   WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix
>>   The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
>>   This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
>>
>> Signed-off-by: Geoff Levand <geoff@infradead.org>
>
> Thanks, applied for 3.13.

Too late. It already got in last week through Cell and PS3 supporter BenH ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] video/ps3fb: Fix section mismatch warning

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On 16/09/13 12:28, Geert Uytterhoeven wrote:
> On Mon, Sep 16, 2013 at 11:20 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 21/05/13 16:01, Geoff Levand wrote:
>>> Remove the __initdata attribute from the ps3fb_fix variable.  This is in
>>> follow up to the removal of the __devinit attribute on the ps3fb_probe()
>>> routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
>>> video: remove __dev* attributes).
>>>
>>> Fixes build warnings like these:
>>>
>>>   WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix
>>>   The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
>>>   This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
>>>
>>> Signed-off-by: Geoff Levand <geoff@infradead.org>
>>
>> Thanks, applied for 3.13.
> 
> Too late. It already got in last week through Cell and PS3 supporter BenH ;-)

Ok, thanks for informing. Maybe I'll be faster next time, shouldn't be
difficult to achieve ;).

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]