* [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata
@ 2013-09-20 6:50 Sachin Kamat
2013-09-24 5:40 ` Jingoo Han
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-09-20 6:50 UTC (permalink / raw)
To: linux-fbdev
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/video/backlight/l4f00242t03.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index a35a38c..59eebe0 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -244,7 +244,6 @@ static int l4f00242t03_remove(struct spi_device *spi)
l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
lcd_device_unregister(priv->ld);
- spi_set_drvdata(spi, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata
2013-09-20 6:50 [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata Sachin Kamat
@ 2013-09-24 5:40 ` Jingoo Han
2013-09-26 8:48 ` Tomi Valkeinen
2013-09-27 0:08 ` Jingoo Han
2 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-09-24 5:40 UTC (permalink / raw)
To: linux-fbdev
On Friday, September 20, 2013 3:39 PM, Sachin Kamat wrote:
>
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Jingoo Han <jg1.han@samsung.com>
It looks good.
Thank you for sending the patch.
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata
2013-09-20 6:50 [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata Sachin Kamat
2013-09-24 5:40 ` Jingoo Han
@ 2013-09-26 8:48 ` Tomi Valkeinen
2013-09-27 0:08 ` Jingoo Han
2 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2013-09-26 8:48 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On 20/09/13 09:38, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/video/backlight/l4f00242t03.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> index a35a38c..59eebe0 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -244,7 +244,6 @@ static int l4f00242t03_remove(struct spi_device *spi)
>
> l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
> lcd_device_unregister(priv->ld);
> - spi_set_drvdata(spi, NULL);
>
> return 0;
> }
>
Thanks, queuing this and the second patch for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata
2013-09-20 6:50 [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata Sachin Kamat
2013-09-24 5:40 ` Jingoo Han
2013-09-26 8:48 ` Tomi Valkeinen
@ 2013-09-27 0:08 ` Jingoo Han
2 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-09-27 0:08 UTC (permalink / raw)
To: linux-fbdev
On Thursday, September 26, 2013 5:48 PM, Tomi Valkeinen wrote:
> On 20/09/13 09:38, Sachin Kamat wrote:
> > Driver core sets driver data to NULL upon failure or remove.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > drivers/video/backlight/l4f00242t03.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> > index a35a38c..59eebe0 100644
> > --- a/drivers/video/backlight/l4f00242t03.c
> > +++ b/drivers/video/backlight/l4f00242t03.c
> > @@ -244,7 +244,6 @@ static int l4f00242t03_remove(struct spi_device *spi)
> >
> > l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
> > lcd_device_unregister(priv->ld);
> > - spi_set_drvdata(spi, NULL);
> >
> > return 0;
> > }
> >
>
> Thanks, queuing this and the second patch for 3.13.
>
Hi Tomi Valkeinen,
Andrew Morton already merged these patches to mm-tree with my Acked-by.
So, you don't need to queue these patches.
Thank you for caring. :-)
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-27 0:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 6:50 [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata Sachin Kamat
2013-09-24 5:40 ` Jingoo Han
2013-09-26 8:48 ` Tomi Valkeinen
2013-09-27 0:08 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).