* [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
@ 2013-09-25 11:31 Mark Brown
2013-09-26 0:59 ` Jingoo Han
2013-09-26 8:36 ` Tomi Valkeinen
0 siblings, 2 replies; 5+ messages in thread
From: Mark Brown @ 2013-09-25 11:31 UTC (permalink / raw)
To: Tomi Valkeinen, Jean-Christophe Plagniol-Villard
Cc: linux-fbdev, linux-omap, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
The DSI-CM driver uses the backlight class so needs to build depend on it.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
drivers/video/omap2/displays-new/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig
index 6c90885..10b25e7 100644
--- a/drivers/video/omap2/displays-new/Kconfig
+++ b/drivers/video/omap2/displays-new/Kconfig
@@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
config DISPLAY_PANEL_DSI_CM
tristate "Generic DSI Command Mode Panel"
+ depends on BACKLIGHT_CLASS_DEVICE
help
Driver for generic DSI command mode panels.
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
2013-09-25 11:31 [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier Mark Brown
@ 2013-09-26 0:59 ` Jingoo Han
2013-09-26 8:36 ` Tomi Valkeinen
1 sibling, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-26 0:59 UTC (permalink / raw)
To: 'Mark Brown', 'Tomi Valkeinen',
'Jean-Christophe Plagniol-Villard'
Cc: linux-fbdev, linux-omap, linaro-kernel, 'Mark Brown',
'Jingoo Han'
On Wednesday, September 25, 2013 8:31 PM, Mark Brown wrote:
>
> From: Mark Brown <broonie@linaro.org>
>
> The DSI-CM driver uses the backlight class so needs to build depend on it.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
I checked that the following build errors are removed.
drivers/video/omap2/displays-new/panel-dsi-cm.c:1257: undefined reference to `backlight_device_register'
drivers/video/omap2/displays-new/panel-dsi-cm.c:1283: undefined reference to `backlight_device_unregister'
drivers/built-in.o: In function `dsicm_remove':
drivers/video/omap2/displays-new/panel-dsi-cm.c:1309: undefined reference to `backlight_device_unregister'
Thank you.
Best regards,
Jingoo Han
> ---
> drivers/video/omap2/displays-new/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig
> index 6c90885..10b25e7 100644
> --- a/drivers/video/omap2/displays-new/Kconfig
> +++ b/drivers/video/omap2/displays-new/Kconfig
> @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
>
> config DISPLAY_PANEL_DSI_CM
> tristate "Generic DSI Command Mode Panel"
> + depends on BACKLIGHT_CLASS_DEVICE
> help
> Driver for generic DSI command mode panels.
>
> --
> 1.8.4.rc3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
2013-09-25 11:31 [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier Mark Brown
2013-09-26 0:59 ` Jingoo Han
@ 2013-09-26 8:36 ` Tomi Valkeinen
2013-09-26 10:12 ` Mark Brown
1 sibling, 1 reply; 5+ messages in thread
From: Tomi Valkeinen @ 2013-09-26 8:36 UTC (permalink / raw)
To: Mark Brown
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-omap,
linaro-kernel, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On 25/09/13 14:31, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The DSI-CM driver uses the backlight class so needs to build depend on it.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/video/omap2/displays-new/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig
> index 6c90885..10b25e7 100644
> --- a/drivers/video/omap2/displays-new/Kconfig
> +++ b/drivers/video/omap2/displays-new/Kconfig
> @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
>
> config DISPLAY_PANEL_DSI_CM
> tristate "Generic DSI Command Mode Panel"
> + depends on BACKLIGHT_CLASS_DEVICE
> help
> Driver for generic DSI command mode panels.
>
>
Thanks, I'll queue for 3.12 fixes.
I wish we could "select" instead of "depends on"...
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
2013-09-26 8:36 ` Tomi Valkeinen
@ 2013-09-26 10:12 ` Mark Brown
2013-09-26 10:21 ` Tomi Valkeinen
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2013-09-26 10:12 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-omap,
linaro-kernel
[-- Attachment #1: Type: text/plain, Size: 139 bytes --]
On Thu, Sep 26, 2013 at 11:36:26AM +0300, Tomi Valkeinen wrote:
> I wish we could "select" instead of "depends on"...
We probably could.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
2013-09-26 10:12 ` Mark Brown
@ 2013-09-26 10:21 ` Tomi Valkeinen
0 siblings, 0 replies; 5+ messages in thread
From: Tomi Valkeinen @ 2013-09-26 10:21 UTC (permalink / raw)
To: Mark Brown
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-omap,
linaro-kernel
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 26/09/13 13:12, Mark Brown wrote:
> On Thu, Sep 26, 2013 at 11:36:26AM +0300, Tomi Valkeinen wrote:
>
>> I wish we could "select" instead of "depends on"...
>
> We probably could.
I'm not so sure.
If we select BACKLIGHT_CLASS_DEVICE, we could end up compiling
backlight.c without fbdev, and backlight.c uses fb's funcs.
The funny thing is, there is FB_BACKLIGHT, which seems to be designed to
be selectable (and is selected). That one depends on FB, but if I'm not
mistaken, that dependency does not do anything if FB_BACKLIGHT is selected.
FB_BACKLIGHT in turn selects both BACKLIGHT_LCD_SUPPORT and
BACKLIGHT_CLASS_DEVICE, neither of which seem to be designed to be
selectable.
I think that's a bit broken. Anyway, I guess it's better to "depend on"
here, to be on the safe side.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-26 10:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-25 11:31 [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier Mark Brown
2013-09-26 0:59 ` Jingoo Han
2013-09-26 8:36 ` Tomi Valkeinen
2013-09-26 10:12 ` Mark Brown
2013-09-26 10:21 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).