From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Kamat Date: Thu, 26 Sep 2013 11:59:44 +0000 Subject: [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type Message-Id: <1380196776-27909-1-git-send-email-sachin.kamat@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-fbdev@vger.kernel.org 'lm3630a_read' returns a negative error code upon failure. This will never get detected by unsigned 'rval'. Make it signed. Signed-off-by: Sachin Kamat Cc: Daniel Jeong --- drivers/video/backlight/lm3630a_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index c63f918..65392f9 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip) /* interrupt handling */ static void lm3630a_delayed_func(struct work_struct *work) { - unsigned int rval; + int rval; struct lm3630a_chip *pchip; pchip = container_of(work, struct lm3630a_chip, work.work); -- 1.7.9.5