* [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type
@ 2013-09-26 11:59 Sachin Kamat
2013-09-27 0:14 ` Jingoo Han
2013-09-27 3:20 ` Sachin Kamat
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-26 11:59 UTC (permalink / raw)
To: linux-fbdev
'lm3630a_read' returns a negative error code upon failure. This
will never get detected by unsigned 'rval'. Make it signed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Daniel Jeong <gshark.jeong@gmail.com>
---
drivers/video/backlight/lm3630a_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index c63f918..65392f9 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
/* interrupt handling */
static void lm3630a_delayed_func(struct work_struct *work)
{
- unsigned int rval;
+ int rval;
struct lm3630a_chip *pchip;
pchip = container_of(work, struct lm3630a_chip, work.work);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type
2013-09-26 11:59 [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type Sachin Kamat
@ 2013-09-27 0:14 ` Jingoo Han
2013-09-27 3:20 ` Sachin Kamat
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-09-27 0:14 UTC (permalink / raw)
To: linux-fbdev
On Thursday, September 26, 2013 9:00 PM, Sachin Kamat wrote:
>
> 'lm3630a_read' returns a negative error code upon failure. This
> will never get detected by unsigned 'rval'. Make it signed.
Hi Sachin Kamat,
The same patch was already sent by Dan Carpenter two days ago.
Also, it was merged to mm tree by Andrew Morton with my Acked-by.
Thank you for caring. :-)
Best regards,
Jingoo Han
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Daniel Jeong <gshark.jeong@gmail.com>
> ---
> drivers/video/backlight/lm3630a_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index c63f918..65392f9 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
> /* interrupt handling */
> static void lm3630a_delayed_func(struct work_struct *work)
> {
> - unsigned int rval;
> + int rval;
> struct lm3630a_chip *pchip;
>
> pchip = container_of(work, struct lm3630a_chip, work.work);
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type
2013-09-26 11:59 [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type Sachin Kamat
2013-09-27 0:14 ` Jingoo Han
@ 2013-09-27 3:20 ` Sachin Kamat
1 sibling, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-27 3:20 UTC (permalink / raw)
To: linux-fbdev
On 27 September 2013 05:44, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, September 26, 2013 9:00 PM, Sachin Kamat wrote:
>
> The same patch was already sent by Dan Carpenter two days ago.
> Also, it was merged to mm tree by Andrew Morton with my Acked-by.
> Thank you for caring. :-)
Sounds great, Thanks for letting me know.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-27 3:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-26 11:59 [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type Sachin Kamat
2013-09-27 0:14 ` Jingoo Han
2013-09-27 3:20 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).