* [PATCH] tmio: call tmiofb_set_par in tmiofb_probe
@ 2013-10-17 9:50 Dmitry Eremin-Solenikov
2013-10-19 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-19 12:41 ` Dmitry Eremin-Solenikov
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Eremin-Solenikov @ 2013-10-17 9:50 UTC (permalink / raw)
To: linux-fbdev
Call tmiofb_set_par() to initlaize fixed variable before registering
framebuffer. This is necessary for current kexecboot.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
drivers/video/tmiofb.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/video/tmiofb.c b/drivers/video/tmiofb.c
index deb8733..69fd0f7 100644
--- a/drivers/video/tmiofb.c
+++ b/drivers/video/tmiofb.c
@@ -774,6 +774,10 @@ static int tmiofb_probe(struct platform_device *dev)
if (retval)
goto err_hw_init;
+ retval = tmiofb_set_par(info);
+ if (retval)
+ goto err_set_par;
+
fb_videomode_to_modelist(data->modes, data->num_modes,
&info->modelist);
@@ -787,7 +791,7 @@ static int tmiofb_probe(struct platform_device *dev)
return 0;
err_register_framebuffer:
-/*err_set_par:*/
+err_set_par:
tmiofb_hw_stop(dev);
err_hw_init:
if (cell->disable)
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tmio: call tmiofb_set_par in tmiofb_probe
2013-10-17 9:50 [PATCH] tmio: call tmiofb_set_par in tmiofb_probe Dmitry Eremin-Solenikov
@ 2013-10-19 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-19 12:41 ` Dmitry Eremin-Solenikov
1 sibling, 0 replies; 3+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-10-19 10:48 UTC (permalink / raw)
To: linux-fbdev
On 13:50 Thu 17 Oct , Dmitry Eremin-Solenikov wrote:
> Call tmiofb_set_par() to initlaize fixed variable before registering
> framebuffer. This is necessary for current kexecboot.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
> drivers/video/tmiofb.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/tmiofb.c b/drivers/video/tmiofb.c
> index deb8733..69fd0f7 100644
> --- a/drivers/video/tmiofb.c
> +++ b/drivers/video/tmiofb.c
> @@ -774,6 +774,10 @@ static int tmiofb_probe(struct platform_device *dev)
> if (retval)
> goto err_hw_init;
>
> + retval = tmiofb_set_par(info);
> + if (retval)
> + goto err_set_par;
> +
sorry no fix kexecboot
Best Regards,
J.
> fb_videomode_to_modelist(data->modes, data->num_modes,
> &info->modelist);
>
> @@ -787,7 +791,7 @@ static int tmiofb_probe(struct platform_device *dev)
> return 0;
>
> err_register_framebuffer:
> -/*err_set_par:*/
> +err_set_par:
> tmiofb_hw_stop(dev);
> err_hw_init:
> if (cell->disable)
> --
> 1.8.4.rc3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tmio: call tmiofb_set_par in tmiofb_probe
2013-10-17 9:50 [PATCH] tmio: call tmiofb_set_par in tmiofb_probe Dmitry Eremin-Solenikov
2013-10-19 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2013-10-19 12:41 ` Dmitry Eremin-Solenikov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Eremin-Solenikov @ 2013-10-19 12:41 UTC (permalink / raw)
To: linux-fbdev
On Sat, Oct 19, 2013 at 2:48 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> On 13:50 Thu 17 Oct , Dmitry Eremin-Solenikov wrote:
>> Call tmiofb_set_par() to initlaize fixed variable before registering
>> framebuffer. This is necessary for current kexecboot.
>>
>> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>> ---
>> drivers/video/tmiofb.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/tmiofb.c b/drivers/video/tmiofb.c
>> index deb8733..69fd0f7 100644
>> --- a/drivers/video/tmiofb.c
>> +++ b/drivers/video/tmiofb.c
>> @@ -774,6 +774,10 @@ static int tmiofb_probe(struct platform_device *dev)
>> if (retval)
>> goto err_hw_init;
>>
>> + retval = tmiofb_set_par(info);
>> + if (retval)
>> + goto err_set_par;
>> +
>
> sorry no fix kexecboot
So calling set_par in _probe() is deprecated/fromn upon? Why?
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-19 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 9:50 [PATCH] tmio: call tmiofb_set_par in tmiofb_probe Dmitry Eremin-Solenikov
2013-10-19 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-19 12:41 ` Dmitry Eremin-Solenikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).