From: Johan Hovold <jhovold@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>, Jingoo Han <jg1.han@samsung.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <jhovold@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH 1/9] backlight: atmel-pwm-bl: fix reported brightness
Date: Wed, 23 Oct 2013 09:55:35 +0000 [thread overview]
Message-ID: <1382522143-32072-2-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1382522143-32072-1-git-send-email-jhovold@gmail.com>
The driver supports 16-bit brightness values, but the value returned
from get_brightness was truncated to eight bits.
Cc: stable@vger.kernel.org
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
drivers/video/backlight/atmel-pwm-bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
index 66885fb..8aac273 100644
--- a/drivers/video/backlight/atmel-pwm-bl.c
+++ b/drivers/video/backlight/atmel-pwm-bl.c
@@ -70,7 +70,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd)
static int atmel_pwm_bl_get_intensity(struct backlight_device *bd)
{
struct atmel_pwm_bl *pwmbl = bl_get_data(bd);
- u8 intensity;
+ u32 intensity;
if (pwmbl->pdata->pwm_active_low) {
intensity = pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY) -
@@ -80,7 +80,7 @@ static int atmel_pwm_bl_get_intensity(struct backlight_device *bd)
pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY);
}
- return intensity;
+ return (u16)intensity;
}
static int atmel_pwm_bl_init_pwm(struct atmel_pwm_bl *pwmbl)
--
1.8.4
next prev parent reply other threads:[~2013-10-23 9:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 9:55 [PATCH RESEND 0/9] backlight: atmel-pwm-bl: fixes and clean ups Johan Hovold
2013-10-23 9:55 ` Johan Hovold [this message]
2013-10-25 11:08 ` [PATCH 1/9] backlight: atmel-pwm-bl: fix reported brightness Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:32 ` Johan Hovold
2013-10-23 9:55 ` [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Johan Hovold
2013-10-25 11:09 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:08 ` Johan Hovold
2013-10-23 9:55 ` [PATCH 3/9] backlight: atmel-pwm-bl: fix module autoload Johan Hovold
2013-10-23 9:55 ` [PATCH 4/9] backlight: atmel-pwm-bl: clean up probe error handling Johan Hovold
2013-10-25 11:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:09 ` Johan Hovold
2013-10-23 9:55 ` [PATCH 5/9] backlight: atmel-pwm-bl: clean up get_intensity Johan Hovold
2013-10-25 11:12 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-23 9:55 ` [PATCH 6/9] backlight: atmel-pwm-bl: remove unused include Johan Hovold
2013-10-23 9:55 ` [PATCH 7/9] backlight: atmel-pwm-bl: use gpio_is_valid Johan Hovold
2013-10-23 9:55 ` [PATCH 8/9] backlight: atmel-pwm-bl: refactor gpio_on handling Johan Hovold
2013-10-25 11:13 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-23 9:55 ` [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one Johan Hovold
2013-10-25 11:15 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:20 ` Johan Hovold
2013-10-30 19:30 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 16:27 ` [PATCH v2 0/9] backlight: atmel-pwm-bl: fixes and clean ups Johan Hovold
2013-10-29 16:27 ` [PATCH v2 1/9] backlight: atmel-pwm-bl: fix reported brightness Johan Hovold
2013-10-29 16:27 ` [PATCH v2 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Johan Hovold
2013-10-29 16:27 ` [PATCH v2 3/9] backlight: atmel-pwm-bl: fix module autoload Johan Hovold
2013-10-29 16:27 ` [PATCH v2 4/9] backlight: atmel-pwm-bl: clean up probe error handling Johan Hovold
2013-10-29 16:27 ` [PATCH v2 5/9] backlight: atmel-pwm-bl: clean up get_intensity Johan Hovold
2013-10-29 16:27 ` [PATCH v2 6/9] backlight: atmel-pwm-bl: remove unused include Johan Hovold
2013-10-29 16:27 ` [PATCH v2 7/9] backlight: atmel-pwm-bl: use gpio_is_valid Johan Hovold
2013-10-29 16:27 ` [PATCH v2 8/9] backlight: atmel-pwm-bl: refactor gpio_on handling Johan Hovold
2013-10-29 16:27 ` [PATCH v2 9/9] backlight: atmel-pwm-bl: use gpio_request_one Johan Hovold
2013-10-31 17:57 ` [PATCH v3 0/9] backlight: atmel-pwm-bl: fixes and clean ups Johan Hovold
2013-10-31 17:57 ` [PATCH v3 1/9] backlight: atmel-pwm-bl: fix reported brightness Johan Hovold
2013-10-31 17:57 ` [PATCH v3 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Johan Hovold
2013-10-31 17:57 ` [PATCH v3 3/9] backlight: atmel-pwm-bl: fix module autoload Johan Hovold
2013-10-31 17:57 ` [PATCH v3 4/9] backlight: atmel-pwm-bl: clean up probe error handling Johan Hovold
2013-10-31 17:57 ` [PATCH v3 5/9] backlight: atmel-pwm-bl: clean up get_intensity Johan Hovold
2013-10-31 17:57 ` [PATCH v3 6/9] backlight: atmel-pwm-bl: remove unused include Johan Hovold
2013-10-31 17:57 ` [PATCH v3 7/9] backlight: atmel-pwm-bl: use gpio_is_valid Johan Hovold
2013-10-31 17:57 ` [PATCH v3 8/9] backlight: atmel-pwm-bl: refactor gpio_on handling Johan Hovold
2013-10-31 17:57 ` [PATCH v3 9/9] backlight: atmel-pwm-bl: use gpio_request_one Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2013-10-22 17:26 [PATCH 0/9] backlight: atmel-pwm-bl: fixes and clean ups Johan Hovold
2013-10-22 17:26 ` [PATCH 1/9] backlight: atmel-pwm-bl: fix reported brightness Johan Hovold
2013-10-23 1:20 ` Jingoo Han
2013-10-23 8:51 ` Johan Hovold
2013-10-23 9:35 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382522143-32072-2-git-send-email-jhovold@gmail.com \
--to=jhovold@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rpurdie@rpsys.net \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).