* [PATCH] video/logo: Remove MIPS-specific include section
@ 2013-11-04 8:42 Geert Uytterhoeven
2013-11-04 17:13 ` Ralf Baechle
2014-01-10 11:56 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2013-11-04 8:42 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Ralf Baechle, linux-fbdev, linux-mips, Geert Uytterhoeven
Since commit 41702d9a4fffa9e25b2ad9d4af09b3013fa155e1 ("logo.c: get rid of
mips_machgroup") there's no longer a need to include <asm/bootinfo.h> on
MIPS.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/video/logo/logo.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/video/logo/logo.c b/drivers/video/logo/logo.c
index 080c35b34bbb..b670cbda38e3 100644
--- a/drivers/video/logo/logo.c
+++ b/drivers/video/logo/logo.c
@@ -17,10 +17,6 @@
#include <asm/setup.h>
#endif
-#ifdef CONFIG_MIPS
-#include <asm/bootinfo.h>
-#endif
-
static bool nologo;
module_param(nologo, bool, 0);
MODULE_PARM_DESC(nologo, "Disables startup logo");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] video/logo: Remove MIPS-specific include section
2013-11-04 8:42 [PATCH] video/logo: Remove MIPS-specific include section Geert Uytterhoeven
@ 2013-11-04 17:13 ` Ralf Baechle
2014-01-10 11:56 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2013-11-04 17:13 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
linux-mips
On Mon, Nov 04, 2013 at 09:42:30AM +0100, Geert Uytterhoeven wrote:
> Since commit 41702d9a4fffa9e25b2ad9d4af09b3013fa155e1 ("logo.c: get rid of
> mips_machgroup") there's no longer a need to include <asm/bootinfo.h> on
> MIPS.
Yes,
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Generally CONFIG_<ARCH> should probably be considered a bug even if only
it's used to hide crap like this.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] video/logo: Remove MIPS-specific include section
2013-11-04 8:42 [PATCH] video/logo: Remove MIPS-specific include section Geert Uytterhoeven
2013-11-04 17:13 ` Ralf Baechle
@ 2014-01-10 11:56 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2014-01-10 11:56 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jean-Christophe Plagniol-Villard, Ralf Baechle, linux-fbdev,
linux-mips
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On 2013-11-04 10:42, Geert Uytterhoeven wrote:
> Since commit 41702d9a4fffa9e25b2ad9d4af09b3013fa155e1 ("logo.c: get rid of
> mips_machgroup") there's no longer a need to include <asm/bootinfo.h> on
> MIPS.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/video/logo/logo.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/logo/logo.c b/drivers/video/logo/logo.c
> index 080c35b34bbb..b670cbda38e3 100644
> --- a/drivers/video/logo/logo.c
> +++ b/drivers/video/logo/logo.c
> @@ -17,10 +17,6 @@
> #include <asm/setup.h>
> #endif
>
> -#ifdef CONFIG_MIPS
> -#include <asm/bootinfo.h>
> -#endif
> -
> static bool nologo;
> module_param(nologo, bool, 0);
> MODULE_PARM_DESC(nologo, "Disables startup logo");
>
Queued for 3.14.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-10 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-04 8:42 [PATCH] video/logo: Remove MIPS-specific include section Geert Uytterhoeven
2013-11-04 17:13 ` Ralf Baechle
2014-01-10 11:56 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).