From: Gerd Hoffmann <kraxel@redhat.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
KY Srinivasan <kys@microsoft.com>,
"Abhishek Gupta (LIS)" <abgupta@microsoft.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"tomi.valkeinen@ti.com" <tomi.valkeinen@ti.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v4 2/2] hyperv-fb: kick off efifb early
Date: Wed, 26 Feb 2014 09:49:31 +0000 [thread overview]
Message-ID: <1393408171.4744.32.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <5414def7813d4bccbcf1b128b6a5ee46@DFM-DB3MBX15-06.exchange.corp.microsoft.com>
Hi,
> > diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c index
> > b7b3dd0..1b11886 100644
> > --- a/drivers/video/hyperv_fb.c
> > +++ b/drivers/video/hyperv_fb.c
> > @@ -683,6 +683,7 @@ static int hvfb_getmem(struct fb_info *info)
> > info->apertures->ranges[0].base = pci_resource_start(pdev, 0);
> > info->apertures->ranges[0].size = pci_resource_len(pdev, 0);
> > }
> > + remove_conflicting_framebuffers(info->apertures,
> > KBUILD_MODNAME,
> > +false);
>
> Thanks for the updates. I'm concerned about, after removing efifb,
> if synthvid_send_config(hdev) fails, then there will be no video driver
> available.
That may happen, yes.
> Is there a way to bring the generic driver back if
> synthvid_send_config(hdev) fails?
Not that I know of.
> If no way to recover the generic driver, please limit the early
> remove_conflicting_framebuffers() to Gen2 VM only.
I'll send updated patches once they are tested.
cheers,
Gerd
prev parent reply other threads:[~2014-02-26 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 12:28 [PATCH v4 0/2] hyperv-fb: add support for generation 2 virtual machines Gerd Hoffmann
2014-02-25 12:28 ` [PATCH v4 1/2] " Gerd Hoffmann
2014-02-25 12:28 ` [PATCH v4 2/2] hyperv-fb: kick off efifb early Gerd Hoffmann
2014-02-25 15:51 ` Haiyang Zhang
2014-02-26 9:49 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393408171.4744.32.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=abgupta@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).