From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Date: Wed, 26 Feb 2014 09:49:31 +0000 Subject: Re: [PATCH v4 2/2] hyperv-fb: kick off efifb early Message-Id: <1393408171.4744.32.camel@nilsson.home.kraxel.org> List-Id: References: <1393331320-18147-1-git-send-email-kraxel@redhat.com> <1393331320-18147-3-git-send-email-kraxel@redhat.com> <5414def7813d4bccbcf1b128b6a5ee46@DFM-DB3MBX15-06.exchange.corp.microsoft.com> In-Reply-To: <5414def7813d4bccbcf1b128b6a5ee46@DFM-DB3MBX15-06.exchange.corp.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Haiyang Zhang Cc: "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , KY Srinivasan , "Abhishek Gupta (LIS)" , "jasowang@redhat.com" , "tomi.valkeinen@ti.com" , "devel@linuxdriverproject.org" , Jean-Christophe Plagniol-Villard Hi, > > diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c index > > b7b3dd0..1b11886 100644 > > --- a/drivers/video/hyperv_fb.c > > +++ b/drivers/video/hyperv_fb.c > > @@ -683,6 +683,7 @@ static int hvfb_getmem(struct fb_info *info) > > info->apertures->ranges[0].base = pci_resource_start(pdev, 0); > > info->apertures->ranges[0].size = pci_resource_len(pdev, 0); > > } > > + remove_conflicting_framebuffers(info->apertures, > > KBUILD_MODNAME, > > +false); > > Thanks for the updates. I'm concerned about, after removing efifb, > if synthvid_send_config(hdev) fails, then there will be no video driver > available. That may happen, yes. > Is there a way to bring the generic driver back if > synthvid_send_config(hdev) fails? Not that I know of. > If no way to recover the generic driver, please limit the early > remove_conflicting_framebuffers() to Gen2 VM only. I'll send updated patches once they are tested. cheers, Gerd