From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Date: Wed, 19 Mar 2014 08:03:53 +0000 Subject: Re: [PATCHv2 4/8] Doc/DT: Add DT binding documentation for HDMI Connector Message-Id: <1395216233.4300.6.camel@paszta.hi.pengutronix.de> List-Id: References: <1395130547-18633-1-git-send-email-tomi.valkeinen@ti.com> <1395130547-18633-5-git-send-email-tomi.valkeinen@ti.com> <1395132234.4134.1.camel@paszta.hi.pengutronix.de> <1664822.t9aWz7hh4g@avalon> In-Reply-To: <1664822.t9aWz7hh4g@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Pinchart Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Russell King - ARM Linux , dri-devel@lists.freedesktop.org, Andrzej Hajda , Tomi Valkeinen , Geert Uytterhoeven , Rob Herring , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Hi Laurent, Am Mittwoch, den 19.03.2014, 00:43 +0100 schrieb Laurent Pinchart: > Hello, > > On Tuesday 18 March 2014 09:43:54 Philipp Zabel wrote: > > Am Dienstag, den 18.03.2014, 10:15 +0200 schrieb Tomi Valkeinen: > > > Add DT binding documentation for HDMI Connector. > > > > > > Signed-off-by: Tomi Valkeinen > > > Reviewed-by: Archit Taneja > > > --- > > > > > > .../devicetree/bindings/video/hdmi-connector.txt | 28 +++++++++++++++++ > > > 1 file changed, 28 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/video/hdmi-connector.txt> > > > diff --git a/Documentation/devicetree/bindings/video/hdmi-connector.txt > > > b/Documentation/devicetree/bindings/video/hdmi-connector.txt new file > > > mode 100644 > > > index 000000000000..ccccc19e2573 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/video/hdmi-connector.txt > > > @@ -0,0 +1,28 @@ > > > +HDMI Connector > > > +======= > > > + > > > +Required properties: > > > +- compatible: "hdmi-connector" > > > +- type: the HDMI connector type: "a", "b", "c", "d" or "e" > > > + > > > +Optional properties: > > > +- label: a symbolic name for the connector > > > + > > > +Required nodes: > > > +- Video port for HDMI input > > > > Geert's comment also applies to all other connector types. These can be > > input connectors, too. > > We might not need to define all the properties required by input connectors > now, but we need to make sure that future extensions will be backward- > compatible. I don't see a problem in making the connector DT bindings depend > on the direction as long as the direction is specified in the DT node, either > explicitly or implicitly. > > An obvious solution would be to have separate "hdmi-input-connector" and > "hdmi-output-connector" compatible strings but I don't like that, as there's > no difference in the HDMI connector itself, only in the usage. I don't think this is necessary, either. I just meant the wording for the video port should leave the direction unspecified. I imagine somebody somewhere will connect a HDMI connector to a mux so that it can be either input or output. > We could also add a "direction" property (possibly later, with a default value > of "output" in that case), or rely on the link direction, but in the latter > case that would require reaching an agreement in the current link directions > debate. If we add a direction property, I think it should be on the ports. regards Philipp