From: Peter Griffin <peter.griffin@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: linaro-kernel@lists.linaro.org, Arnd Bergmann <arnd@arndb.de>,
Peter Griffin <peter.griffin@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, Raphael Assenat <raph@8d.com>,
Mike Rapoport <mike@compulab.co.il>
Subject: [PATCH 05/13] video/mbx: fix building debugfs support
Date: Thu, 24 Apr 2014 12:28:21 +0000 [thread overview]
Message-ID: <1398342509-10243-6-git-send-email-peter.griffin@linaro.org> (raw)
In-Reply-To: <1398342509-10243-1-git-send-email-peter.griffin@linaro.org>
From: Arnd Bergmann <arnd@arndb.de>
The mbx framebuffer debugfs support apparently hasn't been able
to build for a long time, at least since 2006 when the u.generic_ip
field in the inode was removed. This fixes the obvious bug, and
also makes it possible to build the driver as a module when
debugfs support is enabled, by simply including the C file.
It's ugly, but it won't make the driver any worse than it
already is, and doesn't require a more invasive change that
might break it further.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Raphael Assenat <raph@8d.com>
Cc: Mike Rapoport <mike@compulab.co.il>
---
drivers/video/fbdev/mbx/Makefile | 3 +--
drivers/video/fbdev/mbx/mbxdebugfs.c | 2 +-
drivers/video/fbdev/mbx/mbxfb.c | 2 ++
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/mbx/Makefile b/drivers/video/fbdev/mbx/Makefile
index 16c1165..d7ae5a9 100644
--- a/drivers/video/fbdev/mbx/Makefile
+++ b/drivers/video/fbdev/mbx/Makefile
@@ -1,4 +1,3 @@
# Makefile for the 2700G controller driver.
-obj-$(CONFIG_FB_MBX) += mbxfb.o
-obj-$(CONFIG_FB_MBX_DEBUG) += mbxfbdebugfs.o
+obj-y += mbxfb.o
diff --git a/drivers/video/fbdev/mbx/mbxdebugfs.c b/drivers/video/fbdev/mbx/mbxdebugfs.c
index 4449f24..e3bc00a 100644
--- a/drivers/video/fbdev/mbx/mbxdebugfs.c
+++ b/drivers/video/fbdev/mbx/mbxdebugfs.c
@@ -17,7 +17,7 @@ struct mbxfb_debugfs_data {
static int open_file_generic(struct inode *inode, struct file *file)
{
- file->private_data = inode->u.generic_ip;
+ file->private_data = inode->i_private;
return 0;
}
diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c
index f0a5392..2bd52ed 100644
--- a/drivers/video/fbdev/mbx/mbxfb.c
+++ b/drivers/video/fbdev/mbx/mbxfb.c
@@ -877,6 +877,8 @@ static int mbxfb_resume(struct platform_device *dev)
#ifndef CONFIG_FB_MBX_DEBUG
#define mbxfb_debugfs_init(x) do {} while(0)
#define mbxfb_debugfs_remove(x) do {} while(0)
+#else
+#include "mbxdebugfs.c"
#endif
#define res_size(_r) (((_r)->end - (_r)->start) + 1)
--
1.7.9.5
next prev parent reply other threads:[~2014-04-24 12:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398342509-10243-1-git-send-email-peter.griffin@linaro.org>
2014-04-24 12:28 ` [PATCH 01/13] video: sh_mobile_lcdcfb depends on meram Peter Griffin
2014-04-24 12:28 ` [PATCH 02/13] video: omap2dss: fix LPAE warnings Peter Griffin
2014-04-24 12:28 ` [PATCH 03/13] video: clarify I2C dependencies Peter Griffin
2014-04-24 12:32 ` Russell King - ARM Linux
2014-04-24 12:48 ` Arnd Bergmann
2014-04-24 12:28 ` [PATCH 04/13] video/omap: fix modular build Peter Griffin
2014-04-24 12:28 ` Peter Griffin [this message]
2014-04-24 12:28 ` [PATCH 06/13] video: export fb_prepare_logo Peter Griffin
2014-04-24 12:28 ` [PATCH 07/13] video: atmel needs FB_BACKLIGHT Peter Griffin
2014-04-24 12:28 ` [PATCH 08/13] video/backlight: LM3630A needs PWM Peter Griffin
2014-04-24 16:45 ` Bryan Wu
2014-04-25 9:00 ` Jingoo Han
2014-04-28 10:14 ` Lee Jones
2014-04-24 12:28 ` [PATCH 09/13] video/backlight: LP8788 " Peter Griffin
2014-04-24 16:45 ` Bryan Wu
2014-04-24 22:42 ` Milo Kim
2014-04-25 8:54 ` Jingoo Han
2014-04-28 10:16 ` Lee Jones
2014-04-24 12:28 ` [PATCH 10/13] video/pxa: LCD_CORGI needs BACKLIGHT_CLASS_DEVICE Peter Griffin
2014-04-24 16:46 ` Bryan Wu
2014-04-25 8:58 ` Jingoo Han
2014-04-28 10:15 ` Lee Jones
2014-04-24 12:28 ` [PATCH 11/13] video/nuc900: allow modular build Peter Griffin
2014-04-24 12:28 ` [PATCH 12/13] video/backlight: LP855X needs PWM Peter Griffin
2014-04-24 16:48 ` Bryan Wu
2014-04-24 22:43 ` Milo Kim
2014-04-25 9:02 ` Jingoo Han
2014-04-28 10:16 ` Lee Jones
2014-04-24 12:28 ` [PATCH 13/13] video: omap: allow building on !MMU Peter Griffin
2014-05-07 9:14 ` Tomi Valkeinen
2014-05-08 21:53 ` Tony Lindgren
2014-05-08 23:04 ` Aaro Koskinen
2014-05-08 23:17 ` Tony Lindgren
2014-05-09 21:21 ` Aaro Koskinen
2014-05-11 15:01 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398342509-10243-6-git-send-email-peter.griffin@linaro.org \
--to=peter.griffin@linaro.org \
--cc=arnd@arndb.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=plagnioj@jcrosoft.com \
--cc=raph@8d.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).