From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
To: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Jingoo Han <jg1.han@samsung.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Clark <robdclark@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] video: fbdev: sis: init301.c: Cleaning up useless if statement
Date: Sun, 15 Jun 2014 21:52:09 +0000 [thread overview]
Message-ID: <1402869130-4962-1-git-send-email-rickard_strandqvist@spectrumdigital.se> (raw)
The same code regardless of the outcome of the if statement. This may of
course be a miss and there should be a difference in the code.
And sets a variable that is missed, a probable cut and paste mistake.
This was partly found using a static code analysis program called cppcheck.
Rickard Strandqvist (1):
video: fbdev: sis: init301.c: Cleaning up useless if statement
drivers/video/fbdev/sis/init301.c | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
--
1.7.10.4
next reply other threads:[~2014-06-15 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 21:52 Rickard Strandqvist [this message]
2014-06-15 21:52 ` [PATCH] video: fbdev: sis: init301.c: Cleaning up useless if statement Rickard Strandqvist
2014-07-02 22:08 ` [PATCH] video: fbdev: sis: init301.c: Cleaning up a potential division by zero Rickard Strandqvist
2014-07-02 22:08 ` Rickard Strandqvist
2014-07-05 12:49 ` [PATCH] video: fbdev: sis: init301.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 18:59 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402869130-4962-1-git-send-email-rickard_strandqvist@spectrumdigital.se \
--to=rickard_strandqvist@spectrumdigital.se \
--cc=jg1.han@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=robdclark@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox