From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Mon, 16 Jun 2014 07:32:17 +0000 Subject: Re: [PATCH] offb: Fix little-endian support Message-Id: <1402903937.7661.33.camel@pasglop> List-Id: References: <1400073709-15012-1-git-send-email-tiwai@suse.de> <5373772D.9060807@fr.ibm.com> <5373A200.6080301@fr.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Takashi Iwai Cc: Cedric Le Goater , Dinar Valeev , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 2014-05-14 at 19:57 +0200, Takashi Iwai wrote: > > Hm, so it actually regressed on BE? > > It's strange because fb_math_be() should be true and the patch won't > change the values in that case... Shouldn't the patch be based on foreign endian being set rather than just "be" anyway ? IE. If the fb is LE and the host is LE we *also* don't want to change the ordering, which will be the case when we fix qemu... Cheers, Ben.