From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
To: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Jingoo Han <jg1.han@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Clark <robdclark@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] video: fbdev: omap: omapfb_main.c: Cleaning up wrong type in format string
Date: Sat, 05 Jul 2014 13:22:31 +0000 [thread overview]
Message-ID: <1404566552-23096-1-git-send-email-rickard_strandqvist@spectrumdigital.se> (raw)
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Wrong type in sscanf format string, requires 'int *' but the
argument type is 'unsigned int *'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/omap/omapfb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index d8d028d..7df0764 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1371,7 +1371,7 @@ static ssize_t omapfb_store_bklight_level(struct device *dev,
if (fbdev->panel->set_bklight_level) {
unsigned int level;
- if (sscanf(buf, "%10d", &level) = 1) {
+ if (sscanf(buf, "%10u", &level) = 1) {
r = fbdev->panel->set_bklight_level(fbdev->panel,
level);
} else
--
1.7.10.4
next reply other threads:[~2014-07-05 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 13:22 Rickard Strandqvist [this message]
2014-07-05 16:24 ` [PATCH] video: fbdev: omap: omapfb_main.c: Cleaning up removal variable thet is never used Rickard Strandqvist
2014-07-06 17:34 ` [PATCH] video: fbdev: omap: omapfb_main.c: Cleaning up wrong type in format string Rickard Strandqvist
2014-07-06 18:01 ` Joe Perches
2014-07-06 17:57 ` [PATCH] video: fbdev: omap: omapfb_main.c: Cleaning up removal variable thet is never used Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404566552-23096-1-git-send-email-rickard_strandqvist@spectrumdigital.se \
--to=rickard_strandqvist@spectrumdigital.se \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=jg1.han@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rickard.strandqvist@sonymobile.com \
--cc=robdclark@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox